mirror of
https://github.com/vllm-project/vllm-ascend.git
synced 2025-10-20 13:43:53 +08:00
### What this PR does / why we need it?
Follow vllm-project/vllm lint way:
https://github.com/vllm-project/vllm/blob/main/.pre-commit-config.yaml
Enable pre-commit to avoid some low level error AMAP.
This pr is one step of #1241, The purpose is make linting system more
clear and convenient, on this step, Mainly did the following things:
yapf, actionlint, ruff, typos, isort, mypy, png-lint, signoff-commit,
enforce-import-regex-instead-of-re.
TODO:
- clang-format(check for csrc with google style)
need clean code, disable for now
- pymarkdown
need clean code, disable for now
- shellcheck
need clean code, disable for now
### Does this PR introduce _any_ user-facing change?
Only developer UX change:
https://vllm-ascend--1256.org.readthedocs.build/en/1256/developer_guide/contributing.html#run-lint-locally
```
pip install -r requirements-lint.txt && pre-commit install
bash format.sh
```
### How was this patch tested?
CI passed with new added/existing test.
Co-authored-by: Yikun [yikunkero@gmail.com](mailto:yikunkero@gmail.com)
Co-authored-by: wangli
[wangli858794774@gmail.com](mailto:wangli858794774@gmail.com)
- vLLM version: v0.9.1
- vLLM main:
5358cce5ff
---------
Signed-off-by: wangli <wangli858794774@gmail.com>
101 lines
2.4 KiB
YAML
101 lines
2.4 KiB
YAML
name: Release Checklist
|
|
description: Generate a release checklist issue when prepare a new release.(Used for release team)
|
|
title: "[Release]: Release checklist for v"
|
|
|
|
body:
|
|
- type: textarea
|
|
attributes:
|
|
description: >
|
|
Brief info for the new release.
|
|
label: Release Checklist
|
|
value: >
|
|
**Release Version**:
|
|
|
|
**Release Branch**:
|
|
|
|
**Release Date**:
|
|
|
|
**Release Manager**:
|
|
- type: textarea
|
|
attributes:
|
|
description: >
|
|
Release notes.
|
|
label: Prepare Release Note
|
|
value: >
|
|
- [ ] Create a new issue for release feedback
|
|
|
|
- [ ] Write the release note PR.
|
|
|
|
- [ ] Update the feedback issue link in docs/source/faqs.md
|
|
|
|
- [ ] Add release note to docs/source/user_guide/release_notes.md
|
|
|
|
- [ ] Update version info in docs/source/community/versioning_policy.md
|
|
|
|
- [ ] Update contributor info in docs/source/community/contributors.md
|
|
|
|
- [ ] Update package version in docs/conf.py
|
|
- type: textarea
|
|
attributes:
|
|
description: >
|
|
Make sure the code is merged.
|
|
label: PR need Merge
|
|
value: >
|
|
- [ ] PR link1
|
|
|
|
- [ ] PR link2
|
|
|
|
- [ ] ...
|
|
- type: textarea
|
|
attributes:
|
|
description: >
|
|
Make sure the new Feature/Function is tested
|
|
label: Functional Test
|
|
value: >
|
|
- [ ] Feature1
|
|
|
|
- [ ] Bug1
|
|
|
|
- [ ] ...
|
|
- type: textarea
|
|
attributes:
|
|
description: >
|
|
Make sure the doc is updated.
|
|
label: Doc Test
|
|
value: >
|
|
- [ ] Tutorial is updated.
|
|
|
|
- [ ] User Guide is updated.
|
|
|
|
- [ ] Developer Guide is updated.
|
|
- type: textarea
|
|
attributes:
|
|
description: >
|
|
Make sure the artifacts is ready
|
|
label: Prepare Artifacts
|
|
value: >
|
|
- [ ] Docker image is ready.
|
|
|
|
- [ ] Wheel package is ready.
|
|
- type: textarea
|
|
attributes:
|
|
description: >
|
|
Start to release.
|
|
label: Release Step
|
|
value: >
|
|
- [ ] Release note PR is merged.
|
|
|
|
- [ ] Post the release on GitHub release page.
|
|
|
|
- [ ] Generate official doc page on https://app.readthedocs.org/dashboard/
|
|
|
|
- [ ] Wait for the wheel package to be available on https://pypi.org/project/vllm-ascend
|
|
|
|
- [ ] Wait for the docker image to be available on https://quay.io/ascend/vllm-ascend
|
|
|
|
- [ ] Upload 310p wheel to Github release page
|
|
|
|
- [ ] Broadcast the release news (By message, blog , etc)
|
|
|
|
- [ ] Close this issue
|