mirror of
https://github.com/volcengine/verl.git
synced 2025-10-20 13:43:50 +08:00
515f2255ac
### What does this PR do?
- As title
### Checklist Before Starting
- [ ] Search for similar PRs. Paste at least one query link here: ...
- [ ] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
- `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
- Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`
### Test
> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.
### API and Usage Example
> Demonstrate how the API changes if any, and provide usage example(s)
if possible.
```python
# Add code snippet or script demonstrating how to use this
```
### Design & Code Changes
> Demonstrate the high-level design if this PR is complex, and list the
specific changes.
### Checklist Before Submitting
> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.
- [ ] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [ ] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
119 lines
3.4 KiB
YAML
119 lines
3.4 KiB
YAML
name: e2e_spin
|
|
|
|
on:
|
|
# Trigger the workflow on push or pull request,
|
|
# but only for the main branch
|
|
push:
|
|
branches:
|
|
- main
|
|
- v0.*
|
|
paths:
|
|
- "**/*.py"
|
|
# Other entrypoints
|
|
- "!examples/**"
|
|
- "!tests/**"
|
|
- "!verl/trainer/main_*.py"
|
|
- "!verl/trainer/fsdp_sft_trainer.py"
|
|
# Other recipes
|
|
- "!recipe/**"
|
|
# Megatron
|
|
- "!verl/workers/**/megatron_*.py"
|
|
# Home
|
|
- "recipe/spin"
|
|
# Entrypoints
|
|
- ".github/workflows/e2e_spin.yml"
|
|
- "examples/data_preprocess/gsm8k.py"
|
|
- "tests/special_e2e/run_spin.sh"
|
|
- "!examples"
|
|
pull_request:
|
|
branches:
|
|
- main
|
|
- v0.*
|
|
paths:
|
|
- "**/*.py"
|
|
# Other entrypoints
|
|
- "!examples/**"
|
|
- "!tests/**"
|
|
- "!verl/trainer/main_*.py"
|
|
- "!verl/trainer/fsdp_sft_trainer.py"
|
|
# Other recipes
|
|
- "!recipe/**"
|
|
# Megatron
|
|
- "!verl/workers/**/megatron_*.py"
|
|
# Home
|
|
- "recipe/spin"
|
|
# Entrypoints
|
|
- ".github/workflows/e2e_spin.yml"
|
|
- "examples/data_preprocess/gsm8k.py"
|
|
- "tests/special_e2e/run_spin.sh"
|
|
- "!examples"
|
|
|
|
# Declare permissions just read content.
|
|
permissions:
|
|
contents: read
|
|
|
|
env:
|
|
IMAGE: "verl-ci-cn-beijing.cr.volces.com/verlai/verl:app-verl0.5-transformers4.55.4-sglang0.4.10.post2-mcore0.13.0-te2.2"
|
|
DYNAMIC_RUNNER_ENDPOINT: "https://sd10g3clalm04ug7alq90.apigateway-cn-beijing.volceapi.com/runner"
|
|
|
|
# Cancel jobs on the same ref if a new one is triggered
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
|
|
|
|
jobs:
|
|
setup:
|
|
if: github.repository_owner == 'volcengine'
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
runner-label: ${{ steps.create-runner.outputs.runner-label }}
|
|
mlp-task-id: ${{ steps.create-runner.outputs.mlp-task-id }}
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- id: create-runner
|
|
uses: volcengine/vemlp-github-runner@v1
|
|
with:
|
|
mode: "create"
|
|
faas-url: "${{ env.DYNAMIC_RUNNER_ENDPOINT }}"
|
|
mlp-image: "${{ env.IMAGE }}"
|
|
|
|
e2e_spin:
|
|
needs: setup
|
|
runs-on: [ "${{ needs.setup.outputs.runner-label || 'L20x8' }}" ]
|
|
timeout-minutes: 40 # Increase this timeout value as needed
|
|
env:
|
|
HTTP_PROXY: ${{ secrets.PROXY_HTTP }}
|
|
HTTPS_PROXY: ${{ secrets.PROXY_HTTPS }}
|
|
NO_PROXY: "localhost,127.0.0.1,hf-mirror.com"
|
|
HF_ENDPOINT: "https://hf-mirror.com"
|
|
HF_HUB_ENABLE_HF_TRANSFER: "0" # This is more stable
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
|
with:
|
|
fetch-depth: 0
|
|
- name: Install the current repository
|
|
run: |
|
|
pip3 install -e .[test,gpu,sglang]
|
|
- name: Prepare GSM8K dataset
|
|
run: |
|
|
python3 examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
|
|
- name: Running the E2E test with the spin algorithm
|
|
run: |
|
|
ray stop --force
|
|
bash tests/special_e2e/run_spin.sh
|
|
|
|
cleanup:
|
|
runs-on: ubuntu-latest
|
|
needs:
|
|
[
|
|
setup,
|
|
e2e_spin
|
|
]
|
|
if: always()
|
|
steps:
|
|
- id: destroy-runner
|
|
uses: volcengine/vemlp-github-runner@v1
|
|
with:
|
|
mode: "destroy"
|
|
faas-url: "${{ env.DYNAMIC_RUNNER_ENDPOINT }}"
|
|
mlp-task-id: "${{ needs.setup.outputs.mlp-task-id }}" |