mirror of
https://github.com/volcengine/verl.git
synced 2025-10-20 13:43:50 +08:00
11a43b6cad
### What does this PR do? Solve #3201 #### Problem The existing license check hook scans all directories recursively from a single root directory, which causes issues in local development environments: * Virtual environments (`.venv`, `venv/`) get scanned and fail license checks * No easy way to exclude common build/cache directories without hardcoding exclusions * Different behavior between local development (with venvs) and CI/CD (clean environment) #### Solution Modified the `check_license.py` script to accept multiple target directories instead of a single root directory with exclusions. ### Design & Code Changes Changed argument from `--directory` to `--directories` * Now accepts multiple `Path` arguments using `nargs="+"` * Allows specifying exactly which directories to scan * in local mode: `--directories examples recipe scripts tests verl setup.py` * in github workflow: `--directories .`
38 lines
1.0 KiB
YAML
38 lines
1.0 KiB
YAML
repos:
|
|
- repo: https://github.com/astral-sh/ruff-pre-commit
|
|
rev: "v0.12.2"
|
|
hooks:
|
|
- id: ruff
|
|
args: ["--fix", "--show-fixes", "--output-format=full"]
|
|
exclude: ^.*\.(ipynb)$
|
|
- id: ruff-format
|
|
|
|
- repo: https://github.com/pre-commit/mirrors-mypy
|
|
rev: 'v1.17.0'
|
|
hooks:
|
|
- id: mypy
|
|
|
|
- repo: local
|
|
hooks:
|
|
- id: autogen-trainer-cfg
|
|
name: Generate and verify verl/trainer/config/_generated_*.yaml
|
|
entry: scripts/generate_trainer_config.sh
|
|
language: script
|
|
pass_filenames: false
|
|
|
|
- repo: local
|
|
hooks:
|
|
- id: check-docstrings
|
|
name: Check doc string coverage
|
|
entry: python3 tests/special_sanity/check_docstrings.py
|
|
language: python
|
|
pass_filenames: false
|
|
|
|
- repo: local
|
|
hooks:
|
|
- id: check-license
|
|
name: Check license
|
|
entry: python3 tests/special_sanity/check_license.py --directories examples recipe scripts tests verl setup.py
|
|
language: python
|
|
pass_filenames: false
|