mirror of
https://github.com/volcengine/verl.git
synced 2025-10-20 13:43:50 +08:00
[single_controller, ray] fix: shut ray down after initializes it (#3317)
### What does this PR do? > Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review. To prevent Ascend NPU TBE errors caused by resource leakage, ensure that ray.shutdown()is explicitly called after initializing Ray with ray.init(). Address the first issue in https://github.com/volcengine/verl/issues/3316 ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) Co-authored-by: lantian7 <liuchun22@huawei.com>
This commit is contained in:
@ -46,19 +46,23 @@ def run_ppo(config) -> None:
|
||||
print(f"ray init kwargs: {ray_init_kwargs}")
|
||||
ray.init(**OmegaConf.to_container(ray_init_kwargs))
|
||||
|
||||
if (
|
||||
is_cuda_available
|
||||
and config.global_profiler.tool == "nsys"
|
||||
and OmegaConf.select(config.global_profiler, "steps") is not None
|
||||
and len(OmegaConf.select(config.global_profiler, "steps")) > 0
|
||||
):
|
||||
nsight_options = OmegaConf.to_container(
|
||||
config.global_profiler.global_tool_config.nsys.controller_nsight_options
|
||||
)
|
||||
runner = TaskRunner.options(runtime_env={"nsight": nsight_options}).remote()
|
||||
else:
|
||||
runner = TaskRunner.remote()
|
||||
ray.get(runner.run.remote(config))
|
||||
try:
|
||||
if (
|
||||
is_cuda_available
|
||||
and config.global_profiler.tool == "nsys"
|
||||
and OmegaConf.select(config.global_profiler, "steps") is not None
|
||||
and len(OmegaConf.select(config.global_profiler, "steps")) > 0
|
||||
):
|
||||
nsight_options = OmegaConf.to_container(
|
||||
config.global_profiler.global_tool_config.nsys.controller_nsight_options
|
||||
)
|
||||
runner = TaskRunner.options(runtime_env={"nsight": nsight_options}).remote()
|
||||
else:
|
||||
runner = TaskRunner.remote()
|
||||
ray.get(runner.run.remote(config))
|
||||
finally:
|
||||
if ray.is_initialized():
|
||||
ray.shutdown()
|
||||
|
||||
|
||||
@ray.remote(num_cpus=1) # please make sure main_task is not scheduled on head
|
||||
|
Reference in New Issue
Block a user