mirror of
https://github.com/volcengine/verl.git
synced 2025-10-20 21:53:50 +08:00
[megatron] fix: remove the demising critic.model.enable_gradient_checkpointing flags in the scripts (#2864)
### What does this PR do? They were removed in #2651, but #2691 overlooked some of them. ### Checklist Before Starting - [X] Search for similar PRs. Paste at least one query link here: ... - [X] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [X] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [X] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [X] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [X] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] (CI is not needed for this change) Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) Signed-off-by: Hollow Man <hollowman@opensuse.org>
This commit is contained in:
@ -23,7 +23,6 @@ python3 -m verl.trainer.main_ppo --config-path=./config --config-name='ppo_megat
|
||||
actor_rollout_ref.rollout.gpu_memory_utilization=0.4 \
|
||||
critic.optim.lr=1e-5 \
|
||||
critic.model.path=deepseek-ai/deepseek-llm-7b-chat \
|
||||
critic.model.enable_gradient_checkpointing=False \
|
||||
critic.ppo_micro_batch_size_per_gpu=4 \
|
||||
reward_model.enable=True \
|
||||
reward_model.megatron.tensor_model_parallel_size=4 \
|
||||
|
@ -54,7 +54,6 @@ python3 -m verl.trainer.main_ppo --config-path=./config --config-name='ppo_megat
|
||||
actor_rollout_ref.rollout.tensor_model_parallel_size=$VLLM_TP \
|
||||
critic.optim.lr=1e-5 \
|
||||
critic.model.path=$HF_MODEL_PATH \
|
||||
critic.model.enable_gradient_checkpointing=False \
|
||||
critic.ppo_micro_batch_size_per_gpu=4 \
|
||||
critic.megatron.tensor_model_parallel_size=$TP \
|
||||
critic.megatron.pipeline_model_parallel_size=$PP \
|
||||
|
Reference in New Issue
Block a user