frozenleaves/transformers
1
0
Fork 0
mirror of https://github.com/huggingface/transformers.git synced 2025-10-20 17:13:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

improve utils/check_bad_commit.py (#41658)

Browse Source 
* robust

* robust

* robust

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This commit is contained in:
Yih-Dar
2025-10-16 17:51:19 +02:00
committed by GitHub
parent a408384a88
commit 6344371a91
1 changed files with 13 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
utils/check_bad_commit.py
View File

@ -45,10 +45,10 @@ result = subprocess.run(
) )
print(result.stdout) print(result.stdout)
if f"PASSED {target_test}" in result.stdout: if f"FAILED {target_test}" in result.stdout:
print("test passed") print("test failed")
exit(0) exit(2)
elif len(result.stderr) > 0: elif result.returncode != 0:
if "ERROR: file or directory not found: " in result.stderr: if "ERROR: file or directory not found: " in result.stderr:
print("test file or directory not found in this commit") print("test file or directory not found in this commit")
exit(0) exit(0)
@ -56,12 +56,10 @@ elif len(result.stderr) > 0:
print("test not found in this commit") print("test not found in this commit")
exit(0) exit(0)
else: else:
print(f"pytest failed to run: {{result.stderr}}") print(f"pytest gets unknown error: {{result.stderr}}")
exit(-1) exit(-1)
elif f"FAILED {target_test}" in result.stdout:
print("test failed")
exit(2)
print(f"pytest runs successfully.")
exit(0) exit(0)
""" """
@ -103,22 +101,11 @@ git bisect run python3 target_script.py
) )
print(result.stdout) print(result.stdout)
# This happens if running the script gives exit code < 0 or other issues
if "error: bisect run failed" in result.stderr: if "error: bisect run failed" in result.stderr:
index = result.stderr.find("error: bisect run failed") error_msg = f"Error when running git bisect:\nbash error: {result.stderr}\nbash output:\n{result.stdout}\nset `bad_commit` to `None`."
bash_error = result.stderr[index:] print(error_msg)
return None
error_msg = f"Error when running git bisect:\nbash error: {bash_error}"
pattern = "pytest failed to run: .+"
pytest_errors = re.findall(pattern, result.stdout)
if len(pytest_errors) > 0:
pytest_error = pytest_errors[0]
index = pytest_error.find("pytest failed to run: ")
index += len("pytest failed to run: ")
pytest_error = pytest_error[index:]
error_msg += f"pytest error: {pytest_error}"
raise ValueError(error_msg)
pattern = r"(.+) is the first bad commit" pattern = r"(.+) is the first bad commit"
commits = re.findall(pattern, result.stdout) commits = re.findall(pattern, result.stdout)
@ -135,6 +122,9 @@ git bisect run python3 target_script.py
def get_commit_info(commit): def get_commit_info(commit):
"""Get information for a commit via `api.github.com`.""" """Get information for a commit via `api.github.com`."""
if commit is None:
return {"commit": None, "pr_number": None, "author": None, "merged_by": None}
pr_number = None pr_number = None
author = None author = None
merged_author = None merged_author = None