frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add more details about land checks

Zain Rizvi
2022-08-30 12:23:36 -05:00
parent 7d8480a543
commit d53a651771
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Bot-commands.md

@ -3,8 +3,21 @@ Page Maintainers: @seemethere, @janeyx99, @zengk95
Updated on: 8/8/22 Updated on: 8/8/22
Please report any buggy instances to @pytorch/pytorch-dev-infra asynchronously or join our [Office Hours](https://github.com/pytorch/pytorch/wiki/Dev-Infra-Office-Hours) to give in-person feedback or get in-person help! Please report any buggy instances to @pytorch/pytorch-dev-infra asynchronously or join our [Office Hours](https://github.com/pytorch/pytorch/wiki/Dev-Infra-Office-Hours) to give in-person feedback or get in-person help!
# Land Checks # Land Checks
We are currently rolling out land checks to all of the users in this [list](https://github.com/pytorch/test-infra/blob/main/torchci/lib/bot/rolloutUtils.ts). If you want to use the old behavior, you can use the `-g` which will wait for all checks to pass (which is usually just pull and lint workflows). If you believe there's some infra flakiness preventing you from landing, please use `-f` and supply a message. Additionally, you can add the accept2run label to your PR to run land check signals when your PR gets approved so that the land process doesn't take as long. You can also add accept2ship if you want to land your PR as soon as your PR gets approved. Land checks offer extra validation to your PR by rebasing a copy of your changes on top of the latest `viable/strict` branch and ensuring they still pass pull + trunk workflows.
Benefit: You get higher confidence that your PR won't have to be reverted after being merged into master!
Caveat: Slower merges: Once you run the merge command you'll still need to wait for the land checks branch to build and pass all checks
We are currently rolling out land checks to all of the users in this [list](https://github.com/pytorch/test-infra/blob/main/torchci/lib/bot/rolloutUtils.ts).
If you want to use the old behavior, you can use `@pytorchmergebot merge -g` which will wait for all checks on the PR to pass (which is usually just pull and lint workflows).
If you believe there's some infra flakiness preventing you from landing, please use `-f` and supply a message.
Additionally, you can add the accept2run label to your PR to run land check signals when your PR gets approved so that the land process doesn't take as long. You can also add accept2ship if you want to land your PR as soon as your PR gets approved.
If you have any feedback or complaints, please reach out to the Pytorch OSS CI team or visit our [Office Hours](https://github.com/pytorch/pytorch/wiki/Dev-Infra-Office-Hours). If you have any feedback or complaints, please reach out to the Pytorch OSS CI team or visit our [Office Hours](https://github.com/pytorch/pytorch/wiki/Dev-Infra-Office-Hours).