From d02d63c794ce41d6afa6275d7b4bf116044e86ec Mon Sep 17 00:00:00 2001 From: Jeff Daily Date: Wed, 19 Aug 2020 10:06:29 -0700 Subject: [PATCH] Updated Docker image build on CircleCI (markdown) --- Docker-image-build-on-CircleCI.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Docker-image-build-on-CircleCI.md b/Docker-image-build-on-CircleCI.md index 3c7a5fd..fcccc6b 100644 --- a/Docker-image-build-on-CircleCI.md +++ b/Docker-image-build-on-CircleCI.md @@ -70,9 +70,9 @@ pool.map(upload_to_ecr, builds) ``` ### How to add a new base docker image? -Note this instruction provides guidance to add a new **base** docker image. If you could reuse one of available docker images listed in https://github.com/pytorch/pytorch/blob/master/.circleci/docker/build.sh#L37, please do so and not adding new ones. +Note this instruction provides guidance to add a new **base** docker image. If you could reuse one of available docker images listed in https://github.com/pytorch/pytorch/blob/master/.circleci/docker/build.sh#L80, please do so and not adding new ones. -- Add an entry in https://github.com/pytorch/pytorch/blob/master/.circleci/docker/build.sh#L37 and make changes to Dockerfiles accordingly. +- Add an entry in https://github.com/pytorch/pytorch/blob/master/.circleci/docker/build.sh#L80 and make changes to Dockerfiles accordingly. - Test your image by building it locally. - Add a repo in AWS ECR to hold your image. It requires access to PyTorch's AWS account to do this step. - Trigger a new build process as described above.