From 9f501ea3e7e2e8e8f58981f85bc46d9352c64d78 Mon Sep 17 00:00:00 2001 From: "Edward Z. Yang" Date: Mon, 10 Jun 2019 09:42:02 -0400 Subject: [PATCH] Updated TH to ATen porting guide (markdown) --- TH-to-ATen-porting-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TH-to-ATen-porting-guide.md b/TH-to-ATen-porting-guide.md index f128878..1592bff 100644 --- a/TH-to-ATen-porting-guide.md +++ b/TH-to-ATen-porting-guide.md @@ -2,7 +2,7 @@ You're here because you are working on a task involving porting legacy TH code i ## Preliminaries -* **Check that the code is live.** Some functions in THNN are dead. An easy check is to make sure the function shows up in the documentation (temporal = 1d, spatial = 2d, volumetric = 3d). +* **Check that the code is live.** Some functions in THNN are dead. An easy check is to make sure the function shows up in the documentation (temporal = 1d, spatial = 2d, volumetric = 3d). A more thorough check is to stick a purposeful exception in the kernel in question, and then push your change to a PR to let CI run on it. If CI is all green even after you broke the code, it's a pretty strong indication it's dead. ## The general recipe