frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Created Pull request review etiquette (markdown)

Edward Z. Yang
2019-06-24 15:24:59 -04:00
parent c17a671122
commit 9ae540b95f
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Pull-request-review-etiquette.md Normal file

@ -0,0 +1 @@
If you **request changes** on a pull request, this will block the pull request from landing. Basic etiquette in the PyTorch repository is that if you request changes, once the author updates their pull request to address your comments, you should re-review the pull request within 24 hours (after all, they are blocked on you! Try to keep them unblocked.) If you can't commit to this SLA, feel free to leave comments, but don't request changes (so that the pull request author knows it is at their discretion whether or not to address your comments or not.)