frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 12:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity
Page: What is considered a SEV?
Pages
A quick guide on how to add and cache dependencies on PyTorch CI Adding and maintaining type annotations in PyTorch Autograd Basics Autograd Onboarding Lab Best Practices to Edit and Compile PyTorch Source Code On Windows Bot commands Boxing and Unboxing in the PyTorch Operator Library Build PyTorch and LibTorch on Windows ARM64 CUDA basics Code review values Codegen and Structured Kernels Continuous Integration Core Frontend Onboarding Cpp API Quick Walkthrough Data Basics DataPipes Testing Requirements Debugging CI Failures without SSH Access Debugging Windows with Remote Desktop or CDB (CLI windbg) on CircleCI Debugging using with ssh for Github Actions Dev Infra Office Hours Developer FAQ Dispatcher Structured Kernels Lab Docker image build on CircleCI Docstring Guidelines Getting help as a contributor Guide for adding type annotations to PyTorch Home How to propose feature changes to PyTorch How to support `torch.set_deterministic()` in PyTorch operators How to use TensorIterator Life of a Tensor MPS Backend Memory format propagation rules Modular components for benchmarking PyTorch snippets. (Experimental) Module Onboarding Lab Multiprocessing Technical Notes OpInfos FAQ Operators with Channels Last support Public API definition and documentation Pull request review etiquette PyTorch's Python Frontend Backward and Forward Compatibility Policy PyTorch AutoLabel Bot PyTorch Basics PyTorch CI Metrics Dashboards: the HUD PyTorch Data Flow and Interface Diagram PyTorch IR PyTorch ONNX Exporter Code Reviews and Duty Rotation PyTorch ONNX Topics PyTorch ONNX exporter PyTorch OSS benchmark infra PyTorch Ops to oneDNN Functions Mapping PyTorch Versions PyTorch Workflow Cheatsheet PyTorch dispatcher walkthrough Pytorch Training Loops Running and writing tests Sharing design documents for discussion Software Architecture for c10 TH to ATen porting guide Tensor and Operator Basics The PyTorch Contribution Process The Ultimate Guide to PyTorch Contributions The torch.fft module in PyTorch 1.7 Troubleshooting Documentation Build Troubleshooting Using hud.pytorch.org What is considered a SEV? Where or how should I add documentation Writing Python in cpp (a manifesto) Writing memory format aware operators Writing tests in PyTorch 1.8 clang format function transforms (aka torch.func, functorch) lintrunner nn Basics torch.nn Module Documentation Style Guide torch.onnx Namespacing vmap Basics vmap Onboarding Lab
Clone
1
What is considered a SEV?
Zain Rizvi edited this page 2023-05-10 14:32:30 -05:00
Unescape Escape
Table of Contents
This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

File a SEV

Why do we file SEVs?

  1. Alert devs that something is currently wrong with the CI and they may see failures that they’re not responsible for
  2. Track developer facing issues so that we can appropriately prioritize fixing (without SEVs these can get forgotten)

What’s considered a SEV?

When there is a widespread CI breakage that is not resolvable by doing a revert (e.g. it’s an issue with the underlying CI infra), you should file a SEV using the CI SEV issue template.

Rules of thumb

  • If it’s bad enough that people multiple people will ask us about it on any of our contributor communication channels
  • If it affects more than ~10% of users and might last over 30 minutes, it’s a SEV
  • If we’re expecting people to force push to work around it, it’s a SEV

If the above still leaves it ambiguous, we default to considering it a SEV.

If the sev is severe enough (generally defined as "the CI is likely to miss legitimate failures", the template includes instructions on how to make it merge blocking to prevent contributors from accidentally merging broken code.

During a SEV

HUD and the Dr. CI comment at the top of the PR will both explain that there's a SEV ongoing and link to the active sev.

If the SEV is marked as merge blocking, @pytorchbot will default to preventing PRs from being merged

I would love to contribute to PyTorch!