mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
6c1f1563e1
This PR fix the `UndefinedTensorImpl::_singleton` can't export on Windows issue. Snapshot: <img width="1346" alt="image" src="https://github.com/user-attachments/assets/b34256ac-a0ae-473b-89e6-10d755eaad24"> The reason is MSVC can't export class static data to external linkage, ref: https://learn.microsoft.com/en-us/cpp/cpp/using-dllimport-and-dllexport-in-cpp-classes?view=msvc-170#_pluslang_using_dllimport_and_dllexport_in_c2b2bselectivememberimportexport I use another singleton implenmentation to avoid the issue, for Windows. Since this PR, cpp_wrapper on Windows would start to work. <img width="1916" alt="image" src="https://github.com/user-attachments/assets/c1d7d7e7-64ca-4c6d-9fb7-e3b91e675b58"> Next step, I will enable the cpp_wrapper UTs. Pull Request resolved: https://github.com/pytorch/pytorch/pull/132326 Approved by: https://github.com/jgong5, https://github.com/desertfire
51 lines
1.5 KiB
C++
51 lines
1.5 KiB
C++
#include <c10/core/UndefinedTensorImpl.h>
|
|
#include <c10/util/Exception.h>
|
|
|
|
namespace c10 {
|
|
|
|
// should this use the globalContext? Can it get a context passed in somehow?
|
|
UndefinedTensorImpl::UndefinedTensorImpl()
|
|
: TensorImpl(DispatchKey::Undefined, caffe2::TypeMeta(), std::nullopt) {
|
|
set_storage_access_should_throw();
|
|
// TODO: accessing the sizes on an undefined tensor is not meaningful
|
|
// and should error too, but empirically it does not!
|
|
set_custom_sizes_strides(SizesStridesPolicy::CustomStrides);
|
|
}
|
|
|
|
bool UndefinedTensorImpl::is_contiguous_custom(MemoryFormat format) const {
|
|
return is_contiguous_default(format);
|
|
}
|
|
IntArrayRef UndefinedTensorImpl::strides_custom() const {
|
|
TORCH_CHECK(false, "strides() called on an undefined Tensor");
|
|
}
|
|
SymIntArrayRef UndefinedTensorImpl::sym_strides_custom() const {
|
|
TORCH_CHECK(false, "sym_strides() called on an undefined Tensor");
|
|
}
|
|
|
|
#ifdef DEBUG
|
|
bool UndefinedTensorImpl::has_storage() const {
|
|
TORCH_INTERNAL_ASSERT_DEBUG_ONLY(
|
|
!storage_, "UndefinedTensorImpl assumes that storage_ is never set");
|
|
return false;
|
|
}
|
|
#endif
|
|
|
|
void UndefinedTensorImpl::set_storage_offset(int64_t) {
|
|
TORCH_CHECK(false, "set_storage_offset() called on an undefined Tensor");
|
|
}
|
|
|
|
const char* UndefinedTensorImpl::tensorimpl_type_name() const {
|
|
return "UndefinedTensorImpl";
|
|
}
|
|
|
|
#ifdef _WIN32
|
|
UndefinedTensorImpl& UndefinedTensorImpl::getInstance() {
|
|
static UndefinedTensorImpl instance;
|
|
return instance;
|
|
}
|
|
#else
|
|
UndefinedTensorImpl UndefinedTensorImpl::_singleton;
|
|
#endif
|
|
|
|
} // namespace c10
|