Files
pytorch/torch/_inductor/compiler_bisector.py
Maggie Moss 9944cac6e6 Add suppressions to torch/_inductor (#165062)
Adds suppressions to pyrefly will typecheck clean: https://github.com/pytorch/pytorch/issues/163283

Split this directory into two PRs to keep them from being too large.

Test plan:
dmypy restart && python3 scripts/lintrunner.py -a
pyrefly check

step 1: delete lines in the pyrefly.toml file from the project-excludes field
step 2: run pyrefly check
step 3: add suppressions, clean up unused suppressions
before: https://gist.github.com/maggiemoss/4b3bf2037014e116bc00706a16aef199

after:
INFO 0 errors (6,884 ignored)

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165062
Approved by: https://github.com/oulgen, https://github.com/mlazos
2025-10-09 20:34:20 +00:00

634 lines
22 KiB
Python

import atexit
import collections
import dataclasses
import functools
import os
import shutil
import sys
import tempfile
from dataclasses import dataclass, field
from typing import Callable, Optional
from torch._inductor.runtime.cache_dir_utils import cache_dir
# Set the subdirectory name
SUBDIR_NAME = "bisect"
@dataclass
class Subsystem:
name: str
@dataclass
class BisectSubsystem(Subsystem):
pass
@dataclass
class BinarySubsystem(Subsystem):
pass
@dataclass
class ConfigChange(BinarySubsystem):
name: str = field(init=False)
config_name: str
config_field: str
config_value: object
def __post_init__(self) -> None:
self.name = f"{self.config_name}_{self.config_field}"
# Dictionary of backend -> subsystems
BACKENDS: dict[str, list[Subsystem]] = {
# run dynamo without aot_autograd
"eager": [],
# run dynamo with aot_autograd, but no partitioner or decomps
"aot_eager": [],
# run dynamo with aot autograd, decompositions and partitioner
"aot_eager_decomp_partition": [
ConfigChange("aot_eager_decomp_partition", "cse", False),
BisectSubsystem(
"decomposition"
), # number of decompositions we apply in tracing
], # TODO - add cse ?
# applies CrossRefFakeMode on invocation
"aot_eager_decomp_partition_crossref": [],
"inductor": [
BisectSubsystem("pre_grad_passes"), # passes applied on pre-grad IR
BisectSubsystem("joint_graph_passes"), # passes applied on joint graph
BisectSubsystem(
"post_grad_passes"
), # passes applied individually on forward, and backward in inductor
ConfigChange("inductor", "fallback_random", True),
ConfigChange("inductor", "emulate_precision_casts", True),
ConfigChange("inductor", "layout_optimization", False),
ConfigChange("inductor", "comprehensive_padding", False),
BisectSubsystem("lowerings"), # lowering aten operators to inductor
], # TODO - add more - fusions ?
}
subsystem_call_counter: dict[str, int] = collections.Counter()
call_counter_debug_info: dict[int, str] = {}
def reset_counters() -> None:
subsystem_call_counter.clear()
call_counter_debug_info.clear()
@functools.cache
def get_env_val(env_str: str) -> Optional[str]:
return os.environ.get(env_str, None)
@dataclasses.dataclass
class BisectionResult:
"""
backend: torch.compile backend responsible for failure
subsystem: optional, registered component identified for failure
bisect_number: optional, number of times the subsystem needed to be applied to trigger failure
debug_info: associated info of the triggering bisect application of subsystem
"""
backend: str
subsystem: Optional[str] = None
bisect_number: Optional[int] = None
debug_info: Optional[str] = None
class CompilerBisector:
"""
This class iteratively runs torch.compile backends (eager, aot_eager, inductor) to find the
first backend that can repro an issue.
Once it discovers the offending backend it will iteratively disable subsystems within the backend.
For subsystems which are applied repeatedly, such as the number of post grad passes or number
of lowering of nodes to inductor ir, it will bisect to find the offending application.
The idiomatic way to run it is with `do_bisect`. You can also use it by setting the env flags
`TORCH_BISECT_BACKEND`, `TORCH_BISECT_SUBSYSTEM` and `TORCH_BISECT_MAX`.
It also supports a CLI interface, although this is less well tested.
You must run python compiler_bisector.py [start | good | bad | end]
"""
bisection_enabled: bool = False
in_process_cache: Optional[str] = None
@classmethod
def get_dir(cls) -> str:
return f"{cache_dir() if not cls.in_process_cache else cls.in_process_cache}/{SUBDIR_NAME}"
@classmethod
def write_lines_to_file(cls, file_path: str, lines: list[str]) -> None:
os.makedirs(os.path.dirname(file_path), exist_ok=True)
with open(file_path, "w") as file:
file.writelines(lines)
@classmethod
def read_lines_from_file(cls, file_path: str) -> list[str]:
if os.path.exists(file_path):
with open(file_path) as file:
return file.readlines()
return []
@classmethod
def update_run_state(
cls, backend_name: str, subsystem: Subsystem, run_state: str
) -> None:
file_path = os.path.join(
cls.get_dir(), backend_name, f"{subsystem.name}_run_state.txt"
)
if isinstance(subsystem, ConfigChange):
assert run_state == "test_disable"
cls.set_config_values(
backend_name,
subsystem.name,
{subsystem.config_field: subsystem.config_value},
)
cls.write_lines_to_file(file_path, [run_state])
@classmethod
def set_config_values(
cls, backend: str, subsystem: str, config_data: dict[str, object]
) -> None:
file_path = os.path.join(cls.get_dir(), backend, f"{subsystem}_config.txt")
lines = [f"{k}={v}\n" for k, v in config_data.items()]
cls.write_lines_to_file(file_path, lines)
@classmethod
def update_bisect_status(cls, backend_name: str, subsystem_name: str) -> None:
assert isinstance(subsystem_name, str)
file_path = os.path.join(cls.get_dir(), "bisect_status.txt")
lines = [f"backend={backend_name}\n", f"subsystem={subsystem_name}\n"]
cls.write_lines_to_file(file_path, lines)
@classmethod
def update_bisect_range(
cls, backend_name: str, subsystem_name: str, low: int, high: int
) -> None:
assert isinstance(subsystem_name, str)
file_path = os.path.join(
cls.get_dir(), backend_name, f"{subsystem_name}_bisect_range.txt"
)
lines = [f"low={low}\n", f"high={high}\n"]
cls.write_lines_to_file(file_path, lines)
@classmethod
def get_backend(cls) -> Optional[str]:
"""
Returns the active backend, if any
"""
if val := get_env_val("TORCH_BISECT_BACKEND"):
return val
file_path = os.path.join(cls.get_dir(), "bisect_status.txt")
lines = cls.read_lines_from_file(file_path)
for line in lines:
if line.startswith("backend="):
return line.strip().split("=")[1]
return None
@classmethod
def get_subsystem(cls) -> Optional[str]:
"""
Returns the active subsystem, if any
"""
if val := get_env_val("TORCH_BISECT_SUBSYSTEM"):
return val
file_path = os.path.join(cls.get_dir(), "bisect_status.txt")
lines = cls.read_lines_from_file(file_path)
for line in lines:
if line.startswith("subsystem="):
out = line.strip().split("=")[1]
return out if out else None
return None
@classmethod
def get_subsystem_object(cls, backend_name: str, subsystem_name: str) -> Subsystem:
return next(obj for obj in BACKENDS[backend_name] if obj.name == subsystem_name)
@classmethod
def get_run_state(cls, backend_name: str, subsystem_name: str) -> Optional[str]:
"""
Returns the current stage of bisecting, if Any
"""
file_path = os.path.join(
cls.get_dir(), backend_name, f"{subsystem_name}_run_state.txt"
)
lines = cls.read_lines_from_file(file_path)
if lines:
out = lines[0].strip()
assert out in ("test_disable", "find_max_bounds", "bisect")
return out
return None
@classmethod
def get_bisect_range(
cls, backend_name: str, subsystem_name: str
) -> tuple[int, int]:
file_path = os.path.join(
cls.get_dir(), backend_name, f"{subsystem_name}_bisect_range.txt"
)
lines = cls.read_lines_from_file(file_path)
low = None
high = None
# pyrefly: ignore # bad-assignment
for line in reversed(lines):
if line.startswith("low="):
low = int(line.strip().split("=")[1])
elif line.startswith("high="):
high = int(line.strip().split("=")[1])
if low is not None and high is not None:
break
if low is None or high is None:
raise RuntimeError(
f"Trying to get bisect range when it is not set: subsystem {subsystem_name}"
)
return low, high
@classmethod
def update_config_change(cls, backend: str, subsystem: ConfigChange) -> None:
file_path = os.path.join(cls.get_dir(), backend, f"{subsystem.name}_config.txt")
lines = [
f"config_name={subsystem.config_name}\n",
f"config_field={subsystem.config_field}\n",
f"config_value={subsystem.config_value}\n",
]
cls.write_lines_to_file(file_path, lines)
@classmethod
def get_config_change(cls, config_name: str) -> Optional[dict[str, object]]:
backend = cls.get_backend()
subsystem = cls.get_subsystem()
if not backend or not subsystem:
return None
file_path = os.path.join(cls.get_dir(), backend, f"{subsystem}_config.txt")
if not os.path.exists(file_path):
return None
lines = cls.read_lines_from_file(file_path)
config_data = {}
for line in lines:
key, value = line.strip().split("=", 1)
config_data[key] = eval(value)
return config_data
@classmethod
def delete_bisect_status(cls) -> None:
# in process_cache we have created if it exists, just the subdirectory of non created dir
dir_name = cls.in_process_cache if cls.in_process_cache else cls.get_dir()
if os.path.exists(dir_name):
shutil.rmtree(dir_name)
print("Bisection status deleted.")
else:
print("No bisection status found.")
@classmethod
def get_system_counter(cls, name: str, increment: bool = True) -> int:
global subsystem_call_counter
curr = subsystem_call_counter[name]
if increment:
subsystem_call_counter[name] += 1
return curr
@classmethod
def disable_subsystem(
cls,
backend: str,
subsystem: str,
debug_info: Optional[Callable[[], str]] = None,
) -> bool:
if not cls.bisection_enabled:
return False
if cls.get_backend() != backend:
return False
if cls.get_subsystem() != subsystem:
return False
if val := get_env_val("TORCH_BISECT_MAX"):
counter = cls.get_system_counter(subsystem, increment=True)
return counter > int(val)
run_state = cls.get_run_state(backend, subsystem)
if run_state == "test_disable":
# First run, disable completely
return True
elif run_state == "find_max_bounds":
# Second run, update bisection range and return True to enable the subsystem
cls.update_bisect_range(
backend,
subsystem,
0,
cls.get_system_counter(subsystem, increment=True),
)
return False
else:
assert run_state == "bisect"
# If the environment variable is not set, use the bisection range midpoint
low, high = cls.get_bisect_range(backend, subsystem)
# if high - low <= 2:
midpoint = (low + high) // 2
call_counter = cls.get_system_counter(subsystem)
if (
call_counter >= low
and call_counter <= high
and (low - high) <= 2
and debug_info is not None
):
call_counter_debug_info[call_counter] = debug_info()
return call_counter > midpoint
@classmethod
def advance_subsystem(
cls, curr_backend: str, curr_subsystem: Subsystem
) -> Optional[Subsystem]:
"""
Tries to move to the next subsystem within the current system.
"""
print(f"Disabling {curr_subsystem.name} did not fix the issue.")
current_subsystems = BACKENDS[curr_backend]
current_subsystem_index = next(
i
for i, subsystem in enumerate(current_subsystems)
if subsystem.name == curr_subsystem.name
)
if current_subsystem_index < len(current_subsystems) - 1:
next_subsystem = current_subsystems[current_subsystem_index + 1]
cls.update_bisect_status(curr_backend, next_subsystem.name)
cls.update_run_state(curr_backend, next_subsystem, "test_disable")
print(
f"Moving to the next subsystem: {curr_backend} - {next_subsystem.name}"
)
return next_subsystem
else:
print(
f"All subsystems in {curr_backend} have been checked. The issue is not in this system."
)
return None
@classmethod
def advance_backend(cls, curr_backend: str) -> Optional[str]:
"""
Tries Move to the next backend.
"""
current_system_index = list(BACKENDS.keys()).index(curr_backend)
if current_system_index < len(BACKENDS) - 1:
curr_backend = list(BACKENDS.keys())[current_system_index + 1]
cls.update_bisect_status(curr_backend, "")
print(f"Moving to the next system: {curr_backend}")
return curr_backend
else:
return None
@classmethod
def process_subsystem(
cls,
curr_backend: str,
curr_subsystem: Subsystem,
fn: Callable[[], bool],
cli_interface: bool = True,
) -> bool:
"""
Process the current subsystem. Returns True if the issue is found, False otherwise.
"""
assert isinstance(curr_subsystem, Subsystem)
while True:
run_state = cls.get_run_state(curr_backend, curr_subsystem.name)
reset_counters()
if run_state == "test_disable":
if not fn():
next_subsystem = cls.advance_subsystem(curr_backend, curr_subsystem)
if not next_subsystem:
return False
curr_subsystem = next_subsystem
else:
if isinstance(curr_subsystem, ConfigChange):
print(
f"Setting config {curr_subsystem.config_name} field {curr_subsystem.config_field} "
f"to {curr_subsystem.config_value} fixed the issue"
)
else:
print(f"Disabling {curr_subsystem.name} fixed the issue.")
if isinstance(curr_subsystem, BinarySubsystem):
return True
print("Starting bisect by getting upper bound.")
cls.update_run_state(
curr_backend, curr_subsystem, "find_max_bounds"
)
elif run_state == "find_max_bounds":
if fn():
raise RuntimeError(
f"Function succeeded with 'find_max_bounds' status for {curr_backend} - {curr_subsystem.name}."
)
else:
_, high = cls.get_bisect_range(curr_backend, curr_subsystem.name)
print(f"Upper bound of {high} found for {curr_backend}.")
cls.update_run_state(curr_backend, curr_subsystem, "bisect")
elif run_state == "bisect":
low, high = cls.get_bisect_range(curr_backend, curr_subsystem.name)
midpoint = (low + high) // 2
print(
f"Bisecting {curr_backend} - {curr_subsystem.name} (Range: [{low}, {high}], Midpoint: {midpoint})"
)
if fn():
cls.update_bisect_range(
curr_backend, curr_subsystem.name, midpoint + 1, high
)
else:
cls.update_bisect_range(
curr_backend, curr_subsystem.name, low, midpoint
)
low, high = cls.get_bisect_range(curr_backend, curr_subsystem.name)
if low == high:
print(
f"Binary search completed for {curr_backend} - {curr_subsystem.name}. The bisect number is {low}. "
f"Debug info: {call_counter_debug_info.get(low, 'not found')}"
)
return True
else:
raise RuntimeError(f"Unexpected run_state {run_state}")
if cli_interface:
sys.exit(0)
@classmethod
def initialize_system(cls) -> None:
curr_backend = next(iter(BACKENDS.keys()))
curr_subsystem = ""
cls.update_bisect_status(curr_backend, curr_subsystem)
print(f"Starting bisection process with system: {curr_backend}")
@classmethod
def do_bisect(
cls, fn: Callable[[], bool], cli_interface: bool = False
) -> Optional[BisectionResult]:
"""
Run fn repeatedly attempting to bisect torch.compile. fn should return True on success and False on failure.
"""
if not cli_interface:
bisection_enabled_orig = cls.bisection_enabled
cls.delete_bisect_status()
cls.bisection_enabled = True
cls.in_process_cache = tempfile.mkdtemp()
def cleanup() -> None:
cls.bisection_enabled = bisection_enabled_orig
cls.delete_bisect_status()
cls.in_process_cache = None
cleanup_handler = atexit.register(cleanup)
class DisableBisect:
def __del__(self) -> None:
cleanup()
atexit.unregister(cleanup_handler)
_cleanup = DisableBisect()
curr_backend = cls.get_backend()
curr_subsystem_name = cls.get_subsystem()
if not curr_backend:
cls.initialize_system()
curr_backend = cls.get_backend()
assert curr_backend is not None
curr_subsystem_name = cls.get_subsystem()
curr_subsystem = (
cls.get_subsystem_object(curr_backend, curr_subsystem_name)
if curr_subsystem_name is not None
else None
)
while True:
assert curr_backend is not None
reset_counters()
if curr_subsystem:
result = cls.process_subsystem(
curr_backend, curr_subsystem, fn, cli_interface=cli_interface
)
if result:
curr_subsystem = cls.get_subsystem_object(
curr_backend,
cls.get_subsystem(), # type: ignore[arg-type]
)
if isinstance(curr_subsystem, BinarySubsystem):
return BisectionResult(
curr_backend,
curr_subsystem.name,
0,
curr_subsystem.name,
)
low, _ = cls.get_bisect_range(curr_backend, curr_subsystem.name)
return BisectionResult(
curr_backend,
curr_subsystem.name,
low,
call_counter_debug_info.get(low),
)
next_subsystem = cls.advance_subsystem(curr_backend, curr_subsystem)
if not next_subsystem:
print(
f"The issue is in the {curr_backend} system, but could not identify subsystem."
)
assert curr_backend is not None
return BisectionResult(curr_backend)
curr_subsystem = next_subsystem
else:
if fn():
next_backend = cls.advance_backend(curr_backend)
if not next_backend:
print("All systems have been checked.")
return None
curr_backend = next_backend
else:
current_subsystems = BACKENDS[curr_backend]
if current_subsystems:
curr_subsystem = current_subsystems[0]
cls.update_bisect_status(curr_backend, curr_subsystem.name)
cls.update_run_state(
curr_backend, curr_subsystem, "test_disable"
)
print(
f"The issue is in the {curr_backend} system. Moving to the first subsystem: {curr_subsystem}"
)
else:
print(f"The issue is in the {curr_backend} system.")
return BisectionResult(curr_backend)
if cli_interface:
sys.exit(0)
def command_line_usage() -> None:
if len(sys.argv) < 2:
print("Usage: python bisect_update.py <start|end|good|bad>")
sys.exit(1)
bisection_manager = CompilerBisector()
command = sys.argv[1]
if command == "end":
bisection_manager.delete_bisect_status()
sys.exit(0)
if command == "start":
bisection_manager.delete_bisect_status()
bisection_manager.initialize_system()
sys.exit(0)
if command not in ["good", "bad"]:
print("Invalid command. Must be 'good', 'bad', 'start', or 'end'.")
sys.exit(1)
def test_function() -> bool:
return command == "good"
if not bisection_manager.get_backend():
raise ValueError("Must call start prior to good or bad")
bisection_manager.do_bisect(test_function, cli_interface=True)
def get_is_bisection_enabled() -> bool:
return (
CompilerBisector.get_subsystem() is not None
or CompilerBisector.get_backend() is not None
)
CompilerBisector.bisection_enabled = get_is_bisection_enabled()
if __name__ == "__main__":
command_line_usage()