mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
Preferring dash over underscore in command-line options. Add `--command-arg-name` to the argument parser. The old arguments with underscores `--command_arg_name` are kept for backward compatibility.
Both dashes and underscores are used in the PyTorch codebase. Some argument parsers only have dashes or only have underscores in arguments. For example, the `torchrun` utility for distributed training only accepts underscore arguments (e.g., `--master_port`). The dashes are more common in other command-line tools. And it looks to be the default choice in the Python standard library:
`argparse.BooleanOptionalAction`: 4a9dff0e5a/Lib/argparse.py (L893-L895)
```python
class BooleanOptionalAction(Action):
def __init__(...):
if option_string.startswith('--'):
option_string = '--no-' + option_string[2:]
_option_strings.append(option_string)
```
It adds `--no-argname`, not `--no_argname`. Also typing `_` need to press the shift or the caps-lock key than `-`.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/94505
Approved by: https://github.com/ezyang, https://github.com/seemethere
25 lines
703 B
Python
25 lines
703 B
Python
import argparse
|
|
import os
|
|
import os.path
|
|
|
|
|
|
if __name__ == "__main__":
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument("--input-file")
|
|
parser.add_argument("--output-file")
|
|
parser.add_argument("--install-dir", "--install_dir")
|
|
parser.add_argument("--replace", action="append", nargs=2)
|
|
options = parser.parse_args()
|
|
|
|
with open(options.input_file, "r") as f:
|
|
contents = f.read()
|
|
|
|
output_file = os.path.join(options.install_dir, options.output_file)
|
|
os.makedirs(os.path.dirname(output_file), exist_ok=True)
|
|
|
|
for old, new in options.replace:
|
|
contents = contents.replace(old, new)
|
|
|
|
with open(output_file, "w") as f:
|
|
f.write(contents)
|