Nikita Shulga a229e78544 [BE] Enforce sign-compare (#96723) ...

Number of OSS PR were reverted, because new signed-unsigned comparison warnings, which are treated as errors in some internal builds.
Not sure how those selective rules are applied, but this PR removes `-Wno-sign-compare` from PyTorch codebase.

The only tricky part in this PR, as making sure that non-ASCII character detection works for both signed and unsigned chars  here:
6e3d51b08a/torch/csrc/jit/serialization/python_print.cpp (L926)

Exclude several files from sign-compare if flash attention is used, due to the violation in cutlass, to be fixed by https://github.com/NVIDIA/cutlass/pull/869
Do not try to fix sign compare violations in caffe2 codebase
Pull Request resolved: https://github.com/pytorch/pytorch/pull/96723
Approved by: https://github.com/albanD

2023-03-15 06:04:20 +00:00

..

External

Set make max load when building libtorch (#89237)

2022-11-18 18:55:33 +00:00

Modules

Improve ASAN and TSAN handling in cmake (#93147)

2023-03-07 14:10:13 +00:00

Modules_CUDA_fix

[BE] Remove fast_nvcc tool (#96665)

2023-03-14 03:17:31 +00:00

public

[BE] Enforce sign-compare (#96723)

2023-03-15 06:04:20 +00:00

Allowlist.cmake

Replace whitelist with allowlist (#42067)

2020-07-28 08:01:16 -07:00

BuildVariables.cmake

Remove Caffe2_MAIN_LIBS (#38408)

2020-05-15 12:27:15 -07:00

Caffe2Config.cmake.in

Use FindCUDAToolkit to find cuda dependencies (#82695)

2023-03-01 17:26:36 +00:00

Caffe2ConfigVersion.cmake.in

Forbid trailing whitespace (#53406)

2021-03-05 17:22:55 -08:00

CheckAbi.cmake

remove abi uncertainty and potential abi conflict (#94306)

2023-02-09 09:54:04 +00:00

cmake_uninstall.cmake.in

Formatting cmake (to lowercase without space for if/elseif/else/endif) (#35521)

2020-03-27 14:25:17 -07:00

Codegen.cmake

[retake2][mobile] Fix lightweight dispatch OOM error by introducing selective build (#80791)

2022-07-15 18:04:25 +00:00

DebugHelper.cmake

Add debug helper function to check target property (#52093)

2021-02-11 15:37:14 -08:00

Dependencies.cmake

Improve ASAN and TSAN handling in cmake (#93147)

2023-03-07 14:10:13 +00:00

FlatBuffers.cmake

[pytorch][PR] Add ability for a mobile::Module to save as flatbuffer (#70201)

2022-01-12 16:30:39 -08:00

GoogleTestPatch.cmake

Simplify cmake code (#91546)

2023-02-08 01:05:19 +00:00

IncludeSource.cpp.in

CMake: Include instead of copying cpu kernel files (#67656)

2021-11-30 19:13:53 -08:00

iOS.cmake

Forbid trailing whitespace (#53406)

2021-03-05 17:22:55 -08:00

Metal.cmake

[CI] Compile on M1 natively (#95719)

2023-03-01 04:20:42 +00:00

MiscCheck.cmake

Improve ASAN and TSAN handling in cmake (#93147)

2023-03-07 14:10:13 +00:00

ProtoBuf.cmake

Update protobuf to 3.13.1 (#62571)

2021-08-19 23:43:55 -07:00

ProtoBufPatch.cmake

Migrate PyTorch to C++17 (#85969)

2022-12-08 02:27:48 +00:00

Summary.cmake

Use FindCUDAToolkit to find cuda dependencies (#82695)

2023-03-01 17:26:36 +00:00

TorchConfig.cmake.in

Some CMake and CUDA cleanup given recent update to C++17 (#90599)

2022-12-30 11:19:26 +00:00

TorchConfigVersion.cmake.in

Formatting cmake (to lowercase without space for if/elseif/else/endif) (#35521)

2020-03-27 14:25:17 -07:00

VulkanCodegen.cmake

[Vulkan] Remove GLSL Code Gen (#91912)

2023-01-10 20:29:47 +00:00

VulkanDependencies.cmake

[Vulkan] Remove GLSL Code Gen (#91912)

2023-01-10 20:29:47 +00:00