Files
pytorch/torch
davidriazati c267d0c869 Misc error message improvements (#19369)
Summary:
Stack from [ghstack](https://github.com/ezyang/ghstack):
* **#19369 [jit] Misc error message improvements**
)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/19369

Pulled By: driazati

Differential Revision: D14982975

fbshipit-source-id: 18dae3d56c3a01280f66223a69e2e52d15d3b651
2019-05-17 15:30:58 -07:00
..
2019-05-13 11:24:22 -07:00
2018-09-20 14:00:54 -07:00
2019-05-17 08:57:22 -07:00
2019-04-02 16:17:05 -07:00
2019-04-03 14:14:18 -07:00
2019-04-17 21:04:33 -07:00
2019-04-01 16:03:58 -07:00
2019-03-26 07:53:07 -07:00
2018-04-28 07:45:02 -04:00

Note [TH abstraction violation]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

TH/THC provide some hpp headers, which are proper C++ headers rather than
C headers.  These headers serve double duty as *internal implementation
detail* headers, whose contents should largely not be used by external
clients.

Ideally, we would not install these headers at all; instead, you should
use public functions (in headers like `THTensor.h`, NOT `THTensor.hpp`)
to manipulate these structs.  However, there are a few places
in torch/csrc where we violate this abstraction.  They are marked with
a pointer to this note.  Each of those sites will have to be refactored
when we refactor the guts of THTensor and related structures.