mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
Applies so more fixes to headers that may have been missed before for performance optimization.cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @EikanWang @ezyang since this more in the series of the clang-tidy fixup This is PR fixes 3 main issues: 1. Use emplacement more in headers 1. Avoid unnecessary copies and use const ref when possible 1. Default any special functions when possible to make them potentially trivial and more readable. 1. There is also one change in this PR that tries to prevent unnecessary math promotion, the rest of these changes are in another PR Pull Request resolved: https://github.com/pytorch/pytorch/pull/91445 Approved by: https://github.com/ezyang
232 lines
6.7 KiB
C++
232 lines
6.7 KiB
C++
// This file defines OptionalArrayRef<T>, a class that has almost the same
|
|
// exact functionality as c10::optional<ArrayRef<T>>, except that its
|
|
// converting constructor fixes a dangling pointer issue.
|
|
//
|
|
// The implicit converting constructor of both c10::optional<ArrayRef<T>> and
|
|
// std::optional<ArrayRef<T>> can cause the underlying ArrayRef<T> to store
|
|
// a dangling pointer. OptionalArrayRef<T> prevents this by wrapping
|
|
// a c10::optional<ArrayRef<T>> and fixing the constructor implementation.
|
|
//
|
|
// See https://github.com/pytorch/pytorch/issues/63645 for more on this.
|
|
|
|
#pragma once
|
|
|
|
#include <c10/util/ArrayRef.h>
|
|
#include <c10/util/Optional.h>
|
|
|
|
namespace c10 {
|
|
|
|
template <typename T>
|
|
class OptionalArrayRef final {
|
|
public:
|
|
// Constructors
|
|
|
|
constexpr OptionalArrayRef() noexcept = default;
|
|
|
|
constexpr OptionalArrayRef(nullopt_t) noexcept {}
|
|
|
|
OptionalArrayRef(const OptionalArrayRef& other) = default;
|
|
|
|
OptionalArrayRef(OptionalArrayRef&& other) = default;
|
|
|
|
constexpr OptionalArrayRef(const optional<ArrayRef<T>>& other) noexcept
|
|
: wrapped_opt_array_ref(other) {}
|
|
|
|
constexpr OptionalArrayRef(optional<ArrayRef<T>>&& other) noexcept
|
|
: wrapped_opt_array_ref(other) {}
|
|
|
|
constexpr OptionalArrayRef(const T& value) noexcept
|
|
: wrapped_opt_array_ref(value) {}
|
|
|
|
template <
|
|
typename U = ArrayRef<T>,
|
|
std::enable_if_t<
|
|
!std::is_same<std::decay_t<U>, OptionalArrayRef>::value &&
|
|
!std::is_same<std::decay_t<U>, in_place_t>::value &&
|
|
std::is_constructible<ArrayRef<T>, U&&>::value &&
|
|
std::is_convertible<U&&, ArrayRef<T>>::value &&
|
|
!std::is_convertible<U&&, T>::value,
|
|
bool> = false>
|
|
constexpr OptionalArrayRef(U&& value) noexcept(
|
|
std::is_nothrow_constructible<ArrayRef<T>, U&&>::value)
|
|
: wrapped_opt_array_ref(value) {}
|
|
|
|
template <
|
|
typename U = ArrayRef<T>,
|
|
std::enable_if_t<
|
|
!std::is_same<std::decay_t<U>, OptionalArrayRef>::value &&
|
|
!std::is_same<std::decay_t<U>, in_place_t>::value &&
|
|
std::is_constructible<ArrayRef<T>, U&&>::value &&
|
|
!std::is_convertible<U&&, ArrayRef<T>>::value,
|
|
bool> = false>
|
|
constexpr explicit OptionalArrayRef(U&& value) noexcept(
|
|
std::is_nothrow_constructible<ArrayRef<T>, U&&>::value)
|
|
: wrapped_opt_array_ref(value) {}
|
|
|
|
template <typename... Args>
|
|
constexpr explicit OptionalArrayRef(in_place_t ip, Args&&... args) noexcept
|
|
: wrapped_opt_array_ref(ip, args...) {}
|
|
|
|
template <typename U, typename... Args>
|
|
constexpr explicit OptionalArrayRef(
|
|
in_place_t ip,
|
|
std::initializer_list<U> il,
|
|
Args&&... args)
|
|
: wrapped_opt_array_ref(ip, il, args...) {}
|
|
|
|
constexpr OptionalArrayRef(const std::initializer_list<T>& Vec)
|
|
: wrapped_opt_array_ref(ArrayRef<T>(Vec)) {}
|
|
|
|
// Destructor
|
|
|
|
~OptionalArrayRef() = default;
|
|
|
|
// Assignment
|
|
|
|
constexpr OptionalArrayRef& operator=(nullopt_t) noexcept {
|
|
wrapped_opt_array_ref = c10::nullopt;
|
|
return *this;
|
|
}
|
|
|
|
OptionalArrayRef& operator=(const OptionalArrayRef& other) = default;
|
|
|
|
OptionalArrayRef& operator=(OptionalArrayRef&& other) = default;
|
|
|
|
constexpr OptionalArrayRef& operator=(
|
|
const optional<ArrayRef<T>>& other) noexcept {
|
|
wrapped_opt_array_ref = other;
|
|
return *this;
|
|
}
|
|
|
|
constexpr OptionalArrayRef& operator=(
|
|
optional<ArrayRef<T>>&& other) noexcept {
|
|
wrapped_opt_array_ref = other;
|
|
return *this;
|
|
}
|
|
|
|
template <typename U = ArrayRef<T>>
|
|
constexpr std::enable_if_t<
|
|
!std::is_same<std::decay_t<U>, OptionalArrayRef>::value &&
|
|
std::is_constructible<ArrayRef<T>, U&&>::value &&
|
|
std::is_assignable<ArrayRef<T>&, U&&>::value,
|
|
OptionalArrayRef&>
|
|
operator=(U&& value) noexcept(
|
|
std::is_nothrow_constructible<ArrayRef<T>, U&&>::value&&
|
|
std::is_nothrow_assignable<ArrayRef<T>&, U&&>::value) {
|
|
wrapped_opt_array_ref = value;
|
|
return *this;
|
|
}
|
|
|
|
// Observers
|
|
|
|
constexpr ArrayRef<T>* operator->() noexcept {
|
|
return &wrapped_opt_array_ref.value();
|
|
}
|
|
|
|
constexpr const ArrayRef<T>* operator->() const noexcept {
|
|
return &wrapped_opt_array_ref.value();
|
|
}
|
|
|
|
constexpr ArrayRef<T>& operator*() & noexcept {
|
|
return wrapped_opt_array_ref.value();
|
|
}
|
|
|
|
constexpr const ArrayRef<T>& operator*() const& noexcept {
|
|
return wrapped_opt_array_ref.value();
|
|
}
|
|
|
|
constexpr ArrayRef<T>&& operator*() && noexcept {
|
|
return std::move(wrapped_opt_array_ref.value());
|
|
}
|
|
|
|
constexpr const ArrayRef<T>&& operator*() const&& noexcept {
|
|
return std::move(wrapped_opt_array_ref.value());
|
|
}
|
|
|
|
constexpr explicit operator bool() const noexcept {
|
|
return wrapped_opt_array_ref.has_value();
|
|
}
|
|
|
|
constexpr bool has_value() const noexcept {
|
|
return wrapped_opt_array_ref.has_value();
|
|
}
|
|
|
|
constexpr ArrayRef<T>& value() & {
|
|
return wrapped_opt_array_ref.value();
|
|
}
|
|
|
|
constexpr const ArrayRef<T>& value() const& {
|
|
return wrapped_opt_array_ref.value();
|
|
}
|
|
|
|
constexpr ArrayRef<T>&& value() && {
|
|
return std::move(wrapped_opt_array_ref.value());
|
|
}
|
|
|
|
constexpr const ArrayRef<T>&& value() const&& {
|
|
return std::move(wrapped_opt_array_ref.value());
|
|
}
|
|
|
|
template <typename U>
|
|
constexpr std::
|
|
enable_if_t<std::is_convertible<U&&, ArrayRef<T>>::value, ArrayRef<T>>
|
|
value_or(U&& default_value) const& {
|
|
return wrapped_opt_array_ref.value_or(default_value);
|
|
}
|
|
|
|
template <typename U>
|
|
constexpr std::
|
|
enable_if_t<std::is_convertible<U&&, ArrayRef<T>>::value, ArrayRef<T>>
|
|
value_or(U&& default_value) && {
|
|
return wrapped_opt_array_ref.value_or(default_value);
|
|
}
|
|
|
|
// Modifiers
|
|
|
|
constexpr void swap(OptionalArrayRef& other) noexcept {
|
|
std::swap(wrapped_opt_array_ref, other.wrapped_opt_array_ref);
|
|
}
|
|
|
|
constexpr void reset() noexcept {
|
|
wrapped_opt_array_ref.reset();
|
|
}
|
|
|
|
template <typename... Args>
|
|
constexpr std::enable_if_t<
|
|
std::is_constructible<ArrayRef<T>, Args&&...>::value,
|
|
ArrayRef<T>&>
|
|
emplace(Args&&... args) noexcept(
|
|
std::is_nothrow_constructible<ArrayRef<T>, Args&&...>::value) {
|
|
return wrapped_opt_array_ref.emplace(args...);
|
|
}
|
|
|
|
template <typename U, typename... Args>
|
|
constexpr ArrayRef<T>& emplace(
|
|
std::initializer_list<U> il,
|
|
Args&&... args) noexcept {
|
|
return wrapped_opt_array_ref.emplace(il, args...);
|
|
}
|
|
|
|
private:
|
|
optional<ArrayRef<T>> wrapped_opt_array_ref;
|
|
};
|
|
|
|
using OptionalIntArrayRef = OptionalArrayRef<int64_t>;
|
|
|
|
inline bool operator==(
|
|
const OptionalIntArrayRef& a1,
|
|
const IntArrayRef& other) {
|
|
if (!a1.has_value()) {
|
|
return false;
|
|
}
|
|
return a1.value() == other;
|
|
}
|
|
|
|
inline bool operator==(
|
|
const c10::IntArrayRef& a1,
|
|
const c10::OptionalIntArrayRef& a2) {
|
|
return a2 == a1;
|
|
}
|
|
|
|
} // namespace c10
|