mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
a78eb243ad
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/74962 This would eliminate the need for build system changes when new .pyi.in files is added Test Plan: CI Reviewed By: seemethere Differential Revision: D35255502 fbshipit-source-id: 9aa84d2fc0f7933293cac4c6588da72a9d649df0 (cherry picked from commit 4931ec5411362692427adca348f409ce4d2a01fc)
Note [TH abstraction violation] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ TH/THC provide some hpp headers, which are proper C++ headers rather than C headers. These headers serve double duty as *internal implementation detail* headers, whose contents should largely not be used by external clients. Ideally, we would not install these headers at all; instead, you should use public functions (in headers like `THTensor.h`, NOT `THTensor.hpp`) to manipulate these structs. However, there are a few places in torch/csrc where we violate this abstraction. They are marked with a pointer to this note. Each of those sites will have to be refactored when we refactor the guts of THTensor and related structures.