mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
a229b4526f
Preferring dash over underscore in command-line options. Add `--command-arg-name` to the argument parser. The old arguments with underscores `--command_arg_name` are kept for backward compatibility.
Both dashes and underscores are used in the PyTorch codebase. Some argument parsers only have dashes or only have underscores in arguments. For example, the `torchrun` utility for distributed training only accepts underscore arguments (e.g., `--master_port`). The dashes are more common in other command-line tools. And it looks to be the default choice in the Python standard library:
`argparse.BooleanOptionalAction`: 4a9dff0e5a/Lib/argparse.py (L893-L895)
```python
class BooleanOptionalAction(Action):
def __init__(...):
if option_string.startswith('--'):
option_string = '--no-' + option_string[2:]
_option_strings.append(option_string)
```
It adds `--no-argname`, not `--no_argname`. Also typing `_` need to press the shift or the caps-lock key than `-`.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/94505
Approved by: https://github.com/ezyang, https://github.com/seemethere
116 lines
3.3 KiB
Python
Executable File
116 lines
3.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
|
|
"""Updates the default value of opset_version.
|
|
|
|
The current policy is that the default should be set to the
|
|
latest released version as of 18 months ago.
|
|
|
|
Usage:
|
|
Run with no arguments.
|
|
"""
|
|
|
|
import argparse
|
|
import datetime
|
|
import os
|
|
import pathlib
|
|
import re
|
|
import subprocess
|
|
import sys
|
|
from subprocess import DEVNULL
|
|
from typing import Any
|
|
|
|
|
|
def read_sub_write(path: str, prefix_pat: str, new_default: int) -> None:
|
|
with open(path, encoding="utf-8") as f:
|
|
content_str = f.read()
|
|
content_str = re.sub(prefix_pat, r"\g<1>{}".format(new_default), content_str)
|
|
with open(path, "w", encoding="utf-8") as f:
|
|
f.write(content_str)
|
|
print("modified", path)
|
|
|
|
|
|
def main(args: Any) -> None:
|
|
pytorch_dir = pathlib.Path(__file__).parent.parent.parent.resolve()
|
|
onnx_dir = pytorch_dir / "third_party" / "onnx"
|
|
os.chdir(onnx_dir)
|
|
|
|
date = datetime.datetime.now() - datetime.timedelta(days=18 * 30)
|
|
onnx_commit = subprocess.check_output(
|
|
("git", "log", f"--until={date}", "--max-count=1", "--format=%H"),
|
|
encoding="utf-8",
|
|
).strip()
|
|
onnx_tags = subprocess.check_output(
|
|
("git", "tag", "--list", f"--contains={onnx_commit}"), encoding="utf-8"
|
|
)
|
|
tag_tups = []
|
|
semver_pat = re.compile(r"v(\d+)\.(\d+)\.(\d+)")
|
|
for tag in onnx_tags.splitlines():
|
|
match = semver_pat.match(tag)
|
|
if match:
|
|
tag_tups.append(tuple(int(x) for x in match.groups()))
|
|
|
|
# Take the release 18 months ago
|
|
version_str = "{}.{}.{}".format(*min(tag_tups))
|
|
|
|
print("Using ONNX release", version_str)
|
|
|
|
head_commit = subprocess.check_output(
|
|
("git", "log", "--max-count=1", "--format=%H", "HEAD"), encoding="utf-8"
|
|
).strip()
|
|
|
|
new_default = None
|
|
|
|
subprocess.check_call(
|
|
("git", "checkout", f"v{version_str}"), stdout=DEVNULL, stderr=DEVNULL
|
|
)
|
|
try:
|
|
from onnx import helper # type: ignore[import]
|
|
|
|
for version in helper.VERSION_TABLE:
|
|
if version[0] == version_str:
|
|
new_default = version[2]
|
|
print("found new default opset_version", new_default)
|
|
break
|
|
if not new_default:
|
|
sys.exit(
|
|
f"failed to find version {version_str} in onnx.helper.VERSION_TABLE at commit {onnx_commit}"
|
|
)
|
|
finally:
|
|
subprocess.check_call(
|
|
("git", "checkout", head_commit), stdout=DEVNULL, stderr=DEVNULL
|
|
)
|
|
|
|
os.chdir(pytorch_dir)
|
|
|
|
read_sub_write(
|
|
os.path.join("torch", "onnx", "_constants.py"),
|
|
r"(ONNX_DEFAULT_OPSET = )\d+",
|
|
new_default,
|
|
)
|
|
read_sub_write(
|
|
os.path.join("torch", "onnx", "utils.py"),
|
|
r"(opset_version \(int, default )\d+",
|
|
new_default,
|
|
)
|
|
|
|
if not args.skip_build:
|
|
print("Building PyTorch...")
|
|
subprocess.check_call(
|
|
("python", "setup.py", "develop"),
|
|
)
|
|
print("Updating operator .expect files")
|
|
subprocess.check_call(
|
|
("python", os.path.join("test", "onnx", "test_operators.py"), "--accept"),
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument(
|
|
"--skip-build",
|
|
"--skip_build",
|
|
action="store_true",
|
|
help="Skip building pytorch",
|
|
)
|
|
main(parser.parse_args())
|