mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
9fedf41b60
Fixes #125526 [#1811](https://github.com/pytorch/builder/issues/1811) Adopt syntax=docker/dockerfile:1 whcih has been stable since 2018, while still best practice to declare in 2024. - Syntax features dependent upon the [syntax directive version are documented here](https://hub.docker.com/r/docker/dockerfile). - While you can set a fixed minor version, [Docker officially advises to only pin the major version] ``` (https://docs.docker.com/build/dockerfile/frontend/#stable-channel): We recommend using docker/dockerfile:1, which always points to the latest stable release of the version 1 syntax, and receives both "minor" and "patch" updates for the version 1 release cycle. BuildKit automatically checks for updates of the syntax when performing a build, making sure you are using the most current version. ``` **Support for building with Docker prior to v23 (released on Feb 2023)** NOTE: 18.06 may not be the accurate minimum version for using docker/dockerfile:1, according to the [DockerHub tag history](https://hub.docker.com/layers/docker/dockerfile/1.0/images/sha256-92f5351b2fca8f7e2f452aa9aec1c34213cdd2702ca92414eee6466fab21814a?context=explore) 1.0 of the syntax seems to be from Dec 2018, which is probably why docker/dockerfile:experimental was paired with it in this file. Personally, I'd favor only supporting builds with Docker v23. This is only relevant for someone building this Dockerfile locally, the user could still extend the already built and published image from a registry on older versions of Docker without any concern for this directive which only applies to building this Dockerfile, not images that extend it. However if you're reluctant, you may want to refer others to [this Docker docs page](https://docs.docker.com/build/buildkit/#getting-started) where they should only need the ENV DOCKER_BUILDKIT=1, presumably the requirement for experimental was dropped with syntax=docker/dockerfile:1 with releases of Docker since Dec 2018. Affected users can often quite easily install a newer version of Docker on their OS, as per Dockers official guidance (usually via including an additional repo to the package manager). **Reference links** Since one of these was already included in the inline note (now a broken link), I've included relevant links mentioned above. You could alternatively rely on git blame with a commit message referencing the links or this PR for more information. Feel free to remove any of the reference links, they're mostly only relevant to maintainers to be aware of (which this PR itself has detailed adequately above). Pull Request resolved: https://github.com/pytorch/pytorch/pull/125632 Approved by: https://github.com/malfet
118 lines
3.7 KiB
Makefile
118 lines
3.7 KiB
Makefile
DOCKER_REGISTRY ?= docker.io
|
|
DOCKER_ORG ?= $(shell docker info 2>/dev/null | sed '/Username:/!d;s/.* //')
|
|
DOCKER_IMAGE ?= pytorch
|
|
DOCKER_FULL_NAME = $(DOCKER_REGISTRY)/$(DOCKER_ORG)/$(DOCKER_IMAGE)
|
|
|
|
ifeq ("$(DOCKER_ORG)","")
|
|
$(warning WARNING: No docker user found using results from whoami)
|
|
DOCKER_ORG = $(shell whoami)
|
|
endif
|
|
|
|
CUDA_VERSION_SHORT ?= 12.1
|
|
CUDA_VERSION ?= 12.1.1
|
|
CUDNN_VERSION ?= 8
|
|
BASE_RUNTIME = ubuntu:22.04
|
|
BASE_DEVEL = nvidia/cuda:$(CUDA_VERSION)-cudnn$(CUDNN_VERSION)-devel-ubuntu22.04
|
|
CMAKE_VARS ?=
|
|
|
|
# The conda channel to use to install cudatoolkit
|
|
CUDA_CHANNEL = nvidia
|
|
# The conda channel to use to install pytorch / torchvision
|
|
INSTALL_CHANNEL ?= pytorch
|
|
|
|
PYTHON_VERSION ?= 3.10
|
|
# Match versions that start with v followed by a number, to avoid matching with tags like ciflow
|
|
PYTORCH_VERSION ?= $(shell git describe --tags --always --match "v[1-9]*.*")
|
|
# Can be either official / dev
|
|
BUILD_TYPE ?= dev
|
|
BUILD_PROGRESS ?= auto
|
|
# Intentionally left blank
|
|
TRITON_VERSION ?=
|
|
BUILD_ARGS = --build-arg BASE_IMAGE=$(BASE_IMAGE) \
|
|
--build-arg PYTHON_VERSION=$(PYTHON_VERSION) \
|
|
--build-arg CUDA_VERSION=$(CUDA_VERSION) \
|
|
--build-arg CUDA_CHANNEL=$(CUDA_CHANNEL) \
|
|
--build-arg PYTORCH_VERSION=$(PYTORCH_VERSION) \
|
|
--build-arg INSTALL_CHANNEL=$(INSTALL_CHANNEL) \
|
|
--build-arg TRITON_VERSION=$(TRITON_VERSION) \
|
|
--build-arg CMAKE_VARS="$(CMAKE_VARS)"
|
|
EXTRA_DOCKER_BUILD_FLAGS ?=
|
|
|
|
BUILD ?= build
|
|
# Intentionally left blank
|
|
PLATFORMS_FLAG ?=
|
|
PUSH_FLAG ?=
|
|
USE_BUILDX ?=
|
|
BUILD_PLATFORMS ?=
|
|
WITH_PUSH ?= false
|
|
# Setup buildx flags
|
|
ifneq ("$(USE_BUILDX)","")
|
|
BUILD = buildx build
|
|
ifneq ("$(BUILD_PLATFORMS)","")
|
|
PLATFORMS_FLAG = --platform="$(BUILD_PLATFORMS)"
|
|
endif
|
|
# Only set platforms flags if using buildx
|
|
ifeq ("$(WITH_PUSH)","true")
|
|
PUSH_FLAG = --push
|
|
endif
|
|
endif
|
|
|
|
DOCKER_BUILD = docker $(BUILD) \
|
|
--progress=$(BUILD_PROGRESS) \
|
|
$(EXTRA_DOCKER_BUILD_FLAGS) \
|
|
$(PLATFORMS_FLAG) \
|
|
$(PUSH_FLAG) \
|
|
--target $(BUILD_TYPE) \
|
|
-t $(DOCKER_FULL_NAME):$(DOCKER_TAG) \
|
|
$(BUILD_ARGS) .
|
|
DOCKER_PUSH = docker push $(DOCKER_FULL_NAME):$(DOCKER_TAG)
|
|
|
|
.PHONY: all
|
|
all: devel-image
|
|
|
|
.PHONY: devel-image
|
|
devel-image: BASE_IMAGE := $(BASE_DEVEL)
|
|
devel-image: DOCKER_TAG := $(PYTORCH_VERSION)-cuda$(CUDA_VERSION_SHORT)-cudnn$(CUDNN_VERSION)-devel
|
|
devel-image:
|
|
$(DOCKER_BUILD)
|
|
|
|
.PHONY: devel-push
|
|
devel-push: BASE_IMAGE := $(BASE_DEVEL)
|
|
devel-push: DOCKER_TAG := $(PYTORCH_VERSION)-cuda$(CUDA_VERSION_SHORT)-cudnn$(CUDNN_VERSION)-devel
|
|
devel-push:
|
|
$(DOCKER_PUSH)
|
|
|
|
ifeq ("$(CUDA_VERSION_SHORT)","cpu")
|
|
|
|
.PHONY: runtime-image
|
|
runtime-image: BASE_IMAGE := $(BASE_RUNTIME)
|
|
runtime-image: DOCKER_TAG := $(PYTORCH_VERSION)-runtime
|
|
runtime-image:
|
|
$(DOCKER_BUILD)
|
|
|
|
.PHONY: runtime-push
|
|
runtime-push: BASE_IMAGE := $(BASE_RUNTIME)
|
|
runtime-push: DOCKER_TAG := $(PYTORCH_VERSION)-runtime
|
|
runtime-push:
|
|
$(DOCKER_PUSH)
|
|
|
|
else
|
|
|
|
.PHONY: runtime-image
|
|
runtime-image: BASE_IMAGE := $(BASE_RUNTIME)
|
|
runtime-image: DOCKER_TAG := $(PYTORCH_VERSION)-cuda$(CUDA_VERSION_SHORT)-cudnn$(CUDNN_VERSION)-runtime
|
|
runtime-image:
|
|
$(DOCKER_BUILD)
|
|
|
|
.PHONY: runtime-push
|
|
runtime-push: BASE_IMAGE := $(BASE_RUNTIME)
|
|
runtime-push: DOCKER_TAG := $(PYTORCH_VERSION)-cuda$(CUDA_VERSION_SHORT)-cudnn$(CUDNN_VERSION)-runtime
|
|
runtime-push:
|
|
$(DOCKER_PUSH)
|
|
|
|
endif
|
|
|
|
.PHONY: clean
|
|
clean:
|
|
-docker rmi -f $(shell docker images -q $(DOCKER_FULL_NAME))
|