mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-21 05:34:18 +08:00
This is a lot of files changed! Don't panic! Here's how it works: * Previously, we set `follow_imports = silent` for our mypy.ini configuration. Per https://mypy.readthedocs.io/en/stable/running_mypy.html#follow-imports, what this does is whenever we have an import to a module which is not listed as a file to be typechecked in mypy, we typecheck it as normal but suppress all errors that occurred in that file. * When mypy is run inside lintrunner, the list of files is precisely the files covered by the glob in lintrunner.toml, but with files in excludes excluded. * The top-level directive `# mypy: ignore-errors` instructs mypy to typecheck the file as normal, but ignore all errors. * Therefore, it should be equivalent to set `follow_imports = normal`, if we put `# mypy: ignore-errors` on all files that were previously excluded from the file list. * Having done this, we can remove the exclude list from .lintrunner.toml, since excluding a file from typechecking is baked into the files themselves. * torch/_dynamo and torch/_inductor were previously in the exclude list, because they were covered by MYPYINDUCTOR. It is not OK to mark these as `# mypy: ignore-errors` as this will impede typechecking on the alternate configuration. So they are temporarily being checked twice, but I am suppressing the errors in these files as the configurations are not quite the same. I plan to unify the configurations so this is only a temporary state. * There were some straggler type errors after these changes somehow, so I fixed them as needed. There weren't that many. In the future, to start type checking a file, just remove the ignore-errors directive from the top of the file. The codemod was done with this script authored by GPT-4: ``` import glob exclude_patterns = [ ... ] for pattern in exclude_patterns: for filepath in glob.glob(pattern, recursive=True): if filepath.endswith('.py'): with open(filepath, 'r+') as f: content = f.read() f.seek(0, 0) f.write('# mypy: ignore-errors\n\n' + content) ``` Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: https://github.com/pytorch/pytorch/pull/118414 Approved by: https://github.com/thiagocrepaldi, https://github.com/albanD
166 lines
5.9 KiB
Python
166 lines
5.9 KiB
Python
# mypy: ignore-errors
|
|
|
|
import os
|
|
import re
|
|
import sys
|
|
from typing import List
|
|
|
|
__all__ = [
|
|
"check_code_for_cuda_kernel_launches",
|
|
"check_cuda_kernel_launches",
|
|
]
|
|
|
|
# FILES TO EXCLUDE (match is done with suffix using `endswith`)
|
|
# You wouldn't drive without a seatbelt, though, so why would you
|
|
# launch a kernel without some safety? Use this as a quick workaround
|
|
# for a problem with the checker, fix the checker, then de-exclude
|
|
# the files in question.
|
|
exclude_files: List[str] = []
|
|
|
|
# Without using a C++ AST we can't 100% detect kernel launches, so we
|
|
# model them as having the pattern "<<<parameters>>>(arguments);"
|
|
# We then require that `C10_CUDA_KERNEL_LAUNCH_CHECK` be
|
|
# the next statement.
|
|
#
|
|
# We model the next statement as ending at the next `}` or `;`.
|
|
# If we see `}` then a clause ended (bad) if we see a semi-colon then
|
|
# we expect the launch check just before it.
|
|
#
|
|
# Since the kernel launch can include lambda statements, it's important
|
|
# to find the correct end-paren of the kernel launch. Doing this with
|
|
# pure regex requires recursive regex, which aren't part of the Python
|
|
# standard library. To avoid an additional dependency, we build a prefix
|
|
# regex that finds the start of a kernel launch, use a paren-matching
|
|
# algorithm to find the end of the launch, and then another regex to
|
|
# determine if a launch check is present.
|
|
|
|
# Finds potential starts of kernel launches
|
|
kernel_launch_start = re.compile(
|
|
r"^.*<<<[^>]+>>>\s*\(", flags=re.MULTILINE
|
|
)
|
|
|
|
# This pattern should start at the character after the final paren of the
|
|
# kernel launch. It returns a match if the launch check is not the next statement
|
|
has_check = re.compile(
|
|
r"\s*;(?![^;}]*C10_CUDA_KERNEL_LAUNCH_CHECK\(\);)", flags=re.MULTILINE
|
|
)
|
|
|
|
def find_matching_paren(s: str, startpos: int) -> int:
|
|
"""Given a string "prefix (unknown number of characters) suffix"
|
|
and the position of the first `(` returns the index of the character
|
|
1 past the `)`, accounting for paren nesting
|
|
"""
|
|
opening = 0
|
|
for i, c in enumerate(s[startpos:]):
|
|
if c == '(':
|
|
opening += 1
|
|
elif c == ')':
|
|
opening -= 1
|
|
if opening == 0:
|
|
return startpos + i + 1
|
|
|
|
raise IndexError("Closing parens not found!")
|
|
|
|
|
|
def should_exclude_file(filename) -> bool:
|
|
for exclude_suffix in exclude_files:
|
|
if filename.endswith(exclude_suffix):
|
|
return True
|
|
return False
|
|
|
|
|
|
def check_code_for_cuda_kernel_launches(code, filename=None):
|
|
"""Checks code for CUDA kernel launches without cuda error checks.
|
|
|
|
Args:
|
|
filename - Filename of file containing the code. Used only for display
|
|
purposes, so you can put anything here.
|
|
code - The code to check
|
|
|
|
Returns:
|
|
The number of unsafe kernel launches in the code
|
|
"""
|
|
if filename is None:
|
|
filename = "##Python Function Call##"
|
|
|
|
# We break the code apart and put it back together to add
|
|
# helpful line numberings for identifying problem areas
|
|
code = enumerate(code.split("\n")) # Split by line breaks
|
|
code = [f"{lineno}: {linecode}" for lineno, linecode in code] # Number the lines
|
|
code = '\n'.join(code) # Put it back together
|
|
|
|
num_launches_without_checks = 0
|
|
for m in kernel_launch_start.finditer(code):
|
|
end_paren = find_matching_paren(code, m.end() - 1)
|
|
if has_check.match(code, end_paren):
|
|
num_launches_without_checks += 1
|
|
context = code[m.start():end_paren + 1]
|
|
print(f"Missing C10_CUDA_KERNEL_LAUNCH_CHECK in '{filename}'. Context:\n{context}", file=sys.stderr)
|
|
|
|
return num_launches_without_checks
|
|
|
|
|
|
def check_file(filename):
|
|
"""Checks a file for CUDA kernel launches without cuda error checks
|
|
|
|
Args:
|
|
filename - File to check
|
|
|
|
Returns:
|
|
The number of unsafe kernel launches in the file
|
|
"""
|
|
if not (filename.endswith((".cu", ".cuh"))):
|
|
return 0
|
|
if should_exclude_file(filename):
|
|
return 0
|
|
with open(filename) as fo:
|
|
contents = fo.read()
|
|
unsafeCount = check_code_for_cuda_kernel_launches(contents, filename)
|
|
return unsafeCount
|
|
|
|
|
|
def check_cuda_kernel_launches():
|
|
"""Checks all pytorch code for CUDA kernel launches without cuda error checks
|
|
|
|
Returns:
|
|
The number of unsafe kernel launches in the codebase
|
|
"""
|
|
torch_dir = os.path.dirname(os.path.realpath(__file__))
|
|
torch_dir = os.path.dirname(torch_dir) # Go up to parent torch
|
|
torch_dir = os.path.dirname(torch_dir) # Go up to parent caffe2
|
|
|
|
kernels_without_checks = 0
|
|
files_without_checks = []
|
|
for root, dirnames, filenames in os.walk(torch_dir):
|
|
# `$BASE/build` and `$BASE/torch/include` are generated
|
|
# so we don't want to flag their contents
|
|
if root == os.path.join(torch_dir, "build") or root == os.path.join(torch_dir, "torch/include"):
|
|
# Curtail search by modifying dirnames and filenames in place
|
|
# Yes, this is the way to do this, see `help(os.walk)`
|
|
dirnames[:] = []
|
|
continue
|
|
|
|
for x in filenames:
|
|
filename = os.path.join(root, x)
|
|
file_result = check_file(filename)
|
|
if file_result > 0:
|
|
kernels_without_checks += file_result
|
|
files_without_checks.append(filename)
|
|
|
|
if kernels_without_checks > 0:
|
|
count_str = f"Found {kernels_without_checks} instances in " \
|
|
f"{len(files_without_checks)} files where kernel " \
|
|
"launches didn't have checks."
|
|
print(count_str, file=sys.stderr)
|
|
print("Files without checks:", file=sys.stderr)
|
|
for x in files_without_checks:
|
|
print(f"\t{x}", file=sys.stderr)
|
|
print(count_str, file=sys.stderr)
|
|
|
|
return kernels_without_checks
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unsafe_launches = check_cuda_kernel_launches()
|
|
sys.exit(0 if unsafe_launches == 0 else 1)
|