mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 12:54:11 +08:00
8fa81a6066
Enables clang-tidy rule [`misc-use-internal-linkage`](https://clang.llvm.org/extra/clang-tidy/checks/misc/use-internal-linkage.html). This new check was introduced in Clang-Tidy 18 and is available due to recent update of Clang-Tidy 19. The check marks functions and variables used only in the translation unit as static. Therefore undesired symbols are not leaked into other units, more link time optimisations are possible and the resulting binaries may be smaller. The detected violations were mostly fixed by using static. In other cases, the symbols were indeed consumed by others files, then their declaring headers were included. Still some declarations were wrong and have been fixed. Pull Request resolved: https://github.com/pytorch/pytorch/pull/148948 Approved by: https://github.com/Skylion007
78 lines
2.7 KiB
YAML
78 lines
2.7 KiB
YAML
---
|
|
# NOTE there must be no spaces before the '-', so put the comma last.
|
|
# The check bugprone-unchecked-optional-access is also turned on.
|
|
# Note that it can cause clang-tidy to hang randomly. The tracking issue
|
|
# can be found at https://github.com/llvm/llvm-project/issues/69369.
|
|
# When that happens, we can disable it on the problematic code by NOLINT.
|
|
InheritParentConfig: true
|
|
Checks: '
|
|
bugprone-*,
|
|
-bugprone-easily-swappable-parameters,
|
|
-bugprone-forward-declaration-namespace,
|
|
-bugprone-macro-parentheses,
|
|
-bugprone-lambda-function-name,
|
|
-bugprone-reserved-identifier,
|
|
-bugprone-return-const-ref-from-parameter,
|
|
-bugprone-swapped-arguments,
|
|
clang-analyzer-core.*,
|
|
clang-analyzer-cplusplus.*,
|
|
clang-analyzer-nullability.*,
|
|
clang-analyzer-deadcode.*,
|
|
clang-diagnostic-missing-prototypes,
|
|
cppcoreguidelines-*,
|
|
-cppcoreguidelines-avoid-do-while,
|
|
-cppcoreguidelines-avoid-magic-numbers,
|
|
-cppcoreguidelines-avoid-non-const-global-variables,
|
|
-cppcoreguidelines-interfaces-global-init,
|
|
-cppcoreguidelines-macro-usage,
|
|
-cppcoreguidelines-macro-to-enum,
|
|
-cppcoreguidelines-owning-memory,
|
|
-cppcoreguidelines-pro-bounds-array-to-pointer-decay,
|
|
-cppcoreguidelines-pro-bounds-constant-array-index,
|
|
-cppcoreguidelines-pro-bounds-pointer-arithmetic,
|
|
-cppcoreguidelines-pro-type-cstyle-cast,
|
|
-cppcoreguidelines-pro-type-reinterpret-cast,
|
|
-cppcoreguidelines-pro-type-static-cast-downcast,
|
|
-cppcoreguidelines-pro-type-union-access,
|
|
-cppcoreguidelines-pro-type-vararg,
|
|
-cppcoreguidelines-non-private-member-variables-in-classes,
|
|
-facebook-hte-RelativeInclude,
|
|
hicpp-exception-baseclass,
|
|
hicpp-avoid-goto,
|
|
misc-*,
|
|
-misc-confusable-identifiers,
|
|
-misc-const-correctness,
|
|
-misc-include-cleaner,
|
|
-misc-use-anonymous-namespace,
|
|
-misc-unused-parameters,
|
|
-misc-no-recursion,
|
|
-misc-non-private-member-variables-in-classes,
|
|
-misc-unused-using-decls,
|
|
modernize-*,
|
|
-modernize-macro-to-enum,
|
|
-modernize-return-braced-init-list,
|
|
-modernize-use-auto,
|
|
-modernize-use-default-member-init,
|
|
-modernize-use-using,
|
|
-modernize-use-trailing-return-type,
|
|
-modernize-use-nodiscard,
|
|
performance-*,
|
|
-performance-enum-size,
|
|
readability-container-size-empty,
|
|
readability-delete-null-pointer,
|
|
readability-duplicate-include
|
|
readability-misplaced-array-index,
|
|
readability-redundant*
|
|
readability-simplify-subscript-expr,
|
|
readability-string-compare,
|
|
-readability-redundant-access-specifiers,
|
|
-readability-redundant-control-flow,
|
|
'
|
|
HeaderFilterRegex: '^(aten/|c10/|torch/).*$'
|
|
WarningsAsErrors: '*'
|
|
CheckOptions:
|
|
cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor: true
|
|
cppcoreguidelines-special-member-functions.AllowImplicitlyDeletedCopyOrMove: true
|
|
misc-header-include-cycle.IgnoredFilesList: 'format.h;ivalue.h;custom_class.h;Dict.h;List.h;IListRef.h'
|
|
...
|