mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
85dd7b84cf
This patch introduces a `DynamoFrameType` to serve as a layer between Dynamo and different versions of Python frame object. In `DynamoFrameType`, we only register attributes Dynamo cares about (e.g., `f_code`, `f_locals`, etc. This will be helpful when it comes to adding new attributes to this `DynamoFrameType`, or dealing with Python version changes. Pull Request resolved: https://github.com/pytorch/pytorch/pull/140330 Approved by: https://github.com/jansel, https://github.com/williamwen42
Note [TH abstraction violation] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ TH/THC provide some hpp headers, which are proper C++ headers rather than C headers. These headers serve double duty as *internal implementation detail* headers, whose contents should largely not be used by external clients. Ideally, we would not install these headers at all; instead, you should use public functions (in headers like `THTensor.h`, NOT `THTensor.hpp`) to manipulate these structs. However, there are a few places in torch/csrc where we violate this abstraction. They are marked with a pointer to this note. Each of those sites will have to be refactored when we refactor the guts of THTensor and related structures.