mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
6c1f1563e1
This PR fix the `UndefinedTensorImpl::_singleton` can't export on Windows issue. Snapshot: <img width="1346" alt="image" src="https://github.com/user-attachments/assets/b34256ac-a0ae-473b-89e6-10d755eaad24"> The reason is MSVC can't export class static data to external linkage, ref: https://learn.microsoft.com/en-us/cpp/cpp/using-dllimport-and-dllexport-in-cpp-classes?view=msvc-170#_pluslang_using_dllimport_and_dllexport_in_c2b2bselectivememberimportexport I use another singleton implenmentation to avoid the issue, for Windows. Since this PR, cpp_wrapper on Windows would start to work. <img width="1916" alt="image" src="https://github.com/user-attachments/assets/c1d7d7e7-64ca-4c6d-9fb7-e3b91e675b58"> Next step, I will enable the cpp_wrapper UTs. Pull Request resolved: https://github.com/pytorch/pytorch/pull/132326 Approved by: https://github.com/jgong5, https://github.com/desertfire
50 lines
1.2 KiB
C++
50 lines
1.2 KiB
C++
#pragma once
|
|
|
|
#include <c10/core/MemoryFormat.h>
|
|
#include <c10/core/SymIntArrayRef.h>
|
|
#include <c10/core/TensorImpl.h>
|
|
#include <c10/macros/Export.h>
|
|
#include <c10/util/ArrayRef.h>
|
|
#include <cstdint>
|
|
|
|
namespace c10 {
|
|
|
|
struct C10_API UndefinedTensorImpl final : public TensorImpl {
|
|
public:
|
|
// Without this, we get:
|
|
// error: identifier "at::UndefinedTensorImpl::_singleton" is undefined in
|
|
// device code
|
|
// (ostensibly because the constexpr tricks MSVC into trying to compile this
|
|
// function for device as well).
|
|
#ifdef _WIN32
|
|
static inline TensorImpl* singleton() {
|
|
return &getInstance();
|
|
}
|
|
#else
|
|
static constexpr inline TensorImpl* singleton() {
|
|
return &_singleton;
|
|
}
|
|
#endif
|
|
|
|
#ifdef DEBUG
|
|
bool has_storage() const override;
|
|
#endif
|
|
void set_storage_offset(int64_t offset) override;
|
|
|
|
protected:
|
|
bool is_contiguous_custom(MemoryFormat format) const override;
|
|
IntArrayRef strides_custom() const override;
|
|
SymIntArrayRef sym_strides_custom() const override;
|
|
|
|
private:
|
|
UndefinedTensorImpl();
|
|
#ifdef _WIN32
|
|
static UndefinedTensorImpl& getInstance();
|
|
#else
|
|
static UndefinedTensorImpl _singleton;
|
|
#endif
|
|
const char* tensorimpl_type_name() const override;
|
|
};
|
|
|
|
} // namespace c10
|