mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-21 05:34:18 +08:00
Summary: [Comment](https://github.com/pytorch/pytorch/pull/62445/files#r680132022) claims, it got added for consistency with top level CMakeLists.txt, but `-Wno-unused-variable` is not mentioned there. Modify violations in 50+ files that were added in the interim by either removing unused variables, or decorating the code with `C10_UNUSED` if local variable is likely used to extend object lifetime until the end of the block. Caused preventable revert in https://github.com/pytorch/pytorch/pull/72633#issuecomment-1092300787 Pull Request resolved: https://github.com/pytorch/pytorch/pull/75538 Reviewed By: anjali411 Differential Revision: D35747333 Pulled By: malfet fbshipit-source-id: 3fc5828e44a4c05ba0e89e92613e6ebbdb260626 (cherry picked from commit c179fba21cfa2a0093fad50ccad5a22dd7cff52c)
177 lines
5.8 KiB
C++
177 lines
5.8 KiB
C++
#include "caffe2/queue/blobs_queue.h"
|
|
|
|
#include <atomic>
|
|
#include <condition_variable>
|
|
#include <memory>
|
|
#include <mutex>
|
|
#include <queue>
|
|
|
|
#include "caffe2/core/blob_stats.h"
|
|
#include "caffe2/core/logging.h"
|
|
#include "caffe2/core/stats.h"
|
|
#include "caffe2/core/tensor.h"
|
|
#include "caffe2/core/timer.h"
|
|
#include "caffe2/core/workspace.h"
|
|
|
|
#include <c10/util/irange.h>
|
|
|
|
namespace caffe2 {
|
|
|
|
// Constants for user tracepoints
|
|
C10_UNUSED static constexpr int SDT_NONBLOCKING_OP = 0;
|
|
C10_UNUSED static constexpr int SDT_BLOCKING_OP = 1;
|
|
C10_UNUSED static constexpr uint64_t SDT_TIMEOUT = (uint64_t)-1;
|
|
C10_UNUSED static constexpr uint64_t SDT_ABORT = (uint64_t)-2;
|
|
C10_UNUSED static constexpr uint64_t SDT_CANCEL = (uint64_t)-3;
|
|
|
|
BlobsQueue::BlobsQueue(
|
|
Workspace* ws,
|
|
const std::string& queueName,
|
|
size_t capacity,
|
|
size_t numBlobs,
|
|
bool enforceUniqueName,
|
|
const std::vector<std::string>& fieldNames)
|
|
: numBlobs_(numBlobs), name_(queueName), stats_(queueName) {
|
|
if (!fieldNames.empty()) {
|
|
CAFFE_ENFORCE_EQ(
|
|
fieldNames.size(), numBlobs, "Wrong number of fieldNames provided.");
|
|
stats_.queue_dequeued_bytes.setDetails(fieldNames);
|
|
}
|
|
queue_.reserve(capacity);
|
|
for (size_t i = 0; i < capacity; ++i) {
|
|
std::vector<Blob*> blobs;
|
|
blobs.reserve(numBlobs);
|
|
for (size_t j = 0; j < numBlobs; ++j) {
|
|
const auto blobName = queueName + "_" + to_string(i) + "_" + to_string(j);
|
|
if (enforceUniqueName) {
|
|
CAFFE_ENFORCE(
|
|
!ws->GetBlob(blobName),
|
|
"Queue internal blob already exists: ",
|
|
blobName);
|
|
}
|
|
blobs.push_back(ws->CreateBlob(blobName));
|
|
}
|
|
queue_.push_back(blobs);
|
|
}
|
|
DCHECK_EQ(queue_.size(), capacity);
|
|
}
|
|
|
|
bool BlobsQueue::blockingRead(
|
|
const std::vector<Blob*>& inputs,
|
|
float timeout_secs) {
|
|
Timer readTimer;
|
|
auto keeper = this->shared_from_this();
|
|
C10_UNUSED const auto& name = name_.c_str();
|
|
CAFFE_SDT(queue_read_start, name, (void*)this, SDT_BLOCKING_OP);
|
|
std::unique_lock<std::mutex> g(mutex_);
|
|
auto canRead = [this]() {
|
|
CAFFE_ENFORCE_LE(reader_, writer_);
|
|
return reader_ != writer_;
|
|
};
|
|
// Decrease queue balance before reading to indicate queue read pressure
|
|
// is being increased (-ve queue balance indicates more reads than writes)
|
|
CAFFE_EVENT(stats_, queue_balance, -1);
|
|
if (timeout_secs > 0) {
|
|
std::chrono::milliseconds timeout_ms(int(timeout_secs * 1000));
|
|
cv_.wait_for(
|
|
g, timeout_ms, [this, canRead]() { return closing_ || canRead(); });
|
|
} else {
|
|
cv_.wait(g, [this, canRead]() { return closing_ || canRead(); });
|
|
}
|
|
if (!canRead()) {
|
|
if (timeout_secs > 0 && !closing_) {
|
|
LOG(ERROR) << "DequeueBlobs timed out in " << timeout_secs << " secs";
|
|
CAFFE_SDT(queue_read_end, name, (void*)this, SDT_TIMEOUT);
|
|
} else {
|
|
CAFFE_SDT(queue_read_end, name, (void*)this, SDT_CANCEL);
|
|
}
|
|
return false;
|
|
}
|
|
DCHECK(canRead());
|
|
auto& result = queue_[reader_ % queue_.size()];
|
|
CAFFE_ENFORCE(inputs.size() >= result.size());
|
|
for (const auto i : c10::irange(result.size())) {
|
|
auto bytes = BlobStat::sizeBytes(*result[i]);
|
|
CAFFE_EVENT(stats_, queue_dequeued_bytes, bytes, i);
|
|
using std::swap;
|
|
swap(*(inputs[i]), *(result[i]));
|
|
}
|
|
CAFFE_SDT(queue_read_end, name, (void*)this, writer_ - reader_);
|
|
CAFFE_EVENT(stats_, queue_dequeued_records);
|
|
++reader_;
|
|
cv_.notify_all();
|
|
CAFFE_EVENT(stats_, read_time_ns, readTimer.NanoSeconds());
|
|
return true;
|
|
}
|
|
|
|
bool BlobsQueue::tryWrite(const std::vector<Blob*>& inputs) {
|
|
Timer writeTimer;
|
|
auto keeper = this->shared_from_this();
|
|
C10_UNUSED const auto& name = name_.c_str();
|
|
CAFFE_SDT(queue_write_start, name, (void*)this, SDT_NONBLOCKING_OP);
|
|
std::unique_lock<std::mutex> g(mutex_);
|
|
if (!canWrite()) {
|
|
CAFFE_SDT(queue_write_end, name, (void*)this, SDT_ABORT);
|
|
return false;
|
|
}
|
|
// Increase queue balance before writing to indicate queue write pressure is
|
|
// being increased (+ve queue balance indicates more writes than reads)
|
|
CAFFE_EVENT(stats_, queue_balance, 1);
|
|
DCHECK(canWrite());
|
|
doWrite(inputs);
|
|
CAFFE_EVENT(stats_, write_time_ns, writeTimer.NanoSeconds());
|
|
return true;
|
|
}
|
|
|
|
bool BlobsQueue::blockingWrite(const std::vector<Blob*>& inputs) {
|
|
Timer writeTimer;
|
|
auto keeper = this->shared_from_this();
|
|
C10_UNUSED const auto& name = name_.c_str();
|
|
CAFFE_SDT(queue_write_start, name, (void*)this, SDT_BLOCKING_OP);
|
|
std::unique_lock<std::mutex> g(mutex_);
|
|
// Increase queue balance before writing to indicate queue write pressure is
|
|
// being increased (+ve queue balance indicates more writes than reads)
|
|
CAFFE_EVENT(stats_, queue_balance, 1);
|
|
cv_.wait(g, [this]() { return closing_ || canWrite(); });
|
|
if (!canWrite()) {
|
|
CAFFE_SDT(queue_write_end, name, (void*)this, SDT_ABORT);
|
|
return false;
|
|
}
|
|
DCHECK(canWrite());
|
|
doWrite(inputs);
|
|
CAFFE_EVENT(stats_, write_time_ns, writeTimer.NanoSeconds());
|
|
return true;
|
|
}
|
|
|
|
void BlobsQueue::close() {
|
|
closing_ = true;
|
|
|
|
std::lock_guard<std::mutex> g(mutex_);
|
|
cv_.notify_all();
|
|
}
|
|
|
|
bool BlobsQueue::canWrite() {
|
|
// writer is always within [reader, reader + size)
|
|
// we can write if reader is within [reader, reader + size)
|
|
CAFFE_ENFORCE_LE(reader_, writer_);
|
|
CAFFE_ENFORCE_LE(writer_, static_cast<int64_t>(reader_ + queue_.size()));
|
|
// NOLINTNEXTLINE(clang-diagnostic-sign-compare)
|
|
return writer_ != reader_ + queue_.size();
|
|
}
|
|
|
|
void BlobsQueue::doWrite(const std::vector<Blob*>& inputs) {
|
|
auto& result = queue_[writer_ % queue_.size()];
|
|
CAFFE_ENFORCE(inputs.size() >= result.size());
|
|
C10_UNUSED const auto& name = name_.c_str();
|
|
for (const auto i : c10::irange(result.size())) {
|
|
using std::swap;
|
|
swap(*(inputs[i]), *(result[i]));
|
|
}
|
|
CAFFE_SDT(
|
|
queue_write_end, name, (void*)this, reader_ + queue_.size() - writer_);
|
|
++writer_;
|
|
cv_.notify_all();
|
|
}
|
|
|
|
} // namespace caffe2
|