mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 12:54:11 +08:00
5bcbbf5373
Summary: *Context:* https://github.com/pytorch/pytorch/issues/53406 added a lint for trailing whitespace at the ends of lines. However, in order to pass FB-internal lints, that PR also had to normalize the trailing newlines in four of the files it touched. This PR adds an OSS lint to normalize trailing newlines. The changes to the following files (made in 54847d0adb9be71be4979cead3d9d4c02160e4cd) are the only manually-written parts of this PR: - `.github/workflows/lint.yml` - `mypy-strict.ini` - `tools/README.md` - `tools/test/test_trailing_newlines.py` - `tools/trailing_newlines.py` I would have liked to make this just a shell one-liner like the other three similar lints, but nothing I could find quite fit the bill. Specifically, all the answers I tried from the following Stack Overflow questions were far too slow (at least a minute and a half to run on this entire repository): - [How to detect file ends in newline?](https://stackoverflow.com/q/38746) - [How do I find files that do not end with a newline/linefeed?](https://stackoverflow.com/q/4631068) - [How to list all files in the Git index without newline at end of file](https://stackoverflow.com/q/27624800) - [Linux - check if there is an empty line at the end of a file [duplicate]](https://stackoverflow.com/q/34943632) - [git ensure newline at end of each file](https://stackoverflow.com/q/57770972) To avoid giving false positives during the few days after this PR is merged, we should probably only merge it after https://github.com/pytorch/pytorch/issues/54967. Pull Request resolved: https://github.com/pytorch/pytorch/pull/54737 Test Plan: Running the shell script from the "Ensure correct trailing newlines" step in the `quick-checks` job of `.github/workflows/lint.yml` should print no output and exit in a fraction of a second with a status of 0. That was not the case prior to this PR, as shown by this failing GHA workflow run on an earlier draft of this PR: - https://github.com/pytorch/pytorch/runs/2197446987?check_suite_focus=true In contrast, this run (after correcting the trailing newlines in this PR) succeeded: - https://github.com/pytorch/pytorch/pull/54737/checks?check_run_id=2197553241 To unit-test `tools/trailing_newlines.py` itself (this is run as part of our "Test tools" GitHub Actions workflow): ``` python tools/test/test_trailing_newlines.py ``` Reviewed By: malfet Differential Revision: D27409736 Pulled By: samestep fbshipit-source-id: 46f565227046b39f68349bbd5633105b2d2e9b19
110 lines
3.4 KiB
CMake
110 lines
3.4 KiB
CMake
# James Bigler, NVIDIA Corp (nvidia.com - jbigler)
|
|
# Abe Stephens, SCI Institute -- http://www.sci.utah.edu/~abe/FindCuda.html
|
|
#
|
|
# Copyright (c) 2008 - 2009 NVIDIA Corporation. All rights reserved.
|
|
#
|
|
# Copyright (c) 2007-2009
|
|
# Scientific Computing and Imaging Institute, University of Utah
|
|
#
|
|
# This code is licensed under the MIT License. See the FindCUDA.cmake script
|
|
# for the text of the license.
|
|
|
|
# The MIT License
|
|
#
|
|
# License for the specific language governing rights and limitations under
|
|
# Permission is hereby granted, free of charge, to any person obtaining a
|
|
# copy of this software and associated documentation files (the "Software"),
|
|
# to deal in the Software without restriction, including without limitation
|
|
# the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
# and/or sell copies of the Software, and to permit persons to whom the
|
|
# Software is furnished to do so, subject to the following conditions:
|
|
#
|
|
# The above copyright notice and this permission notice shall be included
|
|
# in all copies or substantial portions of the Software.
|
|
#
|
|
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
# OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
# FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
# DEALINGS IN THE SOFTWARE.
|
|
#
|
|
|
|
#######################################################################
|
|
# Parses a .cubin file produced by nvcc and reports statistics about the file.
|
|
|
|
|
|
file(READ ${input_file} file_text)
|
|
|
|
if (NOT "${file_text}" STREQUAL "")
|
|
|
|
string(REPLACE ";" "\\;" file_text ${file_text})
|
|
string(REPLACE "\ncode" ";code" file_text ${file_text})
|
|
|
|
list(LENGTH file_text len)
|
|
|
|
foreach(line ${file_text})
|
|
|
|
# Only look at "code { }" blocks.
|
|
if(line MATCHES "^code")
|
|
|
|
# Break into individual lines.
|
|
string(REGEX REPLACE "\n" ";" line ${line})
|
|
|
|
foreach(entry ${line})
|
|
|
|
# Extract kernel names.
|
|
if (${entry} MATCHES "[^g]name = ([^ ]+)")
|
|
set(entry "${CMAKE_MATCH_1}")
|
|
|
|
# Check to see if the kernel name starts with "_"
|
|
set(skip FALSE)
|
|
# if (${entry} MATCHES "^_")
|
|
# Skip the rest of this block.
|
|
# message("Skipping ${entry}")
|
|
# set(skip TRUE)
|
|
# else ()
|
|
message("Kernel: ${entry}")
|
|
# endif ()
|
|
|
|
endif()
|
|
|
|
# Skip the rest of the block if necessary
|
|
if(NOT skip)
|
|
|
|
# Registers
|
|
if (${entry} MATCHES "reg([ ]+)=([ ]+)([^ ]+)")
|
|
set(entry "${CMAKE_MATCH_3}")
|
|
message("Registers: ${entry}")
|
|
endif()
|
|
|
|
# Local memory
|
|
if (${entry} MATCHES "lmem([ ]+)=([ ]+)([^ ]+)")
|
|
set(entry "${CMAKE_MATCH_3}")
|
|
message("Local: ${entry}")
|
|
endif()
|
|
|
|
# Shared memory
|
|
if (${entry} MATCHES "smem([ ]+)=([ ]+)([^ ]+)")
|
|
set(entry "${CMAKE_MATCH_3}")
|
|
message("Shared: ${entry}")
|
|
endif()
|
|
|
|
if (${entry} MATCHES "^}")
|
|
message("")
|
|
endif()
|
|
|
|
endif()
|
|
|
|
|
|
endforeach()
|
|
|
|
endif()
|
|
|
|
endforeach()
|
|
|
|
else()
|
|
# message("FOUND NO DEPENDS")
|
|
endif()
|