mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
This reverts commit 03e35efbf733da28d9e1c5a4b1b203fe335b5f94. Reverted https://github.com/pytorch/pytorch/pull/108866 on behalf of https://github.com/clee2000 due to Sorry but I found more usages of `torch::make_unique` internally, I can go change all of these, but I'd prefer if that gets done before this gets merged ([comment](https://github.com/pytorch/pytorch/pull/108866#issuecomment-1722577925))
38 lines
1022 B
C++
38 lines
1022 B
C++
#include <gtest/gtest.h>
|
|
|
|
#include <torch/csrc/utils/memory.h>
|
|
|
|
#include <c10/util/Optional.h>
|
|
|
|
struct TestValue {
|
|
explicit TestValue(const int& x) : lvalue_(x) {}
|
|
explicit TestValue(int&& x) : rvalue_(x) {}
|
|
|
|
c10::optional<int> lvalue_;
|
|
c10::optional<int> rvalue_;
|
|
};
|
|
|
|
TEST(MakeUniqueTest, ForwardRvaluesCorrectly) {
|
|
auto ptr = torch::make_unique<TestValue>(123);
|
|
ASSERT_FALSE(ptr->lvalue_.has_value());
|
|
ASSERT_TRUE(ptr->rvalue_.has_value());
|
|
ASSERT_EQ(*ptr->rvalue_, 123);
|
|
}
|
|
|
|
TEST(MakeUniqueTest, ForwardLvaluesCorrectly) {
|
|
int x = 5;
|
|
auto ptr = torch::make_unique<TestValue>(x);
|
|
ASSERT_TRUE(ptr->lvalue_.has_value());
|
|
ASSERT_EQ(*ptr->lvalue_, 5);
|
|
ASSERT_FALSE(ptr->rvalue_.has_value());
|
|
}
|
|
|
|
TEST(MakeUniqueTest, CanConstructUniquePtrOfArray) {
|
|
// NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
|
|
auto ptr = torch::make_unique<int[]>(3);
|
|
// Value initialization is required by the standard.
|
|
ASSERT_EQ(ptr[0], 0);
|
|
ASSERT_EQ(ptr[1], 0);
|
|
ASSERT_EQ(ptr[2], 0);
|
|
}
|