mirror of
https://github.com/pytorch/pytorch.git
synced 2025-11-19 18:14:54 +08:00
Work Around for: https://github.com/pytorch/pytorch/issues/133437 Test plan: 1. Build whl in CI 2. Download 3. Run ``nm -D libtorch_cpu.so | grep "recursive_directory_iterator"`` Test with check_binary_symbols.py: Success: ``` num_cxx11_symbols: 2326 num_pre_cxx11_symbols: 0 lib: /home/ec2-user/github/variant-repack/.venv/lib/python3.10/site-packages/torch/lib/libtorch_cpu.so num_statically_linked_symbols (T): 0 ``` Fail when using "W" instead of "T" as type calling ``cxx11_statically_linked_symbols = grep_symbols( lib, STATICALLY_LINKED_CXX11_ABI, symbol_type="W" )`` : ``` num_cxx11_symbols: 2326 num_pre_cxx11_symbols: 0 lib: /home/ec2-user/github/variant-repack/.venv/lib/python3.10/site-packages/torch/lib/libtorch_cpu.so num_statically_linked_symbols (T): 20 Traceback (most recent call last): File "/home/ec2-user/github/variant-repack/test/pytorch/.ci/pytorch/smoke_test/check_binary_symbolsc.py", line 130, in <module> main() File "/home/ec2-user/github/variant-repack/test/pytorch/.ci/pytorch/smoke_test/check_binary_symbolsc.py", line 126, in main check_lib_statically_linked_libstdc_cxx_abi_symbols(libtorch_cpu_path) File "/home/ec2-user/github/variant-repack/test/pytorch/.ci/pytorch/smoke_test/check_binary_symbolsc.py", line 95, in check_lib_statically_linked_libstdc_cxx_abi_symbols raise RuntimeError( RuntimeError: Found statically linked libstdc++ symbols (recursive_directory_iterator), but there shouldn't be any, see: ['std::filesystem::__cxx11::recursive_directory_iterator::recursion_pending() const', 'std::filesystem::__cxx11::recursive_directory_iterator::depth() const', 'std::filesystem::__cxx11::recursive_directory_iterator::options() const', 'std::filesystem::__cxx11::recursive_directory_iterator::operator*() const', 'std::__shared_ptr<std::filesystem::__cxx11::recursive_directory_iterator::_Dir_stack, (__gnu_cxx::_Lock_policy)2>::operator bool() const', 'std::filesystem::__cxx11::recursive_directory_iterator::disable_recursion_pending()', 'std::filesystem::__cxx11::recursive_directory_iterator::pop(std::error_code&)', 'std::filesystem::__cxx11::recursive_directory_iterator::pop()', 'std::filesystem::__cxx11::recursive_directory_iterator::increment(std::error_code&)', 'std::filesystem::__cxx11::recursive_directory_iterator::recursive_directory_iterator(std::filesystem::__cxx11::path const&, std::filesystem::directory_options, std::error_code*)', 'std::filesystem::__cxx11::recursive_directory_iterator::recursive_directory_iterator(std::filesystem::__cxx11::path const&, std::filesystem::directory_options, std::error_code*)', 'std::filesystem::__cxx11::recursive_directory_iterator::~recursive_directory_iterator()', 'std::filesystem::__cxx11::recursive_directory_iterator::~recursive_directory_iterator()', 'std::filesystem::__cxx11::recursive_directory_iterator::operator=(std::filesystem::__cxx11::recursive_directory_iterator&&)', 'std::filesystem::__cxx11::recursive_directory_iterator::operator=(std::filesystem::__cxx11::recursive_directory_iterator const&)', 'std::filesystem::__cxx11::recursive_directory_iterator::operator++()', 'std::__shared_ptr<std::filesystem::__cxx11::recursive_directory_iterator::_Dir_stack, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__shared_ptr<std::filesystem::__cxx11::recursive_directory_iterator::_Dir_stack, (__gnu_cxx::_Lock_policy)2>&&)', 'std::__shared_ptr<std::filesystem::__cxx11::recursive_directory_iterator::_Dir_stack, (__gnu_cxx::_Lock_policy)2>::__shared_ptr()', 'std::__shared_ptr<std::filesystem::__cxx11::recursive_directory_iterator::_Dir_stack, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__shared_ptr<std::filesystem::__cxx11::recursive_directory_iterator::_Dir_stack, (__gnu_cxx::_Lock_policy)2>&&)', 'std::__shared_ptr<std::filesystem::__cxx11::recursive_directory_iterator::_Dir_stack, (__gnu_cxx::_Lock_policy)2>::__shared_ptr()'] ``` Pull Request resolved: https://github.com/pytorch/pytorch/pull/163980 Approved by: https://github.com/isuruf, https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
135 lines
4.5 KiB
Python
Executable File
135 lines
4.5 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
import concurrent.futures
|
|
import distutils.sysconfig
|
|
import functools
|
|
import itertools
|
|
import os
|
|
import re
|
|
from pathlib import Path
|
|
from typing import Any
|
|
|
|
|
|
# We also check that there are [not] cxx11 symbols in libtorch
|
|
#
|
|
# To check whether it is using cxx11 ABI, check non-existence of symbol:
|
|
PRE_CXX11_SYMBOLS = (
|
|
"std::basic_string<",
|
|
"std::list",
|
|
)
|
|
# To check whether it is using pre-cxx11 ABI, check non-existence of symbol:
|
|
CXX11_SYMBOLS = (
|
|
"std::__cxx11::basic_string",
|
|
"std::__cxx11::list",
|
|
)
|
|
# NOTE: Checking the above symbols in all namespaces doesn't work, because
|
|
# devtoolset7 always produces some cxx11 symbols even if we build with old ABI,
|
|
# and CuDNN always has pre-cxx11 symbols even if we build with new ABI using gcc 5.4.
|
|
# Instead, we *only* check the above symbols in the following namespaces:
|
|
LIBTORCH_NAMESPACE_LIST = (
|
|
"c10::",
|
|
"at::",
|
|
"caffe2::",
|
|
"torch::",
|
|
)
|
|
|
|
# Patterns for detecting statically linked libstdc++ symbols
|
|
STATICALLY_LINKED_CXX11_ABI = [re.compile(r".*recursive_directory_iterator.*")]
|
|
|
|
|
|
def _apply_libtorch_symbols(symbols):
|
|
return [
|
|
re.compile(f"{x}.*{y}")
|
|
for (x, y) in itertools.product(LIBTORCH_NAMESPACE_LIST, symbols)
|
|
]
|
|
|
|
|
|
LIBTORCH_CXX11_PATTERNS = _apply_libtorch_symbols(CXX11_SYMBOLS)
|
|
|
|
LIBTORCH_PRE_CXX11_PATTERNS = _apply_libtorch_symbols(PRE_CXX11_SYMBOLS)
|
|
|
|
|
|
@functools.lru_cache(100)
|
|
def get_symbols(lib: str) -> list[tuple[str, str, str]]:
|
|
from subprocess import check_output
|
|
|
|
lines = check_output(f'nm "{lib}"|c++filt', shell=True)
|
|
return [x.split(" ", 2) for x in lines.decode("latin1").split("\n")[:-1]]
|
|
|
|
|
|
def grep_symbols(
|
|
lib: str, patterns: list[Any], symbol_type: str | None = None
|
|
) -> list[str]:
|
|
def _grep_symbols(
|
|
symbols: list[tuple[str, str, str]], patterns: list[Any]
|
|
) -> list[str]:
|
|
rc = []
|
|
for _s_addr, _s_type, s_name in symbols:
|
|
# Filter by symbol type if specified
|
|
if symbol_type and _s_type != symbol_type:
|
|
continue
|
|
for pattern in patterns:
|
|
if pattern.match(s_name):
|
|
rc.append(s_name)
|
|
continue
|
|
return rc
|
|
|
|
all_symbols = get_symbols(lib)
|
|
num_workers = 32
|
|
chunk_size = (len(all_symbols) + num_workers - 1) // num_workers
|
|
|
|
def _get_symbols_chunk(i):
|
|
return all_symbols[i * chunk_size : (i + 1) * chunk_size]
|
|
|
|
with concurrent.futures.ThreadPoolExecutor(max_workers=32) as executor:
|
|
tasks = [
|
|
executor.submit(_grep_symbols, _get_symbols_chunk(i), patterns)
|
|
for i in range(num_workers)
|
|
]
|
|
return functools.reduce(list.__add__, (x.result() for x in tasks), [])
|
|
|
|
|
|
def check_lib_statically_linked_libstdc_cxx_abi_symbols(lib: str) -> None:
|
|
cxx11_statically_linked_symbols = grep_symbols(
|
|
lib, STATICALLY_LINKED_CXX11_ABI, symbol_type="T"
|
|
)
|
|
num_statically_linked_symbols = len(cxx11_statically_linked_symbols)
|
|
print(f"num_statically_linked_symbols (T): {num_statically_linked_symbols}")
|
|
if num_statically_linked_symbols > 0:
|
|
raise RuntimeError(
|
|
f"Found statically linked libstdc++ symbols (recursive_directory_iterator): {cxx11_statically_linked_symbols[:100]}"
|
|
)
|
|
|
|
|
|
def check_lib_symbols_for_abi_correctness(lib: str) -> None:
|
|
print(f"lib: {lib}")
|
|
cxx11_symbols = grep_symbols(lib, LIBTORCH_CXX11_PATTERNS)
|
|
pre_cxx11_symbols = grep_symbols(lib, LIBTORCH_PRE_CXX11_PATTERNS)
|
|
num_cxx11_symbols = len(cxx11_symbols)
|
|
num_pre_cxx11_symbols = len(pre_cxx11_symbols)
|
|
print(f"num_cxx11_symbols: {num_cxx11_symbols}")
|
|
print(f"num_pre_cxx11_symbols: {num_pre_cxx11_symbols}")
|
|
if num_pre_cxx11_symbols > 0:
|
|
raise RuntimeError(
|
|
f"Found pre-cxx11 symbols, but there shouldn't be any, see: {pre_cxx11_symbols[:100]}"
|
|
)
|
|
if num_cxx11_symbols < 100:
|
|
raise RuntimeError("Didn't find enough cxx11 symbols")
|
|
|
|
|
|
def main() -> None:
|
|
if "install_root" in os.environ:
|
|
install_root = Path(os.getenv("install_root")) # noqa: SIM112
|
|
else:
|
|
if os.getenv("PACKAGE_TYPE") == "libtorch":
|
|
install_root = Path(os.getcwd())
|
|
else:
|
|
install_root = Path(distutils.sysconfig.get_python_lib()) / "torch"
|
|
|
|
libtorch_cpu_path = str(install_root / "lib" / "libtorch_cpu.so")
|
|
check_lib_symbols_for_abi_correctness(libtorch_cpu_path)
|
|
check_lib_statically_linked_libstdc_cxx_abi_symbols(libtorch_cpu_path)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|