mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 12:54:11 +08:00
36ac095ff8
With CUDA-10.2 gone we can finally do it!
This PR mostly contains build system related changes, invasive functional ones are to be followed.
Among many expected tweaks to the build system, here are few unexpected ones:
- Force onnx_proto project to be updated to C++17 to avoid `duplicate symbols` error when compiled by gcc-7.5.0, as storage rule for `constexpr` changed in C++17, but gcc does not seem to follow it
- Do not use `std::apply` on CUDA but rely on the built-in variant, as it results in test failures when CUDA runtime picks host rather than device function when `std::apply` is invoked from CUDA code.
- `std::decay_t` -> `::std::decay_t` and `std::move`->`::std::move` as VC++ for some reason claims that `std` symbol is ambigious
- Disable use of `std::aligned_alloc` on Android, as its `libc++` does not implement it.
Some prerequisites:
- https://github.com/pytorch/pytorch/pull/89297
- https://github.com/pytorch/pytorch/pull/89605
- https://github.com/pytorch/pytorch/pull/90228
- https://github.com/pytorch/pytorch/pull/90389
- https://github.com/pytorch/pytorch/pull/90379
- https://github.com/pytorch/pytorch/pull/89570
- https://github.com/facebookincubator/gloo/pull/336
- https://github.com/facebookincubator/gloo/pull/343
- 919676fb32
Fixes https://github.com/pytorch/pytorch/issues/56055
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85969
Approved by: https://github.com/ezyang, https://github.com/kulinseth
21 lines
611 B
CMake
21 lines
611 B
CMake
# Basic CMake setup
|
|
cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
|
|
project(custom_ops)
|
|
|
|
if(USE_ROCM)
|
|
include(utils)
|
|
include(LoadHIP)
|
|
endif()
|
|
find_package(Torch REQUIRED)
|
|
|
|
add_library(custom_ops SHARED op.cpp)
|
|
set_property(TARGET custom_ops PROPERTY CXX_STANDARD 17)
|
|
|
|
target_compile_features(custom_ops PUBLIC cxx_range_for)
|
|
target_link_libraries(custom_ops "${TORCH_LIBRARIES}")
|
|
target_compile_definitions(custom_ops PRIVATE custom_ops_EXPORTS)
|
|
|
|
add_executable(test_custom_ops test_custom_ops.cpp)
|
|
set_property(TARGET test_custom_ops PROPERTY CXX_STANDARD 17)
|
|
target_link_libraries(test_custom_ops custom_ops)
|