mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
dfcaedeb1a
Summary: Fixing clang-format errors using `arc f` Changes already in github included https://github.com/pytorch/pytorch/pull/68460 Test Plan: test run in Signals Reviewed By: osalpekar Differential Revision: D35649381 fbshipit-source-id: 15f9cc7259c6425a14d2646200008f15ec47cbf0 (cherry picked from commit 6581afe58afae4dcc34d4024499c6cb61a56b448)
Note [TH abstraction violation] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ TH/THC provide some hpp headers, which are proper C++ headers rather than C headers. These headers serve double duty as *internal implementation detail* headers, whose contents should largely not be used by external clients. Ideally, we would not install these headers at all; instead, you should use public functions (in headers like `THTensor.h`, NOT `THTensor.hpp`) to manipulate these structs. However, there are a few places in torch/csrc where we violate this abstraction. They are marked with a pointer to this note. Each of those sites will have to be refactored when we refactor the guts of THTensor and related structures.