mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 12:54:11 +08:00
2994dd6377
Summary: When trying to build caffe2 with python provided by homebrew, I find out there are some errors in the building scripts. The "get_python_cmake_flags.py" script is supposed to find out the correct python library and header file locations. However, due to these errors, this script does not function correctly. After building, caffe2 is linked against the default python library provided by Apple which causes a crash when trying to validate whether or not the installation is successful: ```shell python -c 'from caffe2.python import core' 2>/dev/null && echo "Success" || echo "Failure" ``` The fix is as simple as follows: - Add "shell" so that command substitution could work under Makefile. - Add blank spaces between -D options so that they are treated as options not makefile targets. - Print the "flags" variable without the newline character so that they could be utilized by command substitution correctly. Closes https://github.com/caffe2/caffe2/pull/391 Differential Revision: D4943212 Pulled By: Yangqing fbshipit-source-id: 04d3595fa2d89fe57aed5b6a7a91a95114a82a1b
44 lines
1.3 KiB
Python
44 lines
1.3 KiB
Python
## @package get_python_cmake_flags
|
|
# Module scripts.get_python_cmake_flags
|
|
##############################################################################
|
|
# Use this script to find your preferred python installation.
|
|
##############################################################################
|
|
#
|
|
# You can use the following to build with your preferred version of python
|
|
# if your installation is not being properly detected by CMake.
|
|
#
|
|
# mkdir -p build && cd build
|
|
# cmake $(python ../scripts/get_python_libs.py) ..
|
|
# make
|
|
#
|
|
|
|
from __future__ import absolute_import
|
|
from __future__ import unicode_literals
|
|
from __future__ import print_function
|
|
from distutils import sysconfig
|
|
import os
|
|
import sys
|
|
import platform
|
|
|
|
version = platform.python_version()
|
|
if version[:3] != '2.7':
|
|
print('ERROR: Python {version} is not officially supported yet.'
|
|
.format(version=version), file=sys.stderr)
|
|
exit(1)
|
|
|
|
# Flags to print to stdout
|
|
flags = ''
|
|
inc = sysconfig.get_python_inc()
|
|
lib = sysconfig.get_config_var("LIBDIR")
|
|
|
|
# macOS specific
|
|
if sys.platform == "darwin":
|
|
lib = os.path.dirname(lib) + '/Python'
|
|
if os.path.isfile(lib):
|
|
flags += '-DPYTHON_LIBRARY={lib} '.format(lib=lib)
|
|
|
|
if os.path.isfile(inc + '/Python.h'):
|
|
flags += '-DPYTHON_INCLUDE_DIR={inc} '.format(inc=inc)
|
|
|
|
print(flags, end='')
|