pytorch

mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 12:54:11 +08:00

Files

Xuehai Pan 7837a12474 [BE] enforce style for empty lines in import segments (#129751 )

This PR follows https://github.com/pytorch/pytorch/pull/129374#pullrequestreview-2136555775 cc @malfet:

> Lots of formatting changes unrelated to PR goal, please keep them as part of separate PR (and please add lint rule if you want to enforce those, or at least cite one)

`usort` allows empty lines within import segments. For example, `usort` do not change the following code:

```python
import torch.aaa
import torch.bbb
import torch.ccc

x = ...  # some code
```

```python
import torch.aaa

import torch.bbb
import torch.ccc

x = ...  # some code
```

```python
import torch.aaa

import torch.bbb

import torch.ccc

x = ...  # some code
```

This PR first sort imports via `isort`, then re-sort the file using `ufmt` (`usort` + `black`). This enforces the following import style:

1. no empty lines within segments.
2. single empty line between segments.
3. two spaces after import statements.

All the code snippets above will be formatted to:

```python
import torch.aaa
import torch.bbb
import torch.ccc

x = ...  # some code
```

which produces a consistent code style.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/129751
Approved by: https://github.com/malfet

2024-06-29 14:15:24 +00:00

analyze

Flip default value for mypy disallow_untyped_defs [9/11] (#127846 )

2024-06-08 18:50:06 +00:00

__init__.py

Revert D35423079: [pkg] add generic ZipFile Reader/Writer

2022-04-07 13:33:47 +00:00

_digraph.py

Flip default value for mypy disallow_untyped_defs [8/11] (#127845 )

2024-06-08 18:49:56 +00:00

_directory_reader.py

Flip default value for mypy disallow_untyped_defs [8/11] (#127845 )