Laith Sakka 15c8bdcc5e Fix FloorDiv should not generate non integer rationals (due to sympy bug) (#164398) ...

FloorDiv eval have this optimization
```
  # Expands (x + y) // b into x // b + y // b.
  # This only works if floor is an identity, i.e. x / b is an integer.
 ```

 Before this PR this optimization would generate a result in an expression like this. Duo to a bug in sympy.
 ```
Mul(Rational(1, 22), Add(Mul(Integer(24), Symbol('s37', integer=True, positive=True)), Integer(672)), FloorDiv(Mul(Symbol('s14', integer=True, positive=True), Symbol('s46', integer=True, positive=True)), Integer(2016)))
 ```

 This is because in sympy an expression can have .is_integer =True yet have 1/22 in it!
 This PR ensure we do not generate that by simply opting out if this optimization if we end
 up with quotient that have such rational.

  Fix
  https://github.com/pytorch/pytorch/issues/164385,
  https://github.com/pytorch/pytorch/issues/154996
  https://github.com/pytorch/pytorch/issues/153375
  https://github.com/pytorch/pytorch/issues/164063
and internal user issue.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164398
Approved by: https://github.com/jansel, https://github.com/isuruf

2025-10-02 22:51:03 +00:00

..

_strobelight

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_sympy

Fix FloorDiv should not generate non integer rationals (due to sympy bug) (#164398)

2025-10-02 22:51:03 +00:00

backcompat

pyfmt lint more torch/utils files (#155812)

2025-06-12 23:51:42 +00:00

benchmark

Remove unnecessary list comprehensions (#164103)

2025-09-30 03:56:54 +00:00

data

[1/N] Fix ruff warnings (#164333)

2025-10-01 16:48:32 +00:00

hipify

[amd] Add cudaHostFn_t to cuda_to_hip_mappings (#164007)

2025-09-27 06:09:50 +00:00

jit

PEP585 update - torch/utils (#145201)

2025-01-21 21:04:10 +00:00

model_dump

[Pyrefly][Refactor] Replace dict() calls with literal dict syntax for improved readability (#157735)

2025-07-08 18:10:33 +00:00

serialization

Make record/storage alignment in torch.save configurable (#147788)

2025-03-06 12:04:46 +00:00

tensorboard

[1/N] Fix ruff warnings (#164333)

2025-10-01 16:48:32 +00:00

viz

[BE] fix remaining flake8 v7 warnings (#159044)

2025-07-25 02:56:34 +00:00

__init__.py

[BE] remove torch deploy - conditionals (#158288)

2025-07-29 17:40:49 +00:00

_appending_byte_serializer.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_config_module.py

[Fix] Adding missing f prefixes to formatted strings [2/N] (#164066)

2025-09-29 04:40:44 +00:00

_config_typing.pyi

inductor codecache: include private inductor configs in cache key (#153672)

2025-06-11 01:33:24 +00:00

_content_store.py

Revert "Use the device interface for detecting Triton availability (#139171)"

2025-03-11 18:49:21 +00:00

_contextlib.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_cpp_embed_headers.py

[Fix] Adding missing f prefixes to formatted strings [2/N] (#164066)

2025-09-29 04:40:44 +00:00

_cpp_extension_versioner.py

pyfmt lint more torch/utils files (#155812)

2025-06-12 23:51:42 +00:00

_cxx_pytree.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_debug_mode.py

DebugMode add ignore_compile_internals (#164205)

2025-10-02 07:39:54 +00:00

_device.py

[BE][16/16] fix typos in torch/ (torch/utils/) (#156606)

2025-07-02 22:55:29 +00:00

_dtype_abbrs.py

[BE] Migrate dtype_abbrs into one location (#152229)

2025-04-28 03:52:47 +00:00

_exposed_in.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_filelock.py

filelock: Make waitcounter variant to use (#139816)

2024-12-12 01:18:34 +00:00

_foreach_utils.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_functools.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_get_clean_triton.py

[BE]Enhance _get_clean_triton.py to auto-generate launch_params if missing (#154666)

2025-05-31 19:27:56 +00:00

_helion.py

Migrate from lru_cache to cache (#155613)

2025-06-11 19:44:18 +00:00

_import_utils.py

[BE] remove torch deploy - conditionals (#158288)

2025-07-29 17:40:49 +00:00

_mode_utils.py

pyfmt lint more torch/utils files (#155812)

2025-06-12 23:51:42 +00:00

_ordered_set.py

[typing] Constrain OrderedSet generic to be Hashable (#159684)

2025-08-04 18:08:01 +00:00

_python_dispatch.py

[BE] Slight improvements to documentation in python_dispatch (#162963)

2025-09-21 01:45:46 +00:00

_pytree.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_stats.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_thunk.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

_traceback.py

pyfmt lint more torch/utils files (#155812)

2025-06-12 23:51:42 +00:00

_triton.py

Workaround for mtia double init issue in has_triton (#162974)

2025-09-16 04:46:11 +00:00

_typing_utils.py

Revert "Fix type annotation of Linear.bias (#142326)"

2025-01-26 03:41:00 +00:00

_zip.py

pyfmt lint more torch/utils files (#155812)

2025-06-12 23:51:42 +00:00

backend_registration.py

Add functions to setup PrivateUse1 as a python backend device. (#157859)

2025-10-01 21:32:59 +00:00

bundled_inputs.py

[2/N] Apply ruff UP035 check in torch files (#164054)

2025-09-29 03:35:32 +00:00

checkpoint.py

Add early_stop kwarg to torch.utils.checkpoint (#160781)

2025-08-26 22:32:35 +00:00

collect_env.py

[BE] remove torch deploy - conditionals (#158288)

2025-07-29 17:40:49 +00:00

cpp_backtrace.py

Flip default value for mypy disallow_untyped_defs [9/11] (#127846)

2024-06-08 18:50:06 +00:00

cpp_extension.py

[aoti] AOTI mingw cross compilation (#163188)

2025-10-01 02:22:06 +00:00

deterministic.py

Flip default value for mypy disallow_untyped_defs [9/11] (#127846)

2024-06-08 18:50:06 +00:00

dlpack.py

[DLPack] Add support for missing keyword-arguments. (#150218)

2025-07-20 00:46:20 +00:00

file_baton.py

Warn user of existing lock file to avoid infinite waiting (#149382)

2025-04-15 20:25:29 +00:00

flop_counter.py

[1/N] Simplify "in" operation for containers of a single item (#164224)

2025-09-30 19:59:43 +00:00

hooks.py

Add warning for module full backward hook when no input requires gradient (#155339)

2025-06-10 04:42:06 +00:00

mkldnn.py

Flip default value for mypy disallow_untyped_defs [10/11] (#127847)

2024-06-08 18:50:06 +00:00

mobile_optimizer.py

PEP585 update - torch/utils (#145201)

2025-01-21 21:04:10 +00:00

model_zoo.py

…

module_tracker.py

[BE][PYFMT] migrate PYFMT for torch/[p-z]*/ to ruff format (#144552)

2025-08-07 00:09:56 +00:00

show_pickle.py

Use typing.IO[bytes] instead of io.BytesIO in annotations (#144994)

2025-01-27 18:08:07 +00:00

throughput_benchmark.py

Flip default value for mypy disallow_untyped_defs [10/11] (#127847)

2024-06-08 18:50:06 +00:00

weak.py

Fix compilation and "import torch" issues for cpython 3.14 (#158184)

2025-07-15 05:06:55 +00:00