Files
pytorch/test/cpp/api/memory.cpp
Nikita Shulga a9b0a921d5 Disable avoid-non-const-global-variables lint check (#62008)
Summary:
As GoogleTest `TEST` macro is non-compliant with it as well as `DEFINE_DISPATCH`

All changes but the ones to `.clang-tidy` are generated using following script:
```
for i in `find . -type f -iname "*.c*" -or -iname "*.h"|xargs grep cppcoreguidelines-avoid-non-const-global-variables|cut -f1 -d:|sort|uniq`;  do sed -i "/\/\/ NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)/d" $i; done
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/62008

Reviewed By: driazati, r-barnes

Differential Revision: D29838584

Pulled By: malfet

fbshipit-source-id: 1b2f8602c945bd4ce50a9bfdd204755556e31d13
2021-07-22 18:04:40 -07:00

38 lines
1022 B
C++

#include <gtest/gtest.h>
#include <torch/csrc/utils/memory.h>
#include <c10/util/Optional.h>
struct TestValue {
explicit TestValue(const int& x) : lvalue_(x) {}
explicit TestValue(int&& x) : rvalue_(x) {}
c10::optional<int> lvalue_;
c10::optional<int> rvalue_;
};
TEST(MakeUniqueTest, ForwardRvaluesCorrectly) {
auto ptr = torch::make_unique<TestValue>(123);
ASSERT_FALSE(ptr->lvalue_.has_value());
ASSERT_TRUE(ptr->rvalue_.has_value());
ASSERT_EQ(*ptr->rvalue_, 123);
}
TEST(MakeUniqueTest, ForwardLvaluesCorrectly) {
int x = 5;
auto ptr = torch::make_unique<TestValue>(x);
ASSERT_TRUE(ptr->lvalue_.has_value());
ASSERT_EQ(*ptr->lvalue_, 5);
ASSERT_FALSE(ptr->rvalue_.has_value());
}
TEST(MakeUniqueTest, CanConstructUniquePtrOfArray) {
// NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
auto ptr = torch::make_unique<int[]>(3);
// Value initialization is required by the standard.
ASSERT_EQ(ptr[0], 0);
ASSERT_EQ(ptr[1], 0);
ASSERT_EQ(ptr[2], 0);
}