mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
### MOTIVATION To generalize Distributed test cases for non-CUDA devices ### CHANGES - test/distributed/optim/test_zero_redundancy_optimizer.py - test/distributed/test_c10d_logger.py - test/distributed/test_compute_comm_reordering.py Replaced hard coded device names with get_devtype from torch.testing._internal.common_fsdp. DistributedTestBase is used instead of MultiProcessTestCase, to make use of helper functions. - torch/testing/_internal/common_distributed.py extended common utility functions Pull Request resolved: https://github.com/pytorch/pytorch/pull/152471 Approved by: https://github.com/d4l3k
134 lines
4.4 KiB
Python
134 lines
4.4 KiB
Python
# Owner(s): ["oncall: distributed"]
|
|
|
|
import json
|
|
import logging
|
|
import re
|
|
import sys
|
|
from functools import partial, wraps
|
|
|
|
import torch
|
|
import torch.distributed as dist
|
|
from torch.distributed.c10d_logger import _c10d_logger, _exception_logger
|
|
|
|
|
|
if not dist.is_available():
|
|
print("Distributed not available, skipping tests", file=sys.stderr)
|
|
sys.exit(0)
|
|
|
|
from torch.testing._internal.common_distributed import DistributedTestBase, TEST_SKIPS
|
|
from torch.testing._internal.common_fsdp import get_devtype
|
|
from torch.testing._internal.common_utils import run_tests, TEST_WITH_DEV_DBG_ASAN
|
|
|
|
|
|
device_type = str(get_devtype())
|
|
|
|
if TEST_WITH_DEV_DBG_ASAN:
|
|
print(
|
|
"Skip dev-asan as torch + multiprocessing spawn have known issues",
|
|
file=sys.stderr,
|
|
)
|
|
sys.exit(0)
|
|
|
|
WORLD_SIZE = min(4, max(2, torch.get_device_module(device_type).device_count()))
|
|
|
|
|
|
def with_comms(func=None):
|
|
if func is None:
|
|
return partial(
|
|
with_comms,
|
|
)
|
|
|
|
@wraps(func)
|
|
def wrapper(self, *args, **kwargs):
|
|
if torch.get_device_module(device_type).device_count() < self.world_size:
|
|
sys.exit(TEST_SKIPS[f"multi-gpu-{self.world_size}"].exit_code)
|
|
self.create_pg(device_type)
|
|
func(self)
|
|
self.destroy_comms()
|
|
|
|
return wrapper
|
|
|
|
|
|
class C10dErrorLoggerTest(DistributedTestBase):
|
|
@property
|
|
def world_size(self):
|
|
return WORLD_SIZE
|
|
|
|
@property
|
|
def process_group(self):
|
|
return dist.group.WORLD
|
|
|
|
def destroy_comms(self):
|
|
# Wait for all ranks to reach here before starting shutdown.
|
|
dist.barrier()
|
|
dist.destroy_process_group()
|
|
|
|
def test_get_or_create_logger(self):
|
|
self.assertIsNotNone(_c10d_logger)
|
|
self.assertEqual(1, len(_c10d_logger.handlers))
|
|
self.assertIsInstance(_c10d_logger.handlers[0], logging.NullHandler)
|
|
|
|
@_exception_logger
|
|
def _failed_broadcast_raise_exception(self):
|
|
tensor = torch.arange(2, dtype=torch.int64)
|
|
dist.broadcast(tensor, self.world_size + 1)
|
|
|
|
@_exception_logger
|
|
def _failed_broadcast_not_raise_exception(self):
|
|
try:
|
|
tensor = torch.arange(2, dtype=torch.int64)
|
|
dist.broadcast(tensor, self.world_size + 1)
|
|
except Exception:
|
|
pass
|
|
|
|
@with_comms
|
|
def test_exception_logger(self) -> None:
|
|
with self.assertRaises(Exception):
|
|
self._failed_broadcast_raise_exception()
|
|
|
|
with self.assertLogs(_c10d_logger, level="DEBUG") as captured:
|
|
self._failed_broadcast_not_raise_exception()
|
|
error_msg_dict = json.loads(
|
|
re.search("({.+})", captured.output[0]).group(0).replace("'", '"')
|
|
)
|
|
|
|
# NCCL adds additional nccl_version data to the error_msg_dict
|
|
if self.backend(device_type) == dist.Backend.NCCL:
|
|
self.assertEqual(len(error_msg_dict), 9)
|
|
else:
|
|
self.assertEqual(len(error_msg_dict), 8)
|
|
|
|
self.assertIn("pg_name", error_msg_dict.keys())
|
|
self.assertEqual("None", error_msg_dict["pg_name"])
|
|
|
|
self.assertIn("func_name", error_msg_dict.keys())
|
|
self.assertEqual("broadcast", error_msg_dict["func_name"])
|
|
|
|
self.assertIn("backend", error_msg_dict.keys())
|
|
self.assertEqual(self.backend(device_type), error_msg_dict["backend"])
|
|
|
|
if self.backend(device_type) == dist.Backend.NCCL:
|
|
self.assertIn("nccl_version", error_msg_dict.keys())
|
|
nccl_ver = torch.cuda.nccl.version()
|
|
self.assertEqual(
|
|
".".join(str(v) for v in nccl_ver), error_msg_dict["nccl_version"]
|
|
)
|
|
|
|
# In this test case, group_size = world_size, since we don't have multiple processes on one node.
|
|
self.assertIn("group_size", error_msg_dict.keys())
|
|
self.assertEqual(str(self.world_size), error_msg_dict["group_size"])
|
|
|
|
self.assertIn("world_size", error_msg_dict.keys())
|
|
self.assertEqual(str(self.world_size), error_msg_dict["world_size"])
|
|
|
|
self.assertIn("global_rank", error_msg_dict.keys())
|
|
self.assertIn(str(dist.get_rank()), error_msg_dict["global_rank"])
|
|
|
|
# In this test case, local_rank = global_rank, since we don't have multiple processes on one node.
|
|
self.assertIn("local_rank", error_msg_dict.keys())
|
|
self.assertIn(str(dist.get_rank()), error_msg_dict["local_rank"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
run_tests()
|