mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-21 13:44:15 +08:00
07669ed960
This is one of a series of PRs to update us to PEP585 (changing Dict -> dict, List -> list, etc). Most of the PRs were completely automated with RUFF as follows:
Since RUFF UP006 is considered an "unsafe" fix first we need to enable unsafe fixes:
```
--- a/tools/linter/adapters/ruff_linter.py
+++ b/tools/linter/adapters/ruff_linter.py
@@ -313,6 +313,7 @@
"ruff",
"check",
"--fix-only",
+ "--unsafe-fixes",
"--exit-zero",
*([f"--config={config}"] if config else []),
"--stdin-filename",
```
Then we need to tell RUFF to allow UP006 (as a final PR once all of these have landed this will be made permanent):
```
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -40,7 +40,7 @@
[tool.ruff]
-target-version = "py38"
+target-version = "py39"
line-length = 88
src = ["caffe2", "torch", "torchgen", "functorch", "test"]
@@ -87,7 +87,6 @@
"SIM116", # Disable Use a dictionary instead of consecutive `if` statements
"SIM117",
"SIM118",
- "UP006", # keep-runtime-typing
"UP007", # keep-runtime-typing
]
select = [
```
Finally running `lintrunner -a --take RUFF` will fix up the deprecated uses.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145101
Approved by: https://github.com/bobrenjc93
82 lines
2.5 KiB
Python
82 lines
2.5 KiB
Python
"""GitHub Utilities"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
from typing import Any, Callable, cast
|
|
from urllib.error import HTTPError
|
|
from urllib.parse import quote
|
|
from urllib.request import Request, urlopen
|
|
|
|
|
|
def gh_fetch_url_and_headers(
|
|
url: str,
|
|
*,
|
|
headers: dict[str, str] | None = None,
|
|
data: dict[str, Any] | None = None,
|
|
method: str | None = None,
|
|
reader: Callable[[Any], Any] = lambda x: x.read(),
|
|
) -> tuple[Any, Any]:
|
|
if headers is None:
|
|
headers = {}
|
|
token = os.environ.get("GITHUB_TOKEN")
|
|
if token is not None and url.startswith("https://api.github.com/"):
|
|
headers["Authorization"] = f"token {token}"
|
|
data_ = json.dumps(data).encode() if data is not None else None
|
|
try:
|
|
with urlopen(Request(url, headers=headers, data=data_, method=method)) as conn:
|
|
return conn.headers, reader(conn)
|
|
except HTTPError as err:
|
|
if err.code == 403 and all(
|
|
key in err.headers for key in ["X-RateLimit-Limit", "X-RateLimit-Used"]
|
|
):
|
|
print(
|
|
f"""Rate limit exceeded:
|
|
Used: {err.headers['X-RateLimit-Used']}
|
|
Limit: {err.headers['X-RateLimit-Limit']}
|
|
Remaining: {err.headers['X-RateLimit-Remaining']}
|
|
Resets at: {err.headers['x-RateLimit-Reset']}"""
|
|
)
|
|
raise
|
|
|
|
|
|
def gh_fetch_url(
|
|
url: str,
|
|
*,
|
|
headers: dict[str, str] | None = None,
|
|
data: dict[str, Any] | None = None,
|
|
method: str | None = None,
|
|
reader: Callable[[Any], Any] = lambda x: x.read(),
|
|
) -> Any:
|
|
return gh_fetch_url_and_headers(
|
|
url, headers=headers, data=data, reader=json.load, method=method
|
|
)[1]
|
|
|
|
|
|
def _gh_fetch_json_any(
|
|
url: str,
|
|
params: dict[str, Any] | None = None,
|
|
data: dict[str, Any] | None = None,
|
|
) -> Any:
|
|
headers = {"Accept": "application/vnd.github.v3+json"}
|
|
if params is not None and len(params) > 0:
|
|
url += "?" + "&".join(
|
|
f"{name}={quote(str(val))}" for name, val in params.items()
|
|
)
|
|
return gh_fetch_url(url, headers=headers, data=data, reader=json.load)
|
|
|
|
|
|
def gh_fetch_json_dict(
|
|
url: str,
|
|
params: dict[str, Any] | None = None,
|
|
data: dict[str, Any] | None = None,
|
|
) -> dict[str, Any]:
|
|
return cast(dict[str, Any], _gh_fetch_json_any(url, params, data))
|
|
|
|
|
|
def gh_fetch_commit(org: str, repo: str, sha: str) -> dict[str, Any]:
|
|
return gh_fetch_json_dict(
|
|
f"https://api.github.com/repos/{org}/{repo}/commits/{sha}"
|
|
)
|