Files
pytorch/torch/csrc/copy_utils.h
Mike Guo 6ecc1a4c4f Make pytorch clang-tidy clean (#60649)
Summary:
This PR suppresses clang-tidy warnings in the codebase (for now) so that we can re-enable clang-tidy checks on master.

I ran this script to add the `NOLINTNEXTLINE` comments (on a devserver):
```bash
python3 setup.py develop

# Uses same script that's run on CI and adds the -j (parallel), -s (add comments), -k (continue if diagnostic errors are found) options
python3 tools/clang_tidy.py \
  -j \
  -s \
  -k \
  -v \
  --paths torch/csrc/ \
  -g"-torch/csrc/jit/passes/onnx/helper.cpp" \
  -g"-torch/csrc/jit/passes/onnx/shape_type_inference.cpp" \
  -g"-torch/csrc/jit/serialization/onnx.cpp" \
  -g"-torch/csrc/jit/serialization/export.cpp" \
  -g"-torch/csrc/jit/serialization/import.cpp" \
  -g"-torch/csrc/jit/serialization/import_legacy.cpp" \
  -g"-torch/csrc/onnx/init.cpp" \
  -g"-torch/csrc/cuda/nccl.*" \
  -g"-torch/csrc/cuda/python_nccl.cpp" \
  -g"-torch/csrc/autograd/FunctionsManual.cpp" \
  -g"-torch/csrc/generic/*.cpp" \
  -g"-torch/csrc/jit/codegen/cuda/runtime/*" \
  -g"-torch/csrc/deploy/interpreter/interpreter.cpp" \
  -g"-torch/csrc/deploy/interpreter/interpreter.h" \
  -g"-torch/csrc/deploy/interpreter/interpreter_impl.h" \
  -g"-torch/csrc/deploy/interpreter/test_main.cpp"
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/60649

Test Plan: Verified changes by re-running the script (without the `-s` option) and seeing no warnings/errors.

Reviewed By: walterddr, janeyx99

Differential Revision: D29504258

Pulled By: 1ntEgr8

fbshipit-source-id: 78310b30ee8213b73ddb4771ad874665323e7a4e
2021-07-01 12:21:07 -07:00

86 lines
2.6 KiB
C++

#pragma once
#include <functional>
#include <vector>
#include <torch/csrc/Types.h>
typedef std::function<void(PyObject*, PyObject*, bool)> THPCopyFunction;
// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
struct THPCopyInfo {
PyTypeObject* srcType; // Python type of src tensor/storage
THPCopyFunction copy; // copy function
bool non_blocking; // true if copy implements an 'non_blocking' copy
bool broadcast; // true if the copy implements a broadcast copy
};
typedef std::vector<THPCopyInfo> THPCopyList;
inline bool tryTHPCopy(const THPCopyList& v, PyObject* dst, PyObject* src, bool non_blocking, bool broadcast)
{
for (auto& i : v) {
if (i.non_blocking == non_blocking && PyType_IsSubtype(Py_TYPE(src), i.srcType)) {
(i.copy)(dst, src, broadcast);
return true;
}
}
return false;
}
inline bool THPCopy(const THPCopyList& v, PyObject* dst, PyObject* src, bool non_blocking, bool broadcast)
{
// NOLINTNEXTLINE(bugprone-branch-clone)
if (tryTHPCopy(v, dst, src, non_blocking, broadcast)) {
return true;
} else if (non_blocking && tryTHPCopy(v, dst, src, false, broadcast)) {
return true;
}
THPUtils_setError("copy from %s to %s isn't implemented",
THPUtils_typename(src), THPUtils_typename(dst));
return false;
}
inline PyObject * THPStorageCopyMethod(const THPCopyList& v, PyObject *self, PyObject *args, PyObject *kwargs)
{
// NOLINTNEXTLINE(cppcoreguidelines-init-variables)
PyObject *src;
int non_blocking = 0;
static std::array<char*, 3> kwlist = {"source", "non_blocking", nullptr};
// use int as parse type because bool not available in python2.
if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O|i:copy_", kwlist.data(), &src, &non_blocking)) {
return nullptr;
}
if (!THPCopy(v, self, src, non_blocking, false)) {
return nullptr;
}
Py_INCREF(self);
return self;
}
template <typename THPStorageDst, typename THPStorageSrc, typename StorageDst, typename StorageSrc>
void THPInsertStorageCopyFunction(
PyTypeObject *srcType,
THPCopyList& copyList,
void (*copyFunc)(LIBRARY_STATE_TYPE StorageDst* x, StorageSrc* z),
bool non_blocking=false)
{
auto wrapper = [copyFunc](PyObject* dst_, PyObject* src_, bool broadcast) {
auto dst = ((THPStorageDst*)dst_)->cdata;
auto src = ((THPStorageSrc*)src_)->cdata;
PyThreadState *_save = nullptr;
try {
Py_UNBLOCK_THREADS;
copyFunc(LIBRARY_STATE dst, src);
Py_BLOCK_THREADS;
} catch (...) {
if (_save) {
Py_BLOCK_THREADS;
}
throw;
}
};
copyList.push_back({ srcType, wrapper, non_blocking, false });
}