Files
cyy 8fa81a6066 Enable misc-use-internal-linkage check and apply fixes (#148948)
Enables clang-tidy rule [`misc-use-internal-linkage`](https://clang.llvm.org/extra/clang-tidy/checks/misc/use-internal-linkage.html). This new check was introduced in Clang-Tidy 18 and is available due to recent update of Clang-Tidy 19.

The check marks functions and variables used only in the translation unit as static. Therefore undesired symbols are not leaked into other units, more link time optimisations are possible and the resulting binaries may be smaller.

The detected violations were mostly fixed by using static. In other cases, the symbols were indeed consumed by others files, then their declaring headers were included. Still some declarations were wrong and have been fixed.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/148948
Approved by: https://github.com/Skylion007
2025-03-12 14:22:56 +00:00

88 lines
2.1 KiB
C++

#include <c10/util/thread_name.h>
#include <torch/csrc/Exceptions.h>
#include <torch/csrc/multiprocessing/init.h>
#include <torch/csrc/python_headers.h>
#include <torch/csrc/utils/object_ptr.h>
#include <torch/csrc/utils/pybind.h>
#include <torch/csrc/utils/python_strings.h>
#include <initializer_list>
#include <stdexcept>
#if defined(__linux__)
#include <sys/prctl.h>
#endif
#define SYSASSERT(rv, ...) \
if ((rv) < 0) { \
throw std::system_error(errno, std::system_category(), ##__VA_ARGS__); \
}
namespace torch::multiprocessing {
namespace {
PyObject* multiprocessing_init(PyObject* _unused, PyObject* noargs) {
auto multiprocessing_module =
THPObjectPtr(PyImport_ImportModule("torch.multiprocessing"));
if (!multiprocessing_module) {
throw python_error();
}
auto module = py::handle(multiprocessing_module).cast<py::module>();
module.def("_prctl_pr_set_pdeathsig", [](int signal) {
#if defined(__linux__)
auto rv = prctl(PR_SET_PDEATHSIG, signal);
SYSASSERT(rv, "prctl");
#endif
});
Py_RETURN_TRUE;
}
PyObject* set_thread_name(PyObject* _unused, PyObject* arg) {
TORCH_CHECK(THPUtils_checkString(arg), "invalid argument to setDevice");
auto name = THPUtils_unpackString(arg);
c10::setThreadName(name);
Py_RETURN_TRUE;
}
PyObject* get_thread_name(PyObject* _unused, PyObject* noargs) {
return THPUtils_packString(c10::getThreadName());
}
} // namespace
// multiprocessing methods on torch._C
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
static std::initializer_list<PyMethodDef> methods = {
{
"_multiprocessing_init",
multiprocessing_init,
METH_NOARGS,
nullptr,
},
{
"_set_thread_name",
set_thread_name,
METH_O,
nullptr,
},
{
"_get_thread_name",
get_thread_name,
METH_NOARGS,
nullptr,
},
{nullptr, nullptr, 0, nullptr},
};
const PyMethodDef* python_functions() {
return std::data(methods);
}
} // namespace torch::multiprocessing