mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
b8fad785d5
Change trigger for auto format to be pull_request b/c the reusable action used gets the pr number from the pull_request event context, but only run it if ciflow/autoformat is attached to the PR. Tested this on a different PR, and it seems to be working Changed tag name because ciflow prefixed labels have special handling Also change to run on all files so it will mimic the normal CI lintrunner call, and because lintrunner, either by itself or using -m mergebase can miss some things. Idk if it would miss for format, but it does for checking lint. Format seems to take shorter than normal lint. I don't know if the comment about making suggestions on non edited file changes is a concern. I didn't really test this part Pull Request resolved: https://github.com/pytorch/pytorch/pull/153289 Approved by: https://github.com/atalman, https://github.com/malfet
43 lines
1.4 KiB
YAML
43 lines
1.4 KiB
YAML
name: Apply lint suggestions
|
|
|
|
on:
|
|
pull_request:
|
|
types: [opened, synchronize, reopened, labeled, unlabeled]
|
|
|
|
jobs:
|
|
lintrunner-autoformat:
|
|
permissions:
|
|
contents: read
|
|
pull-requests: write
|
|
runs-on: lf.linux.2xlarge
|
|
if: ${{ github.repository_owner == 'pytorch' && contains(github.event.pull_request.labels.*.name, 'autoformat') }}
|
|
steps:
|
|
- name: Checkout pytorch
|
|
uses: pytorch/pytorch/.github/actions/checkout-pytorch@main
|
|
with:
|
|
submodules: true
|
|
fetch-depth: 0
|
|
- name: Run lintrunner (nonretryable)
|
|
continue-on-error: true
|
|
run: |
|
|
set -ex
|
|
python3 -m venv /tmp/venv
|
|
source /tmp/venv/bin/activate
|
|
export ADDITIONAL_LINTRUNNER_ARGS="format --all-files"
|
|
bash .github/scripts/lintrunner.sh
|
|
- name: Check for changes
|
|
id: git-check
|
|
continue-on-error: true
|
|
run: |
|
|
git diff --exit-code || echo "changes=true" >> "$GITHUB_OUTPUT"
|
|
- name: Suggest changes
|
|
if: steps.git-check.outputs.changes == 'true'
|
|
continue-on-error: true
|
|
uses: parkerbxyz/suggest-changes@a2ec1653b0c4cc8287d682f0066dba4a173cc7f3 # v1.0.8
|
|
with:
|
|
comment: "Please commit the suggested changes from pytorch's linter."
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.event_name == 'workflow_dispatch' }}
|
|
cancel-in-progress: true
|