e4571e7025
Add abi flags to cpp_extension cache folder ( #136890 )
...
This is to avoid cache confusion between normal vs pydebug vs nogil builds in cpp extensions which can lead to catastrophic ABI issues.
This is rare today for people to run both normal and pydebug on the same machine, but we expect quite a few people will run normal and nogil on the same machine going forward.
This is tested locally by running each version alternatively.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136890
Approved by: https://github.com/colesbury
2024-09-28 00:49:56 +00:00
be4b7e8131
Param fixes in docstring ( #136097 )
...
Fixes wrong param names in docstrings. cc: @kit1980
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136097
Approved by: https://github.com/ezyang
2024-09-21 18:56:34 +00:00
67735d1ee8
[Inductor] Generalize is_cuda to specific device_type to make cpp_wrapper mode be extensible ( #134693 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/134693
Approved by: https://github.com/ezyang , https://github.com/EikanWang , https://github.com/jansel
2024-09-10 10:11:13 +00:00
585c049fa3
Fix Extension attribute name in CppExtension example ( #134046 )
...
Hi! It seems there's a typo in `CppExtension` example. I think it should say `extra_link_args` instead of `extra_link_flags`. Not that I spent a few hours debugging missing kernels inside a library's fatbin or anything :D.
Please see `Extension` definition inside setuptools:
ebddeb36f7/setuptools/_distutils/extension.py (L62)https://github.com/pytorch/pytorch/pull/134046
Approved by: https://github.com/soulitzer
2024-08-21 13:58:16 +00:00
42cd397a0e
Loads .pyd instead of .so in MemPool test for windows ( #132749 )
...
Fixes #132650
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132749
Approved by: https://github.com/albanD
2024-08-08 14:29:56 +00:00
123d9ec5bf
Revert "Loads .pyd instead of .so in MemPool test for windows ( #132749 )"
...
This reverts commit 37ab0f33854fafdf9bf4f575260329ffcd960d13.
Reverted https://github.com/pytorch/pytorch/pull/132749 on behalf of https://github.com/syed-ahmed due to Seems like periodic is still failing: 7c79e89bc5https://github.com/pytorch/pytorch/pull/132749#issuecomment-2274041302 ))
2024-08-07 18:08:44 +00:00
37ab0f3385
Loads .pyd instead of .so in MemPool test for windows ( #132749 )
...
Fixes #132650
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132749
Approved by: https://github.com/albanD
2024-08-07 09:58:52 +00:00
4d7bf72d93
[BE][Easy] fix ruff rule needless-bool (SIM103) ( #130206 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/130206
Approved by: https://github.com/malfet
2024-07-14 08:17:52 +00:00
b0e5c9514d
use shutil.which in check_compiler_ok_for_platform ( #129069 )
...
the same as https://github.com/pytorch/pytorch/pull/126060
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129069
Approved by: https://github.com/ezyang
2024-06-29 11:38:51 +00:00
b40a033c38
[cpp_extension][inductor] Fix sleef windows depends. ( #128770 )
...
# Issue:
During I'm working on enable inductor on PyTorch Windows, I found the sleef lib dependency issue.
<img width="1011" alt="image" src="https://github.com/pytorch/pytorch/assets/8433590/423bd854-3c5f-468f-9a64-a392d9b514e3 ">
# Analysis:
After we enabled SIMD on PyTorch Windows(https://github.com/pytorch/pytorch/pull/118980 ), the sleef functions are called from VEC headers. It bring the sleef to the dependency.
Here is a different between Windows and Linux OS.
## Linux :
Linux is default export its functions, so libtorch_cpu.so static link to sleef.a, and then It also export sleef's functions.
<img width="647" alt="image" src="https://github.com/pytorch/pytorch/assets/8433590/00ac536c-33fc-4943-a435-25590508840d ">
## Windows:
Windows is by default not export its functions, and have many limitation to export functions, reference: https://github.com/pytorch/pytorch/issues/80604
We can't package sleef functions via torch_cpu.dll like Linux.
# Solution:
Acturally, we also packaged sleef static lib as a part of release. We just need to help user link to sleef.lib, it should be fine.
1. Add sleef to cpp_builder for inductor.
2. Add sleef to cpp_extension for C++ extesion.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/128770
Approved by: https://github.com/jgong5 , https://github.com/jansel
2024-06-17 05:44:34 +00:00
8db9dfa2d7
Flip default value for mypy disallow_untyped_defs [9/11] ( #127846 )
...
See #127836 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127846
Approved by: https://github.com/ezyang
ghstack dependencies: #127842 , #127843 , #127844 , #127845
2024-06-08 18:50:06 +00:00
d44daebdbc
[Submodule] Remove deprecated USE_TBB option and TBB submodule ( #127051 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127051
Approved by: https://github.com/cpuhrsch , https://github.com/malfet
2024-05-31 01:20:45 +00:00
67739d8c6f
Revert "[Submodule] Remove deprecated USE_TBB option and TBB submodule ( #127051 )"
...
This reverts commit 699db7988d84d163ebb6919f78885e4630182a7a.
Reverted https://github.com/pytorch/pytorch/pull/127051 on behalf of https://github.com/PaliC due to This PR needs to be synced using the import button as there is a bug in our diff train ([comment](https://github.com/pytorch/pytorch/pull/127051#issuecomment-2138496995 ))
2024-05-30 01:16:57 +00:00
699db7988d
[Submodule] Remove deprecated USE_TBB option and TBB submodule ( #127051 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127051
Approved by: https://github.com/cpuhrsch , https://github.com/malfet
2024-05-29 11:58:03 +00:00
cdbb2c9acc
Revert "[Submodule] Remove deprecated USE_TBB option and TBB submodule ( #127051 )"
...
This reverts commit 4fdbaa794f9d5af2f171f772a51cb710c51c925f.
Reverted https://github.com/pytorch/pytorch/pull/127051 on behalf of https://github.com/PaliC due to This PR needs to be synced using the import button as there is a bug in our diff train ([comment](https://github.com/pytorch/pytorch/pull/127051#issuecomment-2136428735 ))
2024-05-29 03:02:35 +00:00
4fdbaa794f
[Submodule] Remove deprecated USE_TBB option and TBB submodule ( #127051 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127051
Approved by: https://github.com/cpuhrsch , https://github.com/malfet
2024-05-27 03:54:03 +00:00
e3c96935c2
Support CUDA_INC_PATH env variable when compiling extensions ( #126808 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126808
Approved by: https://github.com/amjames , https://github.com/ezyang
2024-05-22 02:44:32 +00:00
3183d65ac0
use shutil.which in _find_cuda_home ( #126060 )
...
Replace `subprocess.check_output` call with `shutil.which`, similarly to how this is done in `_find_rocm_home`
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126060
Approved by: https://github.com/r-barnes
2024-05-13 17:38:17 +00:00
ae9a4fa63c
[ROCm] enforce ROCM_VERSION >= 6.0 ( #125646 )
...
Remove any code relying on ROCM_VERSION < 6.0.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125646
Approved by: https://github.com/albanD , https://github.com/eqy
2024-05-12 18:01:28 +00:00
c941fee7ea
[CPP extention] Baton lock is called regardless the code version ( #125404 )
...
Greetings!
Fixes #125403
Please assist me with the testing as it is possible for my reproducer to miss the error in the code. Several (at least two) threads should enter the same part of the code at the same time to check file lock is actually working
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125404
Approved by: https://github.com/ezyang
2024-05-03 21:10:39 +00:00
35c493f2cf
[CPP Extension] Escape include paths ( #122974 )
...
By using `shlex.quote` on Linux/Mac and `_nt_quote_args` on Windows
Test it by adding non-existent path with spaces and single quote
TODO: Fix double quotes on Windows (will require touching `_nt_quote_args`, so will leave it for another day
Fixes https://github.com/pytorch/pytorch/issues/122476
Pull Request resolved: https://github.com/pytorch/pytorch/pull/122974
Approved by: https://github.com/Skylion007
2024-03-30 21:58:29 +00:00
8dd4b6a78c
Fix venv compatibility issue by updating python_lib_path ( #121103 )
...
Reference by sys.executable is the absolute path of the executable binary for the Python interpreter, which may not be appropriate. Instead, sys.base_exec_prefix is more suitable, and this change will correctly resolve the library when using venv. I have tested it with a venv created by rye.
https://docs.python.org/3.6/library/sys.html#sys.executable
> A string giving the absolute path of the executable binary for the Python interpreter, on systems where this makes sense. If Python is unable to retrieve the real path to its executable, [sys.executable](https://docs.python.org/3.6/library/sys.html#sys.executable ) will be an empty string or None.
https://docs.python.org/3.6/library/sys.html#sys.exec_prefix
> A string giving the site-specific directory prefix where the platform-dependent Python files are installed; by default, this is also '/usr/local'. This can be set at build time with the --exec-prefix argument to the configure script. Specifically, all configuration files (e.g. the pyconfig.h header file) are installed in the directory exec_prefix/lib/pythonX.Y/config, and shared library modules are installed in exec_prefix/lib/pythonX.Y/lib-dynload, where X.Y is the version number of Python, for example 3.2.
https://docs.python.org/3.6/library/sys.html#sys.base_exec_prefix
> Set during Python startup, before site.py is run, to the same value as [exec_prefix](https://docs.python.org/3.6/library/sys.html#sys.exec_prefix ). If not running in a [virtual environment](https://docs.python.org/3.6/library/venv.html#venv-def ), the values will stay the same; if site.py finds that a virtual environment is in use, the values of [prefix](https://docs.python.org/3.6/library/sys.html#sys.prefix ) and [exec_prefix](https://docs.python.org/3.6/library/sys.html#sys.exec_prefix ) will be changed to point to the virtual environment, whereas [base_prefix](https://docs.python.org/3.6/library/sys.html#sys.base_prefix ) and [base_exec_prefix](https://docs.python.org/3.6/library/sys.html#sys.base_exec_prefix ) will remain pointing to the base Python installation (the one which the virtual environment was created from).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/121103
Approved by: https://github.com/ezyang
2024-03-06 17:00:46 +00:00
3e382456c1
Fix compiler check ( #120492 )
...
Fixes #119304
1. Add try catch to handle the compiler version check.
2. Retry to query compiler version info.
3. Return False if can't get compiler info twice.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/120492
Approved by: https://github.com/ezyang
2024-02-25 02:41:20 +00:00
c83af673bc
Allow CUDA extension builds to skip generating cuda dependencies during compile time ( #119936 )
...
nvcc flag `--generate-dependencies-with-compile` doesn't seem to be supported by `sccache` for now. Builds with this flag enabled will not benefit from sccache.
This PR adds an environment variable that allows users to set this flag and skip those nvcc dependencies to speed up their build with compiler caches. If everything is "fresh build" in CI, we don't care if there are unnecessary recompile during incremental builds.
related: https://github.com/pytorch/pytorch/pull/49344
- [ ] todo: raise an issue to sccache
Pull Request resolved: https://github.com/pytorch/pytorch/pull/119936
Approved by: https://github.com/ezyang
2024-02-15 07:03:59 +00:00
7fd6b1c558
s/print/warn in arch choice in cpp extension ( #119463 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/119463
Approved by: https://github.com/malfet
2024-02-08 20:38:51 +00:00
46ef73505d
Clarify how to get extra link flags when building CUDA/C++ extension ( #118743 )
...
Make it a bit more explicit how one parse linker arguments to the build and point to the superclass documentation.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/118743
Approved by: https://github.com/ezyang
2024-02-01 22:35:25 +00:00
4f5785b6b3
Enable possibly-undefined error code ( #118533 )
...
Fixes https://github.com/pytorch/pytorch/issues/118129
Suppressions automatically added with
```
import re
with open("error_file.txt", "r") as f:
errors = f.readlines()
error_lines = {}
for error in errors:
match = re.match(r"(.*):(\d+):\d+: error:.*\[(.*)\]", error)
if match:
file_path, line_number, error_type = match.groups()
if file_path not in error_lines:
error_lines[file_path] = {}
error_lines[file_path][int(line_number)] = error_type
for file_path, lines in error_lines.items():
with open(file_path, "r") as f:
code = f.readlines()
for line_number, error_type in sorted(lines.items(), key=lambda x: x[0], reverse=True):
code[line_number - 1] = code[line_number - 1].rstrip() + f" # type: ignore[{error_type}]\n"
with open(file_path, "w") as f:
f.writelines(code)
```
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Co-authored-by: Catherine Lee <csl@fb.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/118533
Approved by: https://github.com/Skylion007 , https://github.com/zou3519
2024-01-30 21:07:01 +00:00
40ece2e579
Revert "Enable possibly-undefined error code ( #118533 )"
...
This reverts commit 4f13f69a45ef53747e2eefffd65d91ce840b431b.
Reverted https://github.com/pytorch/pytorch/pull/118533 on behalf of https://github.com/clee2000 due to sorry i'm trying to figure out a codev merge conflict, if this works i'll be back to rebase and merge ([comment](https://github.com/pytorch/pytorch/pull/118533#issuecomment-1917695185 ))
2024-01-30 19:00:34 +00:00
4f13f69a45
Enable possibly-undefined error code ( #118533 )
...
Fixes https://github.com/pytorch/pytorch/issues/118129
Suppressions automatically added with
```
import re
with open("error_file.txt", "r") as f:
errors = f.readlines()
error_lines = {}
for error in errors:
match = re.match(r"(.*):(\d+):\d+: error:.*\[(.*)\]", error)
if match:
file_path, line_number, error_type = match.groups()
if file_path not in error_lines:
error_lines[file_path] = {}
error_lines[file_path][int(line_number)] = error_type
for file_path, lines in error_lines.items():
with open(file_path, "r") as f:
code = f.readlines()
for line_number, error_type in sorted(lines.items(), key=lambda x: x[0], reverse=True):
code[line_number - 1] = code[line_number - 1].rstrip() + f" # type: ignore[{error_type}]\n"
with open(file_path, "w") as f:
f.writelines(code)
```
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/118533
Approved by: https://github.com/Skylion007 , https://github.com/zou3519
2024-01-30 05:08:10 +00:00
e6f3a4746c
include a print for _get_cuda_arch_flags ( #118503 )
...
Related to #118494 , it is not clear to users that the default behavior is to include **all** feasible archs (if the 'TORCH_CUDA_ARCH_LIST' is not set).
In these scenarios, a user may experience a long build time. Adding a print statement to reflect this behavior. [`verbose` arg is not available and not feeling necessary to add `verbose` arg to this function and all its parent functions...]
Co-authored-by: Edward Z. Yang <ezyang@mit.edu >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/118503
Approved by: https://github.com/ezyang
2024-01-29 07:03:56 +00:00
6c02520466
Remove unneeded comment and link for BuildExtension ( #115496 )
...
`BuildExtension` is no longer derived from object, but from `build_ext`. Py2 is also deprecated, so this comment wouldn't be required anyways
Pull Request resolved: https://github.com/pytorch/pytorch/pull/115496
Approved by: https://github.com/Skylion007
2024-01-01 08:29:48 +00:00
8bff59e41d
[ROCm] add hipblaslt support ( #114329 )
...
Disabled by default. Enable with env var DISABLE_ADDMM_HIP_LT=0. Tested on both ROCm 5.7 and 6.0.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/114329
Approved by: https://github.com/malfet
2023-12-20 19:09:25 +00:00
47908a608f
Revert "[ROCm] add hipblaslt support ( #114329 )"
...
This reverts commit b062ea38039234c80404a8f5f4d5a93c4cb9832d.
Reverted https://github.com/pytorch/pytorch/pull/114329 on behalf of https://github.com/jeanschmidt due to Reverting due to inconsistencies on internal diff ([comment](https://github.com/pytorch/pytorch/pull/114329#issuecomment-1861933267 ))
2023-12-19 01:04:58 +00:00
b062ea3803
[ROCm] add hipblaslt support ( #114329 )
...
Disabled by default. Enable with env var DISABLE_ADDMM_HIP_LT=0. Tested on both ROCm 5.7 and 6.0.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/114329
Approved by: https://github.com/malfet
2023-12-15 15:36:46 +00:00
59f7355f86
Revert "[ROCm] add hipblaslt support ( #114329 )"
...
This reverts commit bb2bb8cca1c00e3f6e7025a62688d0cfcbfee144.
Reverted https://github.com/pytorch/pytorch/pull/114329 on behalf of https://github.com/atalman due to OSSCI oncall, trunk tests are failing ([comment](https://github.com/pytorch/pytorch/pull/114329#issuecomment-1857003155 ))
2023-12-14 23:53:30 +00:00
bb2bb8cca1
[ROCm] add hipblaslt support ( #114329 )
...
Disabled by default. Enable with env var DISABLE_ADDMM_HIP_LT=0. Tested on both ROCm 5.7 and 6.0.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/114329
Approved by: https://github.com/malfet
2023-12-14 21:41:22 +00:00
a43c757275
Fixed error with cuda_ver in cpp_extension.py ( #113555 )
...
Reported in 71ca42787f (r132390833)https://github.com/pytorch/pytorch/pull/113555
Approved by: https://github.com/ezyang
2023-11-14 00:12:22 +00:00
5e10dd2c78
fix docstring issues in torch.utils ( #113335 )
...
Fixes #112634
Fixes all the issues listed except in `torch/utils/_pytree.py` as the file no longer exists.
### Error counts
|File | Count Before | Count now|
|---- | ---- | ---- |
|`torch/utils/collect_env.py` | 39 | 25|
|`torch/utils/cpp_extension.py` | 51 | 13|
|`torch/utils/flop_counter.py` | 25 | 8|
|`torch/utils/_foreach_utils.py.py` | 2 | 0|
|`torch/utils/_python_dispatch.py.py` | 26 | 25|
|`torch/utils/backend_registration.py` | 15 | 4|
|`torch/utils/checkpoint.py` | 29 | 21|
Pull Request resolved: https://github.com/pytorch/pytorch/pull/113335
Approved by: https://github.com/ezyang
2023-11-13 19:37:25 +00:00
0a7eef9bcf
[BE] Remove stale CUDA version check from cpp_extension.py ( #113447 )
...
As at least CUDA-11.x is needed to build PyTorch on latest trunk.
But still skip `--generate-dependencies-with-compile` if running on ROCm
Pull Request resolved: https://github.com/pytorch/pytorch/pull/113447
Approved by: https://github.com/Skylion007 , https://github.com/atalman , https://github.com/PaliC , https://github.com/huydhn
2023-11-11 00:20:08 +00:00
ae2c219de2
Revert "[BE] Remove stale CUDA version check from cpp_extension.py ( #113447 )"
...
This reverts commit 7ccca60927cdccde63d6a1d40480950f24e9877a.
Reverted https://github.com/pytorch/pytorch/pull/113447 on behalf of https://github.com/malfet due to Broke ROCM ([comment](https://github.com/pytorch/pytorch/pull/113447#issuecomment-1806407892 ))
2023-11-10 20:46:13 +00:00
7ccca60927
[BE] Remove stale CUDA version check from cpp_extension.py ( #113447 )
...
As at least CUDA-11.x is needed to build PyTorch on latest trunk
Pull Request resolved: https://github.com/pytorch/pytorch/pull/113447
Approved by: https://github.com/Skylion007 , https://github.com/atalman , https://github.com/PaliC , https://github.com/huydhn
2023-11-10 18:54:19 +00:00
71ca42787f
Replaced deprecated pkg_resources.packaging with packaging module ( #113023 )
...
Usage of `from pkg_resources import packaging` leads to a deprecation warning:
```
DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
```
and in strict tests where warnings are errors, this leads to CI breaks, e.g.: https://github.com/pytorch/vision/pull/8092
Replacing `pkg_resources.package` with `package` as it is now a pytorch dependency:
fa9045a872/requirements.txt (L19)https://github.com/pytorch/pytorch/pull/113023
Approved by: https://github.com/Skylion007 , https://github.com/malfet
2023-11-10 15:06:03 +00:00
aef9e43fe6
Revert "Replaced deprecated pkg_resources.packaging with packaging module ( #113023 )"
...
This reverts commit 81ea7a489a85d6f6de2c3b63206ca090927e203a.
Reverted https://github.com/pytorch/pytorch/pull/113023 on behalf of https://github.com/atalman due to breaks nightlies ([comment](https://github.com/pytorch/pytorch/pull/113023#issuecomment-1802720774 ))
2023-11-08 21:39:59 +00:00
21b6030ac3
Don't set CUDA_HOME when not compiled with CUDA support ( #106310 )
...
It doesn't make sense to set this (on import!) as CUDA cannot be used with PyTorch in this case but leads to messages like
> No CUDA runtime is found, using CUDA_HOME='/usr/local/cuda'
when CUDA happens to be installed which is at least confusing.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/106310
Approved by: https://github.com/ezyang
2023-11-06 21:48:49 +00:00
81ea7a489a
Replaced deprecated pkg_resources.packaging with packaging module ( #113023 )
...
Usage of `from pkg_resources import packaging` leads to a deprecation warning:
```
DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
```
and in strict tests where warnings are errors, this leads to CI breaks, e.g.: https://github.com/pytorch/vision/pull/8092
Replacing `pkg_resources.package` with `package` as it is now a pytorch dependency:
fa9045a872/requirements.txt (L19)https://github.com/pytorch/pytorch/pull/113023
Approved by: https://github.com/Skylion007
2023-11-06 20:26:32 +00:00
0adb28b77d
Show CUDAExtension example commands as code ( #112764 )
...
The default rendering of these code snippets renders the `TORCH_CUDA_ARCH_LIST` values with typographic quotes which prevent the examples from being directly copyable. Use code style for the two extension examples.
Fixes #112763
Pull Request resolved: https://github.com/pytorch/pytorch/pull/112764
Approved by: https://github.com/malfet
2023-11-02 21:47:50 +00:00
28c0b07d19
[ROCm] remove HCC references ( #111975 )
...
- rename `__HIP_PLATFORM_HCC__` to `__HIP_PLATFORM_AMD__`
- rename `HIP_HCC_FLAGS` to `HIP_CLANG_FLAGS`
- rename `PYTORCH_HIP_HCC_LIBRARIES` to `PYTORCH_HIP_LIBRARIES`
- workaround in tools/amd_build/build_amd.py until submodules are updated
These symbols have had a long deprecation cycle and will finally be removed in ROCm 6.0.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/111975
Approved by: https://github.com/ezyang , https://github.com/hongxiayang
2023-10-26 02:39:10 +00:00
ba04d84089
S390x inductor support ( #111367 )
...
Use arch compile flags. They are needed for vectorization support on s390x.
Implement new helper functions for inductor.
This change fixes multiple tests in test_cpu_repro.py
Pull Request resolved: https://github.com/pytorch/pytorch/pull/111367
Approved by: https://github.com/ezyang
2023-10-20 19:38:46 +00:00
cb856b08b2
[BE]: Attach cause to some exceptions and enable RUFF TRY200 ( #111496 )
...
Did some easy fixes from enabling TRY200. Most of these seem like oversights instead of intentional. The proper way to silence intentional errors is with `from None` to note that you thought about whether it should contain the cause and decided against it.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/111496
Approved by: https://github.com/malfet
2023-10-19 21:56:36 +00:00
bb89a9e48c
Skipped CUDA Flags if C++ Extension Name includes "arch" Substring ( #111211 )
...
The CUDA architecture flags from TORCH_CUDA_ARCH_LIST will be skipped if the TORCH_EXTENSION_NAME includes the substring "arch". A C++ Extension should be allowed to have any name. I just manually skip the TORCH_EXTENSION_NAME flag when checking if one of the flags is "arch". There is probably a better fix, but I'll leave this to experts.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/111211
Approved by: https://github.com/ezyang
2023-10-14 00:10:01 +00:00
