c855f8632e
Pyrefly suppressions 7/n ( #164913 )
...
Adds suppressions to pyrefly will typecheck clean: https://github.com/pytorch/pytorch/issues/163283
Almost there!
Test plan:
dmypy restart && python3 scripts/lintrunner.py -a
pyrefly check
step 1: delete lines in the pyrefly.toml file from the project-excludes field
step 2: run pyrefly check
step 3: add suppressions, clean up unused suppressions
before: https://gist.github.com/maggiemoss/4b3bf2037014e116bc00706a16aef199
after:
INFO 0 errors (6,884 ignored)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164913
Approved by: https://github.com/oulgen
2025-10-08 07:27:17 +00:00
086dec3235
Pyrefly suppressions 6/n ( #164877 )
...
Adds suppressions to pyrefly will typecheck clean: https://github.com/pytorch/pytorch/issues/163283
Almost there!
Test plan:
dmypy restart && python3 scripts/lintrunner.py -a
pyrefly check
step 1: delete lines in the pyrefly.toml file from the project-excludes field
step 2: run pyrefly check
step 3: add suppressions, clean up unused suppressions
before: https://gist.github.com/maggiemoss/4b3bf2037014e116bc00706a16aef199
after:
INFO 0 errors (5,064 ignored)
Only four directories left to enable
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164877
Approved by: https://github.com/oulgen
2025-10-08 02:30:57 +00:00
e2f9759bd0
Fix broken URLs ( #152237 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152237
Approved by: https://github.com/huydhn , https://github.com/malfet
2025-04-27 09:56:42 +00:00
2f9d378f7b
PEP585 update - torch/utils ( #145201 )
...
See #145101 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145201
Approved by: https://github.com/bobrenjc93
2025-01-21 21:04:10 +00:00
57536286e2
Flip default value for mypy disallow_untyped_defs [10/11] ( #127847 )
...
See #127836 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127847
Approved by: https://github.com/oulgen
ghstack dependencies: #127842 , #127843 , #127844 , #127845 , #127846
2024-06-08 18:50:06 +00:00
95b2766864
[BE][Ez]: Use NotADirectoryError in tensorboard writer ( #126534 )
...
Slightly improve exception typing for tensorboard wrriter
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126534
Approved by: https://github.com/ezyang
2024-05-17 19:52:13 +00:00
34910f87f0
[BE]: Update ruff to v0.4.4 ( #125031 )
...
Update ruff version to 0.4.2. This version mostly has bugfixes for the new parser and also updates the f-string rule to be able to apply more fixes.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125031
Approved by: https://github.com/albanD , https://github.com/malfet
2024-05-12 20:02:37 +00:00
45628e3b66
Remove Caffe2 python ( #125143 )
...
This PR tries to decompose https://github.com/pytorch/pytorch/pull/122527 into a smaller one. Caffe2 python build scripts were removed and some tensorboard code using Caffe2 was removed too.
To be noted, this was inspired and is co-dev with @r-barnes.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125143
Approved by: https://github.com/r-barnes , https://github.com/albanD
2024-05-10 21:15:43 +00:00
8cad88e1f3
[BE]: Improve exception typing. Remove NOQAs ( #125535 )
...
Improve some exception typing
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125535
Approved by: https://github.com/albanD
2024-05-08 14:07:13 +00:00
c5fafe9f48
[BE]: TRY002 - Ban raising vanilla exceptions ( #124570 )
...
Adds a ruff lint rule to ban raising raw exceptions. Most of these should at the very least be runtime exception, value errors, type errors or some other errors. There are hundreds of instance of these bad exception types already in the codebase, so I have noqa'd most of them. Hopefully this error code will get commiters to rethink what exception type they should raise when they submit a PR.
I also encourage people to gradually go and fix all the existing noqas that have been added so they can be removed overtime and our exception typing can be improved.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/124570
Approved by: https://github.com/ezyang
2024-04-21 22:26:40 +00:00
bd59e1113d
Improve docstring for tensorboard add_embedding() ( #120408 )
...
Fixes missing parameter documentation (`metadata_header`).
Fixes a typo.
Adds a note explaining a somewhat confusing behavior of Tensorboard Projector where categorical values with more than 50 unique values are not permitted to be used for coloring. This was not documented anywhere. The confusion caused https://github.com/tensorflow/tensorboard/issues/61 .
Pull Request resolved: https://github.com/pytorch/pytorch/pull/120408
Approved by: https://github.com/albanD
2024-04-10 00:32:29 +00:00
4f5785b6b3
Enable possibly-undefined error code ( #118533 )
...
Fixes https://github.com/pytorch/pytorch/issues/118129
Suppressions automatically added with
```
import re
with open("error_file.txt", "r") as f:
errors = f.readlines()
error_lines = {}
for error in errors:
match = re.match(r"(.*):(\d+):\d+: error:.*\[(.*)\]", error)
if match:
file_path, line_number, error_type = match.groups()
if file_path not in error_lines:
error_lines[file_path] = {}
error_lines[file_path][int(line_number)] = error_type
for file_path, lines in error_lines.items():
with open(file_path, "r") as f:
code = f.readlines()
for line_number, error_type in sorted(lines.items(), key=lambda x: x[0], reverse=True):
code[line_number - 1] = code[line_number - 1].rstrip() + f" # type: ignore[{error_type}]\n"
with open(file_path, "w") as f:
f.writelines(code)
```
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Co-authored-by: Catherine Lee <csl@fb.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/118533
Approved by: https://github.com/Skylion007 , https://github.com/zou3519
2024-01-30 21:07:01 +00:00
40ece2e579
Revert "Enable possibly-undefined error code ( #118533 )"
...
This reverts commit 4f13f69a45ef53747e2eefffd65d91ce840b431b.
Reverted https://github.com/pytorch/pytorch/pull/118533 on behalf of https://github.com/clee2000 due to sorry i'm trying to figure out a codev merge conflict, if this works i'll be back to rebase and merge ([comment](https://github.com/pytorch/pytorch/pull/118533#issuecomment-1917695185 ))
2024-01-30 19:00:34 +00:00
4f13f69a45
Enable possibly-undefined error code ( #118533 )
...
Fixes https://github.com/pytorch/pytorch/issues/118129
Suppressions automatically added with
```
import re
with open("error_file.txt", "r") as f:
errors = f.readlines()
error_lines = {}
for error in errors:
match = re.match(r"(.*):(\d+):\d+: error:.*\[(.*)\]", error)
if match:
file_path, line_number, error_type = match.groups()
if file_path not in error_lines:
error_lines[file_path] = {}
error_lines[file_path][int(line_number)] = error_type
for file_path, lines in error_lines.items():
with open(file_path, "r") as f:
code = f.readlines()
for line_number, error_type in sorted(lines.items(), key=lambda x: x[0], reverse=True):
code[line_number - 1] = code[line_number - 1].rstrip() + f" # type: ignore[{error_type}]\n"
with open(file_path, "w") as f:
f.writelines(code)
```
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/118533
Approved by: https://github.com/Skylion007 , https://github.com/zou3519
2024-01-30 05:08:10 +00:00
2ea3d64f47
fix docstring issues in torch.utils.tensorboard ( #113336 )
...
Fixes #112637
Fixed all the issues listed.
### Error Counts
|File | Count Before | Count now|
|---- | ---- | ---- |
|`torch/utils/tensorboard/_proto_graph.py` | 9 | 0|
|`torch/utils/tensorboard/_pytorch_graph.py` | 27 | 14|
|`torch/utils/tensorboard/_utils.py` | 5 | 2|
|`torch/utils/tensorboard/summary.py` | 27 | 12|
|`torch/utils/tensorboard/writer.py` | 42 | 4|
|`torch/utils/tensorboard/_caffe2_graph.py` | 19 | 0|
|`torch/utils/hipify/constants.py` | 2 | 0|
Pull Request resolved: https://github.com/pytorch/pytorch/pull/113336
Approved by: https://github.com/ezyang
2023-11-13 20:50:01 +00:00
0347b36b52
SummaryWriter.add_figure: add type hints ( #110021 )
...
Discovered a bug in our code that could have been prevented by type hints, so I added them 😄
Pull Request resolved: https://github.com/pytorch/pytorch/pull/110021
Approved by: https://github.com/ezyang
2023-11-01 02:19:09 +00:00
098d62d278
Add global_step parameter to SummaryWriter.add_hparams ( #109572 )
...
Fixes #37738 where all hparam metrics can only be plotted at step 0. This is basically just a resubmission of #50653 .
before:
<img width="345" alt="Screenshot 2023-09-18 at 8 09 13 PM" src="https://github.com/pytorch/pytorch/assets/27844407/89ebb327-9d0f-4e4e-a77a-27067a9d4ca0 ">
after:
<img width="346" alt="Screenshot 2023-09-18 at 7 56 52 PM" src="https://github.com/pytorch/pytorch/assets/27844407/059e0465-c6bf-47fe-974b-2175e57aa62d ">
@ngimel @J0Nreynolds @ezyang @albanD
Pull Request resolved: https://github.com/pytorch/pytorch/pull/109572
Approved by: https://github.com/ezyang
2023-09-22 12:37:01 +00:00
4cc1745b13
[BE] f-stringify torch/ and scripts ( #105538 )
...
This PR is a follow up on the pyupgrade series to convert more strings to use f-strings using `flynt`.
- https://docs.python.org/3/reference/lexical_analysis.html#f-strings
- https://pypi.org/project/flynt/
Command used:
```
flynt torch/ -ll 120
flynt scripts/ -ll 120
flynt tools/ -ll 120
```
and excluded `collect_env.py`
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105538
Approved by: https://github.com/ezyang , https://github.com/malfet
2023-07-21 19:35:24 +00:00
abc1cadddb
[BE] Enable ruff's UP rules and autoformat utils/ ( #105424 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105424
Approved by: https://github.com/ezyang , https://github.com/malfet
2023-07-18 20:17:25 +00:00
d855c6c7de
[PyTorch-TB] Write full tensor as tensor proto ( #105186 )
...
Write full tensor as tensor proto
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105186
Approved by: https://github.com/atalman
2023-07-14 18:04:09 +00:00
d35137cc37
Revert "[PyTorch TB] Write raw tensor as tensor_proto ( #104908 )"
...
This reverts commit dceae41c29782399c84304812696a8382e9b4292.
Reverted https://github.com/pytorch/pytorch/pull/104908 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](https://github.com/pytorch/pytorch/pull/104908#issuecomment-1634532376 ))
2023-07-13 16:22:04 +00:00
dceae41c29
[PyTorch TB] Write raw tensor as tensor_proto ( #104908 )
...
This is the first diff to support logging of raw tensors for [TensorBoard Intermediate Logging](https://www.internalfb.com/intern/wiki/TensorBoard/Intermediate_Logging/ )
Ultimately, we aim to support the feature where store full tensor is stored as a tensor protobuf to TB. Protobuf contains shape, dtype, and elements of the given tensor.
1. add `tensor_proto()` to `summary.py` which takes a tensor and convert to protobuf
2. add `add_tensor()` to `writer.py`
3. formatting changes introduced by `arc lint`
-------------
Differential Revision: [D47302017](https://our.internmc.facebook.com/intern/diff/D47302017/ )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/104908
Approved by: https://github.com/kunalb
2023-07-13 05:30:50 +00:00
603a777b09
[PyTorch TB] Refactor formatting ( #105027 )
...
This is the first diff to support logging of raw tensors for [TensorBoard Intermediate Logging](https://www.internalfb.com/intern/wiki/TensorBoard/Intermediate_Logging/ )
Ultimately, we aim to support the feature where store full tensor is stored as a tensor protobuf to TB. Protobuf contains shape, dtype, and elements of the given tensor.
This diff only contains formatting changes.
-------------
Differential Revision: [D47302017](https://our.internmc.facebook.com/intern/diff/D47302017/ )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105027
Approved by: https://github.com/kunalb
2023-07-12 06:08:18 +00:00
8fce9a09cd
[BE]: pyupgrade Python to 3.8 - imports and object inheritance only ( #94308 )
...
Apply parts of pyupgrade to torch (starting with the safest changes).
This PR only does two things: removes the need to inherit from object and removes unused future imports.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/94308
Approved by: https://github.com/ezyang , https://github.com/albanD
2023-02-07 21:10:56 +00:00
c00b135adf
Remove deprecated call to tf.io.gfile.get_filesystem ( #89832 )
...
Fixes #30966 . Fixes #47139
Pull Request resolved: https://github.com/pytorch/pytorch/pull/89832
Approved by: https://github.com/soumith
2022-12-08 08:53:27 +00:00
357b7d589c
Fix docstring inconsistencies: string -> str, boolean -> bool ( #82410 )
...
### Description
Throughout the PyTorch docs and codebase, the `string` type in docstrings is referred to by two separate names. This leads to inconsistent docs, like you can see here: https://pytorch.org/docs/stable/generated/torch.nn.Conv3d.html#torch.nn.Conv3d
This PR fixes this issue by ensuring that all mentions of the string type in docstrings, are using the same format that Sphinx generates hyperlinks for.
### Testing
No testing should be required for this change
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82410
Approved by: https://github.com/jbschlosser
2022-07-28 21:29:57 +00:00
9db3c517de
Add __all__ for torch.nn.modules, torch.distributed.elastic, torch.nn.utils submodules ( #80240 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80240
Approved by: https://github.com/rohan-varma
2022-06-27 17:11:12 +00:00
7c0ccb8a9d
black formatting for utils/tensorboard ( #76396 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/76396
Reviewed By: Reubend
Differential Revision: D35945748
Pulled By: edward-io
fbshipit-source-id: ffee22e88aaf49eb98b3e2eb6624a2dadb8ef754
(cherry picked from commit 6b5656b7c081cd69135b54f7d13d02c1c361b696)
2022-04-28 00:21:58 +00:00
b46f3a49b3
[tensorboard][writer] Add missing 'dataformats' argument to 'add_image' docs.
...
The [torch.utils.tensorboard.SummaryWriter.add_image](https://pytorch.org/docs/stable/_modules/torch/utils/tensorboard/writer.html#SummaryWriter.add_image ) is missing the argument `dataformats` in the docs.
This PR adds the missing argument to the docs (analogous to `add_images` docs).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/48834
Approved by: https://github.com/ezyang
2022-04-14 03:39:19 +00:00
96fb1a56ea
add use_strict_trace to tensorboard add_graph method ( #63120 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/63120
FAIM returns dictionaries as the model output, which throws an error when trying to trace using add_graph. Pass in `strict` to the tracer to make this user configurable.
User post: https://fb.workplace.com/groups/pytorchLightning/permalink/1510194972650369/?comment_id=1510252919311241&reply_comment_id=1510281112641755
Test Plan: unit test
Reviewed By: Reubend
Differential Revision: D30265890
fbshipit-source-id: 58b25d9500b875a29a664aa9ef4c1e7f13631fa1
2021-08-12 12:12:12 -07:00
d5988c5eca
remove unused type: ignore directives ( #60006 )
...
Summary:
During development it is common practice to put `type: ignore` comments on lines that are correct, but `mypy` doesn't recognize this. This often stems from the fact, that the used `mypy` version wasn't able to handle the used pattern.
With every new release `mypy` gets better at handling complex code. In addition to fix all the previously accepted but now failing patterns, we should also revisit all `type: ignore` comments to see if they are still needed or not. Fortunately, we don't need to do it manually: by adding `warn_unused_ignores = True` to the configuration, `mypy` will error out in case it encounters an `type: ignore` that is no longer needed.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/60006
Reviewed By: jbschlosser, malfet
Differential Revision: D29133237
Pulled By: albanD
fbshipit-source-id: 41e82edc5cd5affa7ccedad044b59b94dad4425a
2021-06-18 07:23:31 -07:00
68f74966fc
[ttk] Store float64 in tensorboard instead of float32 ( #59435 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/59435
Sometimes we need to compare 10+ digits. Currenlty tensorboard only saves float32. Provide an option to save float64
Reviewed By: yuguo68
Differential Revision: D28856352
fbshipit-source-id: 05d12e6f79b6237b3497b376d6665c9c38e03cf7
2021-06-09 10:42:37 -07:00
75024e228c
Add lint for unqualified type: ignore ( #56290 )
...
Summary:
The other half of https://github.com/pytorch/pytorch/issues/56272 .
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56290
Test Plan:
CI should pass on the tip of this PR, and we know that the lint works because the following CI runs (before this PR was finished) failed:
- https://github.com/pytorch/pytorch/runs/2384511062
- https://github.com/pytorch/pytorch/actions/runs/765036024
Reviewed By: seemethere
Differential Revision: D27867219
Pulled By: samestep
fbshipit-source-id: e648f07b6822867e70833e23ddafe7fb7eaca235
2021-04-21 08:07:23 -07:00
317ff429d3
[TB] Support writing new style scalar ( #53496 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/53496
New style vs old style
b306651ab5/tensorboard/data_compat.py (L49-L53)b306651ab5/tensorboard/data_compat.py (L46)
2021-03-12 19:03:13 -08:00
46b83212d1
Remove unused six code for Python 2/3 compatibility ( #48077 )
...
Summary:
This is basically a reborn version of https://github.com/pytorch/pytorch/issues/45254 .
Ref: https://github.com/pytorch/pytorch/issues/42919
Pull Request resolved: https://github.com/pytorch/pytorch/pull/48077
Reviewed By: ngimel
Differential Revision: D25687042
Pulled By: bugra
fbshipit-source-id: 05f20a6f3c5212f73d0b1505b493b720e6cf74e5
2020-12-22 18:07:08 -08:00
b1a1271f68
Fix typo in add_pr_curve docstrings. ( #49648 )
...
Summary:
Very small PR to fix a typo.
### Description
Fixed 1 typo in the documentation of `torch/utils/tensorboard/writer.py` (replaced "_should in_" by "_should be in_")
Pull Request resolved: https://github.com/pytorch/pytorch/pull/49648
Reviewed By: ngimel
Differential Revision: D25665831
Pulled By: mrshenli
fbshipit-source-id: a4e733515603bb9313c1267fdf2cfcc2bc2773c6
2020-12-21 10:21:55 -08:00
20ac736200
Remove py2 compatible future imports ( #44735 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/44735
Reviewed By: mruberry
Differential Revision: D23731306
Pulled By: ezyang
fbshipit-source-id: 0ba009a99e475ddbe22981be8ac636f8a1c8b02f
2020-09-16 12:55:57 -07:00
cdf5e2ae86
add typing annotations for a few torch.utils.* modules ( #43806 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/43431 . Depends on [gh-43862](https://github.com/pytorch/pytorch/pull/43862 ) (EDIT: now merged)
Modules:
- torch.utils.mkldnn
- torch.utils.mobile_optimizer
- torch.utils.bundled_inputs
Pull Request resolved: https://github.com/pytorch/pytorch/pull/43806
Reviewed By: gmagogsfm
Differential Revision: D23635151
Pulled By: SplitInfinity
fbshipit-source-id: a85b75a7927dde6cc55bcb361f8ff601ffb0b2a1
2020-09-11 10:20:55 -07:00
c84f78470b
Fix type annotations for a number of torch.utils submodules ( #42711 )
...
Summary:
Related issue on `torch.utils` type annotation hiccups: gh-41794
Pull Request resolved: https://github.com/pytorch/pytorch/pull/42711
Reviewed By: mrshenli
Differential Revision: D23005434
Pulled By: malfet
fbshipit-source-id: 151554b1e7582743f032476aeccdfdad7a252095
2020-08-14 18:12:48 -07:00
9600ed9af3
typo fixes ( #41632 )
...
Summary:
typo fixes
Pull Request resolved: https://github.com/pytorch/pytorch/pull/41632
Reviewed By: ezyang
Differential Revision: D22617827
Pulled By: mrshenli
fbshipit-source-id: c2bfcb7cc36913a8dd32f13fc9adc3aa0a9b682f
2020-07-20 07:23:00 -07:00
01e2099bb8
[TB] Add support for hparam domain_discrete ( #40720 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/40720
Add support for populating domain_discrete field in TensorBoard add_hparams API
Test Plan: Unit test test_hparams_domain_discrete
Reviewed By: edward-io
Differential Revision: D22291347
fbshipit-source-id: 78db9f62661c9fe36cd08d563db0e7021c01428d
2020-06-29 19:33:57 -07:00
502ec8f7f7
Revert D22227939: [TB] Add support for hparam domain_discrete
...
Test Plan: revert-hammer
Differential Revision:
D22227939 (4c25428c8c
2020-06-27 22:20:31 -07:00
4c25428c8c
[TB] Add support for hparam domain_discrete
...
Summary: Add support for populating domain_discrete field in TensorBoard add_hparams API
Test Plan: Unit test test_hparams_domain_discrete
Reviewed By: edward-io
Differential Revision: D22227939
fbshipit-source-id: d2f0cd8e5632cbcc578466ff3cd587ee74f847af
2020-06-27 14:07:24 -07:00
2456e078d3
[TB] Support custom run_name in add_hparams ( #40660 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/40660
Support custom run_name since using timestamp as run_name can be confusing to people
Test Plan:
hp = {"lr": 0.1, "bool_var": True, "string_var": "hi"}
mt = {"accuracy": 0.1}
writer.add_hparams(hp, mt, run_name="run1")
writer.flush()
Reviewed By: edward-io
Differential Revision: D22157749
fbshipit-source-id: 3d4974381e3be3298f3e4c40e3d4bf20e49dfb07
2020-06-27 14:05:20 -07:00
149b468ce2
[TensorBoard] Fixes missing doc for add_graph ( #37504 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/37415
Pull Request resolved: https://github.com/pytorch/pytorch/pull/37504
Differential Revision: D21305979
Pulled By: natalialunova
fbshipit-source-id: 0606a39a6006a236a37a0e6df87959736474547f
2020-04-30 10:26:19 -07:00
f767de608c
[tensorboard] Add strings to image boxes ( #30941 )
...
Summary:
Addresses https://github.com/pytorch/pytorch/issues/27300
sample usage:
```python
import torch
from torch.utils.tensorboard import SummaryWriter
with SummaryWriter() as w:
w.add_image_with_boxes('imagebox_label', torch.ones(3, 240, 240) * 0.5,
torch.Tensor([[10, 10, 100, 100], [101, 101, 200, 200]]),
global_step=0, labels=['label1', 'label2'])
```
cc sanekmelnikov orionr
Pull Request resolved: https://github.com/pytorch/pytorch/pull/30941
Differential Revision: D21083617
Pulled By: natalialunova
fbshipit-source-id: b451b701159eecc0ea0bece96ec69f69f5432791
2020-04-17 17:58:43 -07:00
3a400b8dc3
[tensorboard] Fix function input parameter for add_hparams ( #31301 )
...
Summary:
closes https://github.com/pytorch/pytorch/issues/30943
both parameters in add_hparams are mandatory.
cc sanekmelnikov orionr
Pull Request resolved: https://github.com/pytorch/pytorch/pull/31301
Differential Revision: D21069761
Pulled By: natalialunova
fbshipit-source-id: 1a12f6760fa9676d11901fa85aa91f4f9fff976d
2020-04-17 11:19:14 -07:00
1f40bddf57
[TensorBoard] fix #36471 ( #36495 )
...
Summary:
cc orionr sanekmelnikov
Confirm that the function was removed already.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/36495
Differential Revision: D21003122
Pulled By: natalialunova
fbshipit-source-id: 364b0790953980e02eb7ff8fa0b6218d7e34a0c3
2020-04-13 17:49:16 -07:00
c49de6ce0d
[TensorBoard] fix #33140 ( #36497 )
...
Summary:
cc orionr sanekmelnikov
The fix was ported from 9d267066a6https://github.com/pytorch/pytorch/pull/36497
Differential Revision: D21002710
Pulled By: natalialunova
fbshipit-source-id: 0d2f3697c650bccdf6de52583de0d38c5c219261
2020-04-13 17:44:09 -07:00
09915ad570
[TensorBoard] Correct typo and wrap dataformats. ( #31604 )
...
Summary:
Resolves issue https://github.com/pytorch/pytorch/issues/31603
- A minor spelling typo is corrected: "suitible" --> "suitable"
- A minor quality of life improvement is added: the data format strings are better rendered as fixed width to indicate that they are string constants. "CHW" --> "`CHW`"
Pull Request resolved: https://github.com/pytorch/pytorch/pull/31604
Differential Revision: D19697293
Pulled By: ezyang
fbshipit-source-id: ee38b0d4c9ca8a233ac9243c310d9a3b42ad6f32
2020-02-12 07:51:04 -08:00
