99f2491af9
Revert "Use absolute path path.resolve() -> path.absolute() ( #129409 )"
...
This reverts commit 45411d1fc9a2b6d2f891b6ab0ae16409719e09fc.
Reverted https://github.com/pytorch/pytorch/pull/129409 on behalf of https://github.com/jeanschmidt due to Breaking internal CI, @albanD please help get this PR merged ([comment](https://github.com/pytorch/pytorch/pull/129409#issuecomment-2571316444 ))
2025-01-04 14:17:20 +00:00
45411d1fc9
Use absolute path path.resolve() -> path.absolute() ( #129409 )
...
Changes:
1. Always explicit `.absolute()`: `Path(__file__)` -> `Path(__file__).absolute()`
2. Replace `path.resolve()` with `path.absolute()` if the code is resolving the PyTorch repo root directory.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129409
Approved by: https://github.com/albanD
2025-01-03 20:03:40 +00:00
cc4e70b7c3
Revert "Use absolute path path.resolve() -> path.absolute() ( #129409 )"
...
This reverts commit 135c7db99d646b8bd9603bf969d47d3dec5987b1.
Reverted https://github.com/pytorch/pytorch/pull/129409 on behalf of https://github.com/malfet due to need to revert to as dependency of https://github.com/pytorch/pytorch/pull/129374 ([comment](https://github.com/pytorch/pytorch/pull/129409#issuecomment-2562969825 ))
2024-12-26 17:26:06 +00:00
135c7db99d
Use absolute path path.resolve() -> path.absolute() ( #129409 )
...
Changes:
1. Always explicit `.absolute()`: `Path(__file__)` -> `Path(__file__).absolute()`
2. Replace `path.resolve()` with `path.absolute()` if the code is resolving the PyTorch repo root directory.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129409
Approved by: https://github.com/albanD
2024-12-24 08:33:08 +00:00
0f261e8f77
Add Manylinux2014 and Manylinux 2.28 config to triton builds. Run auditwheel on triton binaries ( #141704 )
...
This PR combines Manylinux 2_28 and Manylinux 2014 builds of triton under one workflow. This is required in order to support torch cpu, cuda 118, cuda 12.4 wheels built with Manylinux 2014 and torch cuda 12.6 wheels built with Manylinux 2_28.
Manylinux 2014 wheels:
``pytorch_triton-3.2.0+git35c6c7c6-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl``
Manylinux 2_28 wheels:
``pytorch_triton-3.2.0+git35c6c7c6-cp39-cp39-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl``
Pull Request resolved: https://github.com/pytorch/pytorch/pull/141704
Approved by: https://github.com/Skylion007 , https://github.com/malfet , https://github.com/huydhn
2024-11-28 13:40:39 +00:00
57fc070e08
[triton] Update pin for PyTorch 2.6/Triton 3.2 ( #139206 )
...
Bump the Triton pin to the release candidate commit for Triton 3.2.
A few changes beyond the pin bump itself are needed:
* Remove the script that adds a git version hash suffix to the Triton wheel, since as of https://github.com/triton-lang/triton/pull/4812 Triton adds that itself
* Add `pybind11` to the Triton build setup, since Triton now depends on it
* Use manylinux-2.28 for the Triton wheel builder, and use clang+lld for building to pick up the right glibc
Pull Request resolved: https://github.com/pytorch/pytorch/pull/139206
Approved by: https://github.com/malfet , https://github.com/atalman
Co-authored-by: Andrey Talman <atalman@fb.com >
2024-11-22 18:34:32 +00:00
44d5012a80
Revert "[triton] Update pin for PyTorch 2.6/Triton 3.2 ( #139206 )"
...
This reverts commit c93e57efac091f246b599b4fcdc189ed94753b43.
Reverted https://github.com/pytorch/pytorch/pull/139206 on behalf of https://github.com/atalman due to Will revert and reland skipping xpu builds ([comment](https://github.com/pytorch/pytorch/pull/139206#issuecomment-2494437857 ))
2024-11-22 18:01:18 +00:00
c93e57efac
[triton] Update pin for PyTorch 2.6/Triton 3.2 ( #139206 )
...
Bump the Triton pin to the release candidate commit for Triton 3.2.
A few changes beyond the pin bump itself are needed:
* Remove the script that adds a git version hash suffix to the Triton wheel, since as of https://github.com/triton-lang/triton/pull/4812 Triton adds that itself
* Add `pybind11` to the Triton build setup, since Triton now depends on it
* Use manylinux-2.28 for the Triton wheel builder, and use clang+lld for building to pick up the right glibc
Pull Request resolved: https://github.com/pytorch/pytorch/pull/139206
Approved by: https://github.com/malfet , https://github.com/atalman
Co-authored-by: Andrey Talman <atalman@fb.com >
2024-11-22 14:50:22 +00:00
034717a029
[ROCm] remove triton-rocm commit pin and merge pins with triton.txt ( #133438 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133438
Approved by: https://github.com/jithunnair-amd , https://github.com/malfet
Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com >
2024-09-05 20:36:45 +00:00
a1ba8e61d1
Revert "[ROCm] remove triton-rocm commit pin and merge pins with triton.txt ( #133438 )"
...
This reverts commit 5e8bf29148a590318f678620f84be8f4d5ffff5c.
Reverted https://github.com/pytorch/pytorch/pull/133438 on behalf of https://github.com/ZainRizvi due to This still breaks linux binary builds. Added the appropriate labels to ensure tests can pass. See [GH job link](https://github.com/pytorch/pytorch/actions/runs/10626427003/job/29460479554 ) [HUD commit link](5e8bf29148https://github.com/pytorch/pytorch/pull/133438#issuecomment-2322246198 ))
2024-08-30 20:00:41 +00:00
5e8bf29148
[ROCm] remove triton-rocm commit pin and merge pins with triton.txt ( #133438 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133438
Approved by: https://github.com/jithunnair-amd , https://github.com/malfet
Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com >
2024-08-30 03:38:35 +00:00
4648848696
Revert "[ROCm] remove triton-rocm commit pin and merge pins with triton.txt ( #133438 )"
...
This reverts commit f71c3d265ab52589f983dd252d61461db4e7dbbd.
Reverted https://github.com/pytorch/pytorch/pull/133438 on behalf of https://github.com/jeanschmidt due to seems to have introduced breakages in linux binary builds ([comment](https://github.com/pytorch/pytorch/pull/133438#issuecomment-2308787310 ))
2024-08-25 11:20:30 +00:00
f71c3d265a
[ROCm] remove triton-rocm commit pin and merge pins with triton.txt ( #133438 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133438
Approved by: https://github.com/jithunnair-amd , https://github.com/malfet
2024-08-24 18:26:49 +00:00
30d7e7a1cd
[XPU] Fix patch for old llvm package error for triton xpu ( #134204 )
...
Fixes #134199
The PR #133694 does a workaround to replace the str `"https://tritonlang.blob.core.windows.net/llvm-builds/ "` with `"https://oaitriton.blob.core.windows.net/public/llvm-builds/ "` in `triton/python/setup.py`. However, in [newer version of Triton](06e6799f4ehttps://oaitriton.blob.core ....` and don't need to be replaced. But formerly, this will throw a runtime error.
This PR makes the `check_and_replace` logic won't fail in such a scenario. Both the old link and the newer link could work.
Also note that the `.ci/docker/common/install_triton.sh` does not need the fix, because its `sed` command won't be in effect if there is no such pattern.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/134204
Approved by: https://github.com/chuanqi129 , https://github.com/EikanWang , https://github.com/atalman
2024-08-22 23:18:44 +00:00
2cffe82dea
Fix triton build failure due to tritonlang.blob.core.windows.net not available ( #133694 )
...
This should mitigate https://github.com/triton-lang/triton/issues/4527
We should also remove this once our triton pin moves past: https://github.com/triton-lang/triton/pull/4216
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133694
Approved by: https://github.com/Skylion007 , https://github.com/kit1980 , https://github.com/malfet
2024-08-16 17:34:30 +00:00
747b38c131
[BE][Easy][2/19] enforce style for empty lines in import segments in .ci/ and .github/ ( #129753 )
...
See https://github.com/pytorch/pytorch/pull/129751#issue-2380881501 . Most changes are auto-generated by linter.
You can review these PRs via:
```bash
git diff --ignore-all-space --ignore-blank-lines HEAD~1
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129753
Approved by: https://github.com/malfet
ghstack dependencies: #129752
2024-07-16 09:40:00 +00:00
d496145534
[CD] Add triton xpu wheel build ( #129730 )
...
Enable triton xpu wheel build firstly, then add pytorch xpu nightly wheel build
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129730
Approved by: https://github.com/atalman
2024-07-04 17:55:20 +00:00
a1a22a22d5
[ROCm] Parameterize the triton build dir ( #125420 )
...
- Removes hard coding and helps in internal builds
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125420
Approved by: https://github.com/malfet
2024-05-08 04:46:52 +00:00
4b586a434f
[ROCm] Triton upstream AMD backend integration ( #121801 )
...
Update ROCm-triton to use the AMD backend from https://github.com/openai/triton
Note: `test__int_mm` can be enabled after https://github.com/pytorch/pytorch/pull/122431 is landed
Co-authored-by: Pruthvi Madugundu <pruthvigithub@gmail.com >
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/121801
Approved by: https://github.com/nmacchioni , https://github.com/malfet
2024-04-25 20:44:27 +00:00
3890848ec2
Revert "[ROCm] Triton upstream AMD backend integration ( #121801 )"
...
This reverts commit 9888d7495ece6b6df3b7334fc7c2a9d869359250.
Reverted https://github.com/pytorch/pytorch/pull/121801 on behalf of https://github.com/jeanschmidt due to need to revert so I can revert https://github.com/pytorch/pytorch/pull/124592 ([comment](https://github.com/pytorch/pytorch/pull/121801#issuecomment-2076951327 ))
2024-04-25 11:22:19 +00:00
9888d7495e
[ROCm] Triton upstream AMD backend integration ( #121801 )
...
Update ROCm-triton to use the AMD backend from https://github.com/openai/triton
Note: `test__int_mm` can be enabled after https://github.com/pytorch/pytorch/pull/122431 is landed
Co-authored-by: Pruthvi Madugundu <pruthvigithub@gmail.com >
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/121801
Approved by: https://github.com/nmacchioni , https://github.com/malfet
2024-04-24 17:28:12 +00:00
7e13b5ba29
Checkout release branch rather then commit_hash when building triton release ( #115379 ) ( #121901 )
...
Cherry pick of https://github.com/pytorch/pytorch/pull/115379 from Release 2.2 that should be applied to main and Release 2.3 as well
Pull Request resolved: https://github.com/pytorch/pytorch/pull/121901
Approved by: https://github.com/DanilBaibak , https://github.com/jeanschmidt
2024-03-14 14:42:29 +00:00
c6930aad46
Update Triton pin ( #117873 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/117873
Approved by: https://github.com/shunting314 , https://github.com/malfet
2024-01-23 21:05:30 +00:00
28e37d4f3b
Update Trition pin ( #115743 )
...
To include a cherry-pick of https://github.com/openai/triton/pull/2771 that should fix cuda-11.8 runtime issues
Also, tweak build wheel script to update both ROCm and vanilla Trition builds version to 2.2 (even though on trunk it should probably be 3.3 already)
TODO: Remove `ROCM_TRITION_VERSION` once both trunk and ROCM version are in sync again
Pull Request resolved: https://github.com/pytorch/pytorch/pull/115743
Approved by: https://github.com/davidberard98
2023-12-14 18:54:24 +00:00
794545c11f
[BE]: Enable RUF015 codebase wide ( #115507 )
...
Constant time access of first value in collection. This is a constant time operation instead of converting the item to a list to get the first item which is linear. The rule is turned on which automatically autofixes and enforces this.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/115507
Approved by: https://github.com/malfet
2023-12-11 15:51:01 +00:00
bf16fec463
Fix up triton builds ( #115039 )
...
Follow ups after https://github.com/pytorch/pytorch/pull/114772 and https://github.com/pytorch/pytorch/pull/108187
- Triton builds should be published from `main` rather than `nightly` branch, as:
- They are independent of any PyTorch changes
- Every nightly is pinned to a specific commit therefore publishing updated triton binaries will not affect previous nightlies
- If this is not the case, nightly promotion will never happen as binary builds on main will continue to fail in perpetuity searching for new triton binary
- `patch_setup_py` is still needed to modify name of the package for ROCm builds
Pull Request resolved: https://github.com/pytorch/pytorch/pull/115039
Approved by: https://github.com/seemethere , https://github.com/kit1980 , https://github.com/huydhn
2023-12-03 23:14:41 +00:00
8a90249bc2
[inductor] Update triton pin ( #114772 )
...
Differential Revision: [D51761353](https://our.internmc.facebook.com/intern/diff/D51761353 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/114772
Approved by: https://github.com/shunting314 , https://github.com/atalman
2023-12-02 19:13:56 +00:00
7be233f3a5
Remove commit hash when building triton wheel and conda in release mode ( #108203 )
...
This is the follow-up of https://github.com/pytorch/pytorch/pull/108187 to set the correct release version without commit hash for triton wheel and conda binaries when building them in release mode.
### Testing
* With commit hash (nightly): https://github.com/pytorch/pytorch/actions/runs/6019021716
* Without commit hash https://github.com/pytorch/pytorch/actions/runs/6019378616 (by adding `--release` into the PR)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/108203
Approved by: https://github.com/atalman
2023-08-30 16:49:21 +00:00
196ef78b90
[ROCm] Use rocm manylinux builder image for triton wheels ( #107600 )
...
Update to ROCm triton pinned commit for the 2.1 branch cut off.
As part of this we are updating `build_triton_wheel.py` and `build-triton-wheel.yml` to support building ROCm triton wheels through pytorch/manylinux-rocm to avoid the need of slowly downloading rpm libraries for ROCm in the cpu manylinux builder image and avoiding the need to maintain a conditional file with hard coded repositories from radeon.org for every ROCm release.
This new approach will allow us to build wheels faster in a more easily maintainable way.
This PR also brings in a required change as Triton on ROCm requires device_type to be set to hip so we can pass down the correct device type to triton (https://github.com/ROCmSoftwarePlatform/triton/pull/284 ).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/107600
Approved by: https://github.com/jansel , https://github.com/jithunnair-amd
2023-08-25 10:25:29 +00:00
31ee1512d3
[inductor] Update triton pin ( #102736 )
...
There is some bug in triton's handling of `tl.reduce` that breaks the variance PR, but is fixed on the latest triton master.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/102736
Approved by: https://github.com/huydhn , https://github.com/desertfire
2023-06-12 22:02:13 +00:00
8e54218024
[ROCM] Add build ROCM support to build-triton-wheel.yml ( #95142 )
...
To match with upstream and build triton whl's locally so nightly pytorch whls can access them without needing to use pypi.org.
We may have a better approach to build both whl's at once, but for now, to save duplication of code, another matrix is added for device (cuda/rocm) With rocm invoking a different commit and repo. The goal is to eventually have a single whl support both backends.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/95142
Approved by: https://github.com/malfet , https://github.com/jithunnair-amd , https://github.com/atalman
2023-05-12 15:54:57 +00:00
4c0dce50fd
[BE] Apply ufmt to run_test and GitHub Python util scripts ( #97588 )
...
This has been bugging me for a while as I'm working on these Python scripts and they are not tracked by ufmt linter. So I add these script into that linter.
```
[[linter]]
code = 'UFMT'
include_patterns = [
'.github/**/*.py',
'test/run_test.py',
```
This change should just work and not break anything as ufmt (black + usort) linter is very safe to use for standalone util scripts.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/97588
Approved by: https://github.com/kit1980
2023-03-26 04:52:55 +00:00
c089c6bf15
update triton pin ( #96730 )
...
Fixes #96694
Pull Request resolved: https://github.com/pytorch/pytorch/pull/96730
Approved by: https://github.com/malfet
2023-03-20 23:42:33 +00:00
1ab883797a
[BE] Dedup hardcoded triton versions ( #96580 )
...
Define it once in `.ci/docker/trition_version.txt` and use everywhere.
Also, patch version defined in `triton/__init__.py` as currently it always returns `2.0.0` even if package name is `2.1.0`
Followup after https://github.com/pytorch/pytorch/pull/95896 where version needed to be updated in 4+ places
Pull Request resolved: https://github.com/pytorch/pytorch/pull/96580
Approved by: https://github.com/huydhn
2023-03-12 20:00:48 +00:00
30b968f60d
Revert "[BE] Dedup hardcoded triton versions ( #96580 )"
...
This reverts commit c131e51e6248cf04135db317040b5be3ab944d41.
Reverted https://github.com/pytorch/pytorch/pull/96580 on behalf of https://github.com/malfet due to Forgot to fix lint
2023-03-12 19:37:52 +00:00
c131e51e62
[BE] Dedup hardcoded triton versions ( #96580 )
...
Define it once in `.ci/docker/trition_version.txt` and use everywhere.
Also, patch version defined in `triton/__init__.py` as currently it always returns `2.0.0` even if package name is `2.1.0`
Followup after https://github.com/pytorch/pytorch/pull/95896 where version needed to be updated in 4+ places
Pull Request resolved: https://github.com/pytorch/pytorch/pull/96580
Approved by: https://github.com/huydhn
2023-03-12 16:56:04 +00:00
76cac70939
new triton main pin ( #95896 )
...
Fixes #ISSUE_NUMBER
Pull Request resolved: https://github.com/pytorch/pytorch/pull/95896
Approved by: https://github.com/jansel , https://github.com/malfet
2023-03-10 06:30:41 +00:00
d0731271cd
Revert "new triton main pin ( #95896 )"
...
This reverts commit 6e0359dd4233b0cec51521bec8869f0a46ebd98b.
Reverted https://github.com/pytorch/pytorch/pull/95896 on behalf of https://github.com/huydhn due to I am not quite sure what this is about yet, but testing 3.8 wheel starts to fail 6e0359dd42
2023-03-10 05:41:45 +00:00
6e0359dd42
new triton main pin ( #95896 )
...
Fixes #ISSUE_NUMBER
Pull Request resolved: https://github.com/pytorch/pytorch/pull/95896
Approved by: https://github.com/jansel
2023-03-10 03:40:37 +00:00
43f6ed4abd
Extend torch-trition conda to 3.11 ( #93117 )
...
Also drop 3.7 from both builds and add proper names to the steps
Add `pytorch-nightly` for `conda` builds to test the installation against `pytorch` from the nightly channel as well as get [`filelock`](https://anaconda.org/pytorch-nightly/filelock ) dependency for 3.11)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/93117
Approved by: https://github.com/atalman
2023-02-06 22:14:57 +00:00
bc92444b34
Rename torchtriton ( #91539 )
...
to `pytorch-triton`
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91539
Approved by: https://github.com/seemethere , https://github.com/soumith
2022-12-30 22:49:17 +00:00
59a2fe74d4
[CI] Add TorchTrition conda packages ( #89841 )
...
As we need them to make triton available on both platforms
Pull Request resolved: https://github.com/pytorch/pytorch/pull/89841
Approved by: https://github.com/msaroufim
2022-11-30 01:01:59 +00:00
dfe3fc028c
[CI] Add triton wheels build workflow ( #87234 )
...
Also, add `torchtriton` and `jinja2` as extra `dynamo` dependency to PyTorch wheels,
Version packages as first 10 characters of pinned repo hash and make `torch[dynamo]` wheel depend on the exact version it was build against.
TODO: Automate uploading to nightly wheels storage
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87234
Approved by: https://github.com/msaroufim
2022-10-19 03:35:16 +00:00
