deb7ebe0a3
Revert "[Reland] Use std::string_view in torchgen ( #158625 )"
...
This reverts commit 972e409829343cc2062aeee0994a9c1c735d216a.
Reverted https://github.com/pytorch/pytorch/pull/158625 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it seems to break a couple of ExecuTorch tests for Vulkan backend ([comment](https://github.com/pytorch/pytorch/pull/158625#issuecomment-3287754275 ))
2025-09-13 07:52:50 +00:00
972e409829
[Reland] Use std::string_view in torchgen ( #158625 )
...
Reland of #157050 , which is incidentally closed.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158625
Approved by: https://github.com/albanD
2025-09-12 08:31:54 +00:00
9a1c5c0a07
Detect torch function in lists as well ( #160256 )
...
We basically follow the same pattern we do for tensor arguments. The major downside is we now have to traverse the entirety of the int list / etc where previously we didn't have. Benchmark suggests 2% regression for relevant things.
Signed-off-by: Edward Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/160256
Approved by: https://github.com/albanD
2025-09-02 16:22:42 +00:00
fc0376e8b1
[BE][2/6] fix typos in test/ (test/test_*.py) ( #157636 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157636
Approved by: https://github.com/yewentao256 , https://github.com/mlazos
ghstack dependencies: #156311 , #156609
2025-07-09 11:02:23 +00:00
d5e6f42094
Revert "Use std::string_view in torchgen ( #157050 )"
...
This reverts commit 064288cbab94c9931ca2296a2b9723e864f9050a.
Reverted https://github.com/pytorch/pytorch/pull/157050 on behalf of https://github.com/jeanschmidt due to Seems to have broken internal builds, more details on D77449943. @ezyang may I count on your help to get those changes merged? ([comment](https://github.com/pytorch/pytorch/pull/157050#issuecomment-3020222668 ))
2025-06-30 18:08:54 +00:00
064288cbab
Use std::string_view in torchgen ( #157050 )
...
Let the generated code use std::sv
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157050
Approved by: https://github.com/ezyang
2025-06-27 06:36:10 +00:00
297805fd8f
Typo fixes for "overridden" in comments and function names ( #155944 )
...
This word appears often in class descriptions and is not consistently spelled. Update comments and some function names to use the correct spelling consistently. Facilitates searching the codebase.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/155944
Approved by: https://github.com/Skylion007
2025-06-14 03:37:38 +00:00
f66229de2b
[dynamo] Remove traceable_tensor_subclasses-related code ( #151062 )
...
Since #149792 deprecates `traceable_tensor_subclasses` and it's been
landed for over a week, we can safely remove all the old code that uses
`traceable_tensor_subclasses` (they were primarily for testing purposes
and are equivalent to no-ops now).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/151062
Approved by: https://github.com/mlazos , https://github.com/anijain2305
ghstack dependencies: #151060 , #151061
2025-04-15 03:55:35 +00:00
9092dd2e82
[CI] Disable some tests that are failing in periodic ( #150059 )
...
Disabling some tests to restore periodic
nogpu avx512 timeout:
59f14d19ae (38492953496-box)7ae0ce6360 (38461255009-box)87bfd66c3c (39476723746-box)bf752c36da (39484562957-box)bb9c426024 (38447525659-box)8f858e226b (39488068620-box)f2cea01f71 (39555064878)b5281a4a18 (39599355600)2ec9aceaeb/1https://github.com/pytorch/pytorch/pull/150059
Approved by: https://github.com/ZainRizvi , https://github.com/atalman , https://github.com/malfet
2025-03-28 20:31:32 +00:00
3f63f2bced
Use std::string_view in tests ( #146120 )
...
Fixes #ISSUE_NUMBER
Pull Request resolved: https://github.com/pytorch/pytorch/pull/146120
Approved by: https://github.com/albanD
2025-02-04 09:51:36 +00:00
1c16cf70c3
Apply ruff fixes to tests ( #146140 )
...
Fixes #ISSUE_NUMBER
Pull Request resolved: https://github.com/pytorch/pytorch/pull/146140
Approved by: https://github.com/albanD
2025-02-04 05:41:01 +00:00
b3e90c8c33
Add support for torch function on dtype arguments ( #145085 )
...
Along the lines of https://github.com/pytorch/pytorch/issues/119194 although it doesn't actually address the FCD case.
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145085
Approved by: https://github.com/vmoens , https://github.com/Skylion007
2025-01-21 17:44:47 +00:00
d8c8ba2440
Fix unused Python variables in test/[e-z]* ( #136964 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136964
Approved by: https://github.com/justinchuby , https://github.com/albanD
2024-12-18 23:02:30 +00:00
82ce888273
c10::string_view -> std::string_view in more places ( #142517 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/142517
Approved by: https://github.com/malfet
2024-12-12 19:45:59 +00:00
ed313a5ca2
Introduce torch.sym_add, variadic add ( #138660 )
...
Tested internally here: https://www.internalfb.com/diff/D64057744
This is a reland after previous internal failures.
main change is
```
if min is None and max is None:
torch._check_is_size(size)
return
```
Partially addresses https://github.com/pytorch/pytorch/issues/128150
When you have big sums of values, we end up computing long chains of
binary addition in our FX graph representation. Not only is this ugly,
it also is quadratic, as the sympy.Add constructor is O(N) in number
of arguments. Instead, ensure that we maintain the summation as a
single FX node so we can do the entire addition all in one go.
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/138660
Approved by: https://github.com/ezyang , https://github.com/bobrenjc93
2024-10-23 17:42:41 +00:00
a20a17fd6f
[Dynamo] Disable torch function compilation during guard execution and in compiled bytecode ( #137669 )
...
Fixes https://github.com/pytorch/pytorch/issues/114369
Pull Request resolved: https://github.com/pytorch/pytorch/pull/137669
Approved by: https://github.com/anijain2305
2024-10-19 04:12:45 +00:00
4557f6e339
Revert "[Dynamo] Disable torch function compilation during guard execution and in compiled bytecode ( #137669 )"
...
This reverts commit bf0b67059882933574f71a3b11b2f0127915ee5b.
Reverted https://github.com/pytorch/pytorch/pull/137669 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but it is failing test_public_bindings in trunk, maybe a landrace ([comment](https://github.com/pytorch/pytorch/pull/137669#issuecomment-2415331274 ))
2024-10-15 23:22:58 +00:00
bf0b670598
[Dynamo] Disable torch function compilation during guard execution and in compiled bytecode ( #137669 )
...
Fixes https://github.com/pytorch/pytorch/issues/114369
Pull Request resolved: https://github.com/pytorch/pytorch/pull/137669
Approved by: https://github.com/anijain2305
2024-10-15 20:52:58 +00:00
16a2c2cfd4
Revert "Introduce torch.sym_sum ( #136429 )"
...
This reverts commit 90bed32b986ab1356dc376df3985497cedbe8a29.
Reverted https://github.com/pytorch/pytorch/pull/136429 on behalf of https://github.com/ezyang due to fails internal stuff ([comment](https://github.com/pytorch/pytorch/pull/136429#issuecomment-2403335147 ))
2024-10-09 20:08:01 +00:00
90bed32b98
Introduce torch.sym_sum ( #136429 )
...
Partially addresses https://github.com/pytorch/pytorch/issues/128150
When you have big sums of values, we end up computing long chains of
binary addition in our FX graph representation. Not only is this ugly,
it also is quadratic, as the sympy.Add constructor is O(N) in number
of arguments. Instead, ensure that we maintain the summation as a
single FX node so we can do the entire addition all in one go.
update_hint_regression benchmark, before and after:
```
update_hint_regression,compile_time_instruction_count,2648328980
update_hint_regression,compile_time_instruction_count,2563748678
```
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136429
Approved by: https://github.com/isuruf
2024-10-08 18:12:57 +00:00
695291be2f
Fix test flakiness due to not resetting state ( #134058 )
...
Fixes https://github.com/pytorch/pytorch/issues/133994
Pull Request resolved: https://github.com/pytorch/pytorch/pull/134058
Approved by: https://github.com/yanboliang
2024-08-21 11:54:08 +00:00
48ee0984ac
Add C API to return all torch function disablement status ( #133136 )
...
This PR adds a C function to check if all torch function is disabled.
Recall that there are three torch function enablement states:
* All disabled
* Torch Function Subclass disabled
* All enabled
The API before this change provides two functions:
* `_is_torch_function_enabled` - returns True iff the current TF state is All enabled
* `_is_torch_function_mode_enabled` - returns True iff the state is not All disabled and the torch function mode stack is non-empty.
The crux of why a new API is needed is the following: If dynamo enters a frame with the torch function mode stack empty, `_is_torch_function_enabled` == False, it is impossible to determine if after a new mode is pushed whether we should enter the mode or not. This is because we don't know if the enablement state is All disabled or only subclass disabled. Adding this API to check if All disabled is True allows us to disambiguate this case.
In the next PR, Dynamo InstructionTranslator will have clearer flags than the underlying C API:
* A flag to indicate if subclasses are disabled (ie All disabled or Subclass Disabled is the current state)
* A flag to indicate if modes are disabled (ie if All disabled is the current state)
* A symbolic stack which can be checked if any modes are present
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133136
Approved by: https://github.com/bdhirsh
ghstack dependencies: #133130 , #133729 , #133131 , #133132 , #133133 , #133134
2024-08-20 07:15:04 +00:00
f147349568
Fix DeviceContext bug ( #133729 )
...
Fixes https://github.com/pytorch/pytorch/issues/133666
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133729
Approved by: https://github.com/bdhirsh
ghstack dependencies: #133130
2024-08-20 07:14:37 +00:00
b7bcfdaff2
Change deprecate warning on dispatch_on_subclass to warn once ( #132374 )
...
Summary:
# Problem
`TORCH_WARN` can cause massive log spam.
I output the logs for before and after adding this change.
*Before:*
* The log file size was ~61.15 MB(61148028 bytes).
*After:*
* The log filesize was ~56.44 MB(56444057) bytes.
# Context
Looks like we tried to land this change earlier but it was reverted:
* D59413413
* Reverted https://github.com/pytorch/pytorch/pull/130047 on behalf of https://github.com/clee2000 due to broke test_overrides.py::TestTorchFunctionWarning::test_warn_on_invalid_torch_function
# Testing Update
`test_warn_on_invalid_torch_function` would fail because the warning would not be called on the handling of the second torch function class since `TORCH_WARN_ONCE` stops repeats globally.
Updated so that it runs separate programs. (Was not able to actually run the test, could someone help me with that
Test Plan: Need help with this...
Differential Revision: D60561181
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132374
Approved by: https://github.com/ezyang
2024-08-05 20:02:33 +00:00
e8645fa2b9
[Doc] fix some typos (found by codespell and typos) ( #132544 )
...
Applying doc fixes from PR https://github.com/pytorch/pytorch/pull/127267 - with CLA
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132544
Approved by: https://github.com/kit1980
2024-08-05 17:21:56 +00:00
4d7bf72d93
[BE][Easy] fix ruff rule needless-bool (SIM103) ( #130206 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/130206
Approved by: https://github.com/malfet
2024-07-14 08:17:52 +00:00
2129903aa3
Properly detect nested torch function args ( #127496 )
...
Dynamo was not detecting nested torch function classes in containers. This was due to pytree compatibility for variable trackers being removed.
Fixes https://github.com/pytorch/pytorch/issues/127174
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127496
Approved by: https://github.com/anijain2305
2024-06-02 03:43:22 +00:00
392dc45597
Made FlexAttention rewrite getitem calls to use aten.index in score_mod ( #124799 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/124799
Approved by: https://github.com/drisspg
ghstack dependencies: #124444
2024-04-26 17:22:13 +00:00
e913f77c60
Revert "Made FlexAttention rewrite getitem calls to use aten.index in score_mod ( #124799 )"
...
This reverts commit 9bccafc31c9d489b727155e95633efd19adbceaa.
Reverted https://github.com/pytorch/pytorch/pull/124799 on behalf of https://github.com/clee2000 due to broke tests but only on crossref https://github.com/pytorch/pytorch/actions/runs/8841521519/job/24279075171 , added no td label so itll actually run this time ([comment](https://github.com/pytorch/pytorch/pull/124799#issuecomment-2078530797 ))
2024-04-26 02:35:14 +00:00
9bccafc31c
Made FlexAttention rewrite getitem calls to use aten.index in score_mod ( #124799 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/124799
Approved by: https://github.com/drisspg
ghstack dependencies: #124444
2024-04-26 01:02:28 +00:00
678662a557
Revert "Made FlexAttention rewrite getitem calls to use aten.index in score_mod ( #124799 )"
...
This reverts commit acc4cbea395c25410c26d6fd3c88c072ce24c918.
Reverted https://github.com/pytorch/pytorch/pull/124799 on behalf of https://github.com/jeanschmidt due to checking if this diff introduced regressions on linux-focal-py3.11-clang10 and linux-focal-py3.8-clang10 ([comment](https://github.com/pytorch/pytorch/pull/124799#issuecomment-2076756876 ))
2024-04-25 09:29:57 +00:00
acc4cbea39
Made FlexAttention rewrite getitem calls to use aten.index in score_mod ( #124799 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/124799
Approved by: https://github.com/drisspg
2024-04-25 06:19:55 +00:00
93e249969b
[BE] enable ruff rule RSE and remove useless parentheses in raise statements ( #124261 )
...
Remove useless parentheses in `raise` statements if the exception type is raised with no argument.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/124261
Approved by: https://github.com/albanD
2024-04-17 19:29:34 +00:00
fb90b4d4b2
[TorchGen] Use std::optional in generated code ( #121454 )
...
This PR changes TorchGen to generate std::optional.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/121454
Approved by: https://github.com/ezyang
2024-03-29 14:11:09 +00:00
3fe437b24b
[BE]: Update flake8 to v6.1.0 and fix lints ( #116591 )
...
Updates flake8 to v6.1.0 and fixes a few lints using sed and some ruff tooling.
- Replace `assert(0)` with `raise AssertionError()`
- Remove extraneous parenthesis i.e.
- `assert(a == b)` -> `assert a == b`
- `if(x > y or y < z):`->`if x > y or y < z:`
- And `return('...')` -> `return '...'`
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/116591
Approved by: https://github.com/albanD , https://github.com/malfet
2024-01-03 06:04:44 +00:00
460fc9da62
Disabled UserWarnings for some public functions in torch.overrides ( #109890 )
...
Fixes #109842 .
This disables the implicit `UserWarning`s that were raised for deprecated `torch` attributes. The filtering was designed to be as specific as possible, in order to not filter any other warnings that may be raised.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/109890
Approved by: https://github.com/ezyang
2023-09-23 20:40:04 +00:00
e40d6ae0a7
Improve torch.cuda.amp type hints ( #108630 )
...
Fixes #108629
1. Add the following to their modules' `__all__` so that pyright considers them to be publicly exported:
* [`torch.autocast`](https://pytorch.org/docs/stable/amp.html#torch.autocast )
* [`torch.cuda.amp.GradScaler`](https://pytorch.org/docs/stable/amp.html#torch.cuda.amp.GradScaler )
* [`torch.cuda.amp.autocast`](https://pytorch.org/docs/stable/amp.html#torch.cuda.amp.autocast )
* [`torch.cuda.amp.custom_fwd`](https://pytorch.org/docs/stable/amp.html#torch.cuda.amp.custom_fwd )
* [`torch.cuda.amp.custom_bwd`](https://pytorch.org/docs/stable/amp.html#torch.cuda.amp.custom_bwd )
2. Add `overload`s for `torch.cuda.amp.GradScaler.scale` to differentiate when a `torch.Tensor` is returned vs. an `Iterable[torch.Tensor]` is returned based on the type of the `outputs` parameter.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/108630
Approved by: https://github.com/ezyang
2023-09-08 06:06:25 +00:00
5a9e82fa02
let torch.device be overrideable by TorchFunctionMode ( #106514 )
...
Fixes #103828
let torch.device be overrideable by TorchFunctionMode
Pull Request resolved: https://github.com/pytorch/pytorch/pull/106514
Approved by: https://github.com/ezyang
2023-08-04 10:47:43 +00:00
73e1455327
[BE] Enable ruff's UP rules and autoformat test/ ( #105434 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105434
Approved by: https://github.com/albanD
2023-07-19 20:36:06 +00:00
68cb06c752
Make gen_annotated_args support kwargs ( #98396 )
...
This PR is to address the issue seeing in PR #97417 where the newly added op requires `kwargs`, however, currently tools/autograd/gen_annotated_fn_args.py does not support `kwargs`, only `func_args` are generated for test_overrides.py.
The PR adds a new field "is_kwargs" to each argument indicating whether it's a `kwargs` or not. See example:
```
annotated_args = {
torch._C._VariableFunctions._cast_Byte: [{'is_kwarg_only': 'False', 'name': 'self', 'simple_type': 'Tensor'}],
...
```
The full comparison of the generated file `annotated_fn_args.py` can be found here:
- **Before**: [P681991116](https://www.internalfb.com/phabricator/paste/view/P681991116 )
- **After**: [P681994218](https://www.internalfb.com/intern/paste/P681994218/ )
Differential Revision: D44698310
Pull Request resolved: https://github.com/pytorch/pytorch/pull/98396
Approved by: https://github.com/ezyang
2023-04-06 19:42:26 +00:00
d0abc31428
Remove unnecessary retain_grad call from gradcheck ( #96923 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/96923
Approved by: https://github.com/albanD
2023-03-27 13:38:28 +00:00
8fce9a09cd
[BE]: pyupgrade Python to 3.8 - imports and object inheritance only ( #94308 )
...
Apply parts of pyupgrade to torch (starting with the safest changes).
This PR only does two things: removes the need to inherit from object and removes unused future imports.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/94308
Approved by: https://github.com/ezyang , https://github.com/albanD
2023-02-07 21:10:56 +00:00
4a4520e74b
Retire unsafe sparse tensor constructors in Python API ( #91331 )
...
This PR removes sparse tensor constructor functions `torch._sparse_coo/csr/csc/bsr/bsc/compressed_tensor_unsafe(...)` as unneeded. The equivalent functionality is provided via `torch.sparse_coo/csr/csc/bsr/bsc/compressed_tensor(..., check_invariants=False)`
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91331
Approved by: https://github.com/amjames , https://github.com/cpuhrsch
2023-01-18 08:55:22 +00:00
b8252e07c7
[Reland] add DisableTorchFunction that matches DisableTorchDispatch ( #88219 ) ( #92012 )
...
Reland of #88219
Closes #87990 . This implements a new disable guard that matches DisableTorchDispatch (disables all subclasses and modes)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/92012
Approved by: https://github.com/albanD
2023-01-12 01:27:47 +00:00
333540a458
Reland "Add torch.utils.device_mode" ( #91796 )
...
Original PR https://github.com/pytorch/pytorch/pull/91525
Signed-off-by: Edward Z. Yang <ezyangfb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91796
Approved by: https://github.com/albanD
2023-01-09 20:57:12 +00:00
9b415240d4
Revert "Reland "Add torch.utils.device_mode" ( #91796 )"
...
This reverts commit 81b5eff3c383f5308416e129861a2689d717702c.
Reverted https://github.com/pytorch/pytorch/pull/91796 on behalf of https://github.com/huydhn due to This breaks trunk with the following failed test https://hud.pytorch.org/failure/test_jit_save%2CTestTracer
2023-01-09 04:45:47 +00:00
81b5eff3c3
Reland "Add torch.utils.device_mode" ( #91796 )
...
Original PR https://github.com/pytorch/pytorch/pull/91525
Signed-off-by: Edward Z. Yang <ezyangfb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91796
Approved by: https://github.com/albanD
2023-01-08 03:44:56 +00:00
f571ae4fdb
Revert "Make torch.device usable as a context manager ( #91525 )"
...
This reverts commit 619d52a5d296bc236ac98f40c7f7de54ab7c9d37.
Reverted https://github.com/pytorch/pytorch/pull/91525 on behalf of https://github.com/mehtanirav due to Internal breakages
2023-01-05 21:34:50 +00:00
a7749ae177
[reland] rename DisableTorchFunction to DisableTorchFunctionSubclass ( #88218 ) ( #89221 )
...
Summary: First half of #87990 . This doesn't change any of the behavior and is just a rename
#88218 got reverted for internal breakages. This is the reland of started from internal
Differential Revision:
D41268423
LaMa Project: L1098534
Pull Request resolved: https://github.com/pytorch/pytorch/pull/89221
Approved by: https://github.com/meliy-meyada , https://github.com/zou3519
2023-01-04 18:32:49 +00:00
619d52a5d2
Make torch.device usable as a context manager ( #91525 )
...
Fixes https://github.com/pytorch/pytorch/issues/82296
Fixes https://github.com/pytorch/pytorch/issues/27878
Fixes https://github.com/pytorch/pytorch/issues/260
Signed-off-by: Edward Z. Yang <ezyang@fb.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91525
Approved by: https://github.com/albanD
2023-01-04 01:32:00 +00:00
