36871622f1
[2/N] Mark unused parameters in C++ code ( #165121 )
...
This is follow-up of #164912 to mark unused C++ parameters to improve code readability.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165121
Approved by: https://github.com/Skylion007
2025-10-15 03:04:39 +00:00
38ed608956
Better error handling in torch/nativert/* ( #163308 )
...
Replace the **runtime_error** of the vallina C++ exceptions with **TORCH_CEHCK** in **torch/nativert/***
The vallina C++ exception should not exist in the core part of pytorch for its corss-languanges trait. Comparing with the vallina C++ exceptions, TORCH_CHECK have the richer error context and It has the unified error handling mechanism. This commit replace the runtime_error with TORCH_CHECK of the files in
torch/nativert/* .
Fixes part of #148114
Pull Request resolved: https://github.com/pytorch/pytorch/pull/163308
Approved by: https://github.com/dolpm
2025-09-28 14:23:44 +00:00
48bedd753d
Revert "Fix usage of forwarding references ( #161094 )"
...
This reverts commit 1ebd70d0c0d562d3be9abdee2a21906584af7d99.
Reverted https://github.com/pytorch/pytorch/pull/161094 on behalf of https://github.com/jeanschmidt due to checking if revert will fix https://github.com/pytorch/pytorch/actions/runs/17470601839/job/49621447581 ([comment](https://github.com/pytorch/pytorch/pull/161094#issuecomment-3255541480 ))
2025-09-04 20:35:41 +00:00
1ebd70d0c0
Fix usage of forwarding references ( #161094 )
...
I found a number of places that seem to want forwarding
references but the type signature does not reflect that
Pull Request resolved: https://github.com/pytorch/pytorch/pull/161094
Approved by: https://github.com/malfet
2025-09-04 16:34:39 +00:00
db259bd6b8
[BE][12/16] fix typos in torch/ ( #156602 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156602
Approved by: https://github.com/justinchuby , https://github.com/albanD
ghstack dependencies: #156318 , #156320
2025-07-02 22:55:29 +00:00
f8010e7b93
[nativert] Move file_util to pytorch core ( #153162 )
...
Summary: fbcode//sigmoid/core/common -> fbcode//caffe2/torch/nativert/common
Test Plan: Github CI
Differential Revision: D74328089
Pull Request resolved: https://github.com/pytorch/pytorch/pull/153162
Approved by: https://github.com/zhxchen17
2025-05-27 03:42:47 +00:00
