4a019047ad
Enable nested namespace check in clang-tidy ( #118506 )
...
It is time to enable nested namespaces in the code.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/118506
Approved by: https://github.com/albanD
2024-01-31 00:32:35 +00:00
3ae42cb7db
adjust header inclusions in C10 as sugguested by IWYU ( #102467 )
...
This PR aims to reduce unused header inclusions in C10.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/102467
Approved by: https://github.com/albanD
2023-05-31 19:19:10 +00:00
8cfc74400a
[PyTorch] Gate tls_local_dispatch_key_set off on iOS too ( #64753 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/64753
This may possibly be causing problems on iOS. (Maybe we should just revert inlining access to this thing? Really don't understand what's wrong with it, though.)
ghstack-source-id: 137830520
Test Plan: CI
Reviewed By: iseeyuan
Differential Revision: D30826897
fbshipit-source-id: 0438dee9d49e7601c26cdca0e8540229c777eddb
2021-09-13 10:54:28 -07:00
a9b0a921d5
Disable avoid-non-const-global-variables lint check ( #62008 )
...
Summary:
As GoogleTest `TEST` macro is non-compliant with it as well as `DEFINE_DISPATCH`
All changes but the ones to `.clang-tidy` are generated using following script:
```
for i in `find . -type f -iname "*.c*" -or -iname "*.h"|xargs grep cppcoreguidelines-avoid-non-const-global-variables|cut -f1 -d:|sort|uniq`; do sed -i "/\/\/ NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)/d" $i; done
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/62008
Reviewed By: driazati, r-barnes
Differential Revision: D29838584
Pulled By: malfet
fbshipit-source-id: 1b2f8602c945bd4ce50a9bfdd204755556e31d13
2021-07-22 18:04:40 -07:00
0ecdbfebff
s/InplaceOrView/ADInplaceOrView/g ( #57372 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/57372
Pull Request resolved: https://github.com/pytorch/pytorch/pull/57324
Test Plan: Imported from OSS
Reviewed By: ZolotukhinM
Differential Revision: D28121821
Pulled By: ailzhang
fbshipit-source-id: f568dd2505f6279da9ffb93ce1d22e0f98c606bb
2021-05-01 22:56:18 -07:00
44cc873fba
[PyTorch] Autoformat c10 ( #56830 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56830
Opt into formatting on GitHub and format everything. This is a trial run before turning on formatting for more and eventually all of the codebase.
Test Plan: CI
Reviewed By: zertosh
Differential Revision: D27979080
fbshipit-source-id: a80f0c48691c08ae8ca0af06377b87e6a2351151
2021-04-30 21:23:28 -07:00
087049000b
Make c10 clang-tidy clean ( #55870 )
...
Summary:
This change was autogenerated by running:
```
% find c10 -iname "*.cpp" -exec python3 tools/clang_tidy.py -c build -x {} -s \;
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/55870
Reviewed By: janeyx99
Differential Revision: D27728617
Pulled By: malfet
fbshipit-source-id: bede4d7f0c106d51394d1e9efddf01bf894421c5
2021-04-14 11:23:28 -07:00
a4125876c9
Move BackendSelect to default_included_set. ( #55117 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/55117
Test Plan: Imported from OSS
Reviewed By: bhosmer
Differential Revision: D27490571
Pulled By: ailzhang
fbshipit-source-id: a0d8a25a8217a754061fbf3b8e31cc1cf2d3bdea
2021-04-01 09:38:07 -07:00
43d4f3b8d0
Implement public API InferenceMode and its error handling ( #55008 )
...
Summary:
https://www.internalfb.com/phabricator/paste/view/P360377337Pull Request resolved: https://github.com/pytorch/pytorch/pull/53343
For easier review, here's a diff between the version before revert. https://www.internalfb.com/phabricator/paste/view/P360750919
Pull Request resolved: https://github.com/pytorch/pytorch/pull/55008
Test Plan: Imported from OSS
Pulled By: ailzhang
Reviewed By: bhosmer
Differential Revision: D27443229
fbshipit-source-id: 01b03446a1f6373f43dd5c7170d26226b50f363c
2021-03-31 10:48:00 -07:00
263180d7fc
Revert D26973911: Implement public API InferenceMode and its error handling
...
Test Plan: revert-hammer
Differential Revision:
D26973911 (7caa464631
2021-03-29 11:17:49 -07:00
7caa464631
Implement public API InferenceMode and its error handling ( #53343 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/53343
Test Plan: Imported from OSS
Reviewed By: ezyang, nikithamalgifb
Differential Revision: D26973911
Pulled By: ailzhang
fbshipit-source-id: 0ebdac7a3cd554822d26d5a40f539b6e2aaec61d
2021-03-27 13:44:23 -07:00
1e0809dbf9
[PyTorch] Remove CAFFE2_FB_LIMITED_MOBILE_CAPABILITY ( #50385 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/50385
We no longer use this flag internally, and it's not referenced externally either, so let's clean up.
ghstack-source-id: 119676743
Test Plan: CI
Reviewed By: ezyang
Differential Revision: D25852220
fbshipit-source-id: a4427edff6cbb241340f9f6ae6db4e74832949c2
2021-01-20 10:26:54 -08:00
b54240d200
[PyTorch] Gate tls_local_dispatch_key_set inlining off for Android ( #50450 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/50450
See comment, seems to break things.
ghstack-source-id: 119753229
Test Plan: CI
Reviewed By: ljk53
Differential Revision: D25892759
fbshipit-source-id: 3b34a384713c77aa28b1ef5807828a08833fd86f
2021-01-12 23:32:12 -08:00
dde5b6e177
[PyTorch] Reapply D25547962: Make tls_local_dispatch_key_set inlineable (reapply) ( #49763 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/49763
This was reverted because it landed in a stack together with
D25542799 (9ce1df079f
2021-01-06 14:41:43 -08:00
19dc5e94a6
Revert D25547962: [PyTorch] Make tls_local_dispatch_key_set inlineable (reapply)
...
Test Plan: revert-hammer
Differential Revision:
D25547962 (6f928a4a53
2020-12-17 16:38:40 -08:00
6f928a4a53
[PyTorch] Make tls_local_dispatch_key_set inlineable (reapply) ( #49412 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/49412
FLAGS_disable_variable_dispatch had to go, but it looks like the only user was some benchmarks anyway.
ghstack-source-id: 118669590
Test Plan:
Small (order of 0.1% improvement) on Internal benchmarks. Wait for
GitHub CI since this was reverted before due to CI break
Reviewed By: ezyang
Differential Revision: D25547962
fbshipit-source-id: 58424b1da230fdc5d27349af762126a5512fce43
2020-12-16 16:04:35 -08:00
6820745e28
Revert D25489030: [PyTorch] Make tls_local_dispatch_key_set inlineable
...
Test Plan: revert-hammer
Differential Revision:
D25489030 (be849ed1fd
2020-12-14 12:45:26 -08:00
be849ed1fd
[PyTorch] Make tls_local_dispatch_key_set inlineable ( #49264 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/49264
FLAGS_disable_variable_dispatch had to go, but it looks like the only user was some benchmarks anyway.
ghstack-source-id: 118480532
Test Plan: Small (order of 0.1% improvement) on Internal benchmarks
Reviewed By: smessmer
Differential Revision: D25489030
fbshipit-source-id: 63147bae783e7a45391dd70d86730e48d3e0cafc
2020-12-14 11:17:35 -08:00
a47e3697ab
Use iterator of DispatchKeySet. ( #44682 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/44682
Test Plan: Imported from OSS
Reviewed By: ezyang
Differential Revision: D23698387
Pulled By: ailzhang
fbshipit-source-id: 4fa140db9254c2c9c342bf1c8dfd952469b0b779
2020-09-18 13:34:27 -07:00
4aacfab221
Resolve Autograd key for disable_variable_dispatch flag. ( #44268 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/44268
Test Plan: Imported from OSS
Reviewed By: ngimel
Differential Revision: D23561042
Pulled By: ailzhang
fbshipit-source-id: 6f35cd9a543bea3f9e294584f1db7c3622ebb741
2020-09-08 21:27:52 -07:00
b6810c1064
Include/ExcludeDispatchKeySetGuard API ( #42658 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/42658
Test Plan: Imported from OSS
Reviewed By: ezyang
Differential Revision: D22971426
Pulled By: bhosmer
fbshipit-source-id: 4d63e0cb31745e7b662685176ae0126ff04cdece
2020-08-08 16:27:05 -07:00
1f689b6ef9
suppress all Autograd keys in AutoNonVariableTypeMode ( #42610 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/42610
Fix for https://github.com/pytorch/pytorch/issues/42609 : `AutoNonVariableTypeMode` should suppress all autograd dispatch keys, not just `Autograd` (e.g. `XLAPreAutograd`, `PrivateUse<N>_PreAutograd`)
Test Plan: Imported from OSS
Reviewed By: ezyang
Differential Revision: D22963408
Pulled By: bhosmer
fbshipit-source-id: 2f3516580ce0c9136aff5e025285d679394f2f18
2020-08-06 13:15:42 -07:00
dd64e738c5
Expunge TensorId from all DispatchKey names. ( #36240 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/36240
It's annoying, historical, and unnecessary (enum class is already
namespaced). I did this codemod with:
```
git grep -l 'CPUTensorId' | xargs sed -i 's/CPUTensorId/CPU/g'
git grep -l 'CUDATensorId' | xargs sed -i 's/CUDATensorId/CUDA/g'
git grep -l 'VariableTensorId' | xargs sed -i 's/VariableTensorId/Autograd/g'
git grep -l 'HIPTensorId' | xargs sed -i 's/HIPTensorId/HIP/g'
git grep -l 'MSNPUTensorId' | xargs sed -i 's/MSNPUTensorId/MSNPU/g'
git grep -l 'XLATensorId' | xargs sed -i 's/XLATensorId/XLA/g'
git grep -l 'PrivateUse1_TensorId' | xargs sed -i 's/PrivateUse1_TensorId/PrivateUse1/g'
git grep -l 'PrivateUse2_TensorId' | xargs sed -i 's/PrivateUse2_TensorId/PrivateUse2/g'
git grep -l 'PrivateUse3_TensorId' | xargs sed -i 's/PrivateUse3_TensorId/PrivateUse3/g'
git grep -l 'AutocastTensorId' | xargs sed -i 's/AutocastTensorId/Autocast/g'
git grep -l '_PreAutogradTensorId' | xargs sed -i 's/_PreAutogradTensorId/_PreAutograd/g'
git grep -l 'TESTING_ONLY_GenericWrapperTensorId' | xargs sed -i 's/TESTING_ONLY_GenericWrapperTensorId/TESTING_ONLY_GenericWrapper/g'
git grep -l 'TESTING_ONLY_GenericModeTensorId' | xargs sed -i 's/TESTING_ONLY_GenericModeTensorId/TESTING_ONLY_GenericMode/g'
```
Then I did a git grep for remaining TensorId occurrences, and manually
killed those (mostly in codegen, and some docs that needed updating).
Signed-off-by: Edward Z. Yang <ezyang@fb.com >
Test Plan: Imported from OSS
Differential Revision: D20929255
Pulled By: ezyang
fbshipit-source-id: dc371b6aa6e6ea7c0a5660137c14debde806a09d
2020-04-13 23:33:44 -07:00
a5bfcc5323
Unify management of thread local settings ( #35523 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/35523
In this PR we extend ThreadLocalState to cover dispatch keys and
ThreadLocalDebugInfo and move it from JIT interpreter down to
thread management (at::launch) and autograd (backward threads) code
Test Plan: unit tests (CI)
Reviewed By: dzhulgakov
Differential Revision: D20615714
fbshipit-source-id: 16a9fc96a25cb6c2629230b1187fbf78786ac565
2020-04-01 01:56:39 -07:00
0f0271e255
[RELAND2] Eager autocasting, out-of-place ops only (with MSVC 2017 fix) ( #35102 )
...
Summary:
This is the second reland attempt for https://github.com/pytorch/pytorch/pull/32140 .
The first reland attempt https://github.com/pytorch/pytorch/pull/35011 failed due a [small incompatible change](https://github.com/pytorch/pytorch/pull/35011#issuecomment-601754216 ) in recent master (`skipIfRocm` was removed from `test_data_parallel.py`).
The present PR restores skipIfRocm.
Description from first reland attempt https://github.com/pytorch/pytorch/pull/35011 :
> https://github.com/pytorch/pytorch/pull/32140 was approved and merged, but [reverted](d0577e19f0https://developercommunity.visualstudio.com/content/problem/27729/allow-function-with-internal-linkage-as-template-n.html ), fixed in versions 15.8 and newer.
>
> The present PR reverts the revert (restoring https://github.com/pytorch/pytorch/pull/32140 's diffs) and adds a workaround to enable compilation with VS < 15.8. The workaround isn't pretty, but it's guarded by macros such that it's only used when compiling with VS < 15.8. All other builds compile with the same code/control flow as was merged in https://github.com/pytorch/pytorch/pull/32140 .
>
> Original description of https://github.com/pytorch/pytorch/pull/32140 :
> > Initial integration of eager autocasting, supporting out-of-place ops only for easier review.
> Relevant issue/RFC: https://github.com/pytorch/pytorch/issues/25081
>
> > In-place ops and ops with user-supplied out=... can certainly be supported as well (my initial WIP https://github.com/pytorch/pytorch/issues/29552 handled many) but require substantially more complex special casing in the autocasting backend and tests. Support for these ops (much of which has already been written) will be broken into later PRs.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/35102
Differential Revision: D20596918
Pulled By: ezyang
fbshipit-source-id: 60caa279bb0ce4a9bb0b28c1d585d42cf1cc7e50
2020-03-24 09:08:04 -07:00
fe276d541e
Revert D20541921: [pytorch][PR] [RELAND] Eager autocasting, out-of-place ops only (with MSVC 2017 fix)
...
Test Plan: revert-hammer
Differential Revision:
D20541921
Original commit changeset: abb5488dca86
fbshipit-source-id: d2c6038978f80e5429632f8b49107090a8a247f4
2020-03-19 22:39:12 -07:00
991b97277a
[RELAND] Eager autocasting, out-of-place ops only (with MSVC 2017 fix) ( #35011 )
...
Summary:
https://github.com/pytorch/pytorch/pull/32140 was approved and merged, but [reverted](d0577e19f0https://developercommunity.visualstudio.com/content/problem/27729/allow-function-with-internal-linkage-as-template-n.html ), fixed in versions 15.8 and newer.
The present PR reverts the revert (restoring https://github.com/pytorch/pytorch/pull/32140 's diffs) and adds a workaround to enable compilation with VS < 15.8. The workaround isn't pretty, but it's guarded by macros such that it's only used when compiling with VS < 15.8. All other builds compile with the same code/control flow as was merged in https://github.com/pytorch/pytorch/pull/32140 .
Original description of https://github.com/pytorch/pytorch/pull/32140 :
> Initial integration of eager autocasting, supporting out-of-place ops only for easier review.
Relevant issue/RFC: https://github.com/pytorch/pytorch/issues/25081
> In-place ops and ops with user-supplied out=... can certainly be supported as well (my initial WIP https://github.com/pytorch/pytorch/issues/29552 handled many) but require substantially more complex special casing in the autocasting backend and tests. Support for these ops (much of which has already been written) will be broken into later PRs.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/35011
Differential Revision: D20541921
Pulled By: ezyang
fbshipit-source-id: abb5488dca8620b0daac4306ebf2bb47fc36e4f5
2020-03-19 20:18:18 -07:00
d0577e19f0
Revert D20346700: [pytorch][PR] Eager autocasting, out-of-place ops only
...
Test Plan: revert-hammer
Differential Revision:
D20346700
Original commit changeset: 12d77b391731
fbshipit-source-id: 108d72bf24232f443c0be293ec932c0c478d6a60
2020-03-18 11:42:51 -07:00
aaa8f02156
Eager autocasting, out-of-place ops only ( #32140 )
...
Summary:
Initial integration of eager autocasting, supporting out-of-place ops only for easier review.
Relevant issue/RFC: https://github.com/pytorch/pytorch/issues/25081
In-place ops and ops with user-supplied `out=...` can certainly be supported as well (my initial WIP https://github.com/pytorch/pytorch/pull/29552 handled many) but require substantially more complex special casing in the autocasting backend and tests. Support for these ops (much of which has already been written) will be broken into later PRs.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/32140
Differential Revision: D20346700
Pulled By: ezyang
fbshipit-source-id: 12d77b3917310186fbddf11c59b2794dc859131f
2020-03-18 10:28:21 -07:00
690d41f24e
Centralize addition of "always on" dispatch keys. ( #32734 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/32734
VariableTensorId is the only key with this treatment today,
but BackendSelect and CompoundOp are coming soon.
Signed-off-by: Edward Z. Yang <ezyang@fb.com >
Test Plan: Imported from OSS
Differential Revision: D19628091
Pulled By: ezyang
fbshipit-source-id: 250753f90528fa282af7a18d8d2f7736382754bd
2020-01-30 11:49:40 -08:00
5ddd2cd92b
Make DispatchKeyGuards accept DispatchKey::Undefined ( #32729 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/32729
When working on the vmap prototype I noticed that this was helpful
as it lets me easily initialize a no-op guard, if I need to do it
at constructor time (which I usually do, because the guards don't
have move constructors).
Signed-off-by: Edward Z. Yang <ezyang@fb.com >
Test Plan: Imported from OSS
Differential Revision: D19628092
Pulled By: ezyang
fbshipit-source-id: d6259a3f70d287cdac2e4a5f3984e2880f19bdc2
2020-01-30 11:49:35 -08:00
62b06b9fae
Rename TensorTypeId to DispatchKey ( #32154 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/32154
TensorTypeId -> DispatchKey
c10/core/TensorTypeId.h -> c10/core/DispatchKey.h
c10/core/TensorTypeId.cpp -> c10/core/DispatchKey.cpp
TensorTypeId::* -> DispatchKey::*
TensorTypeId type_id -> DispatchKey dispatch_key
type_id -> dispatch_key
TensorTypeId::NumTensorIds -> DispatchKey::NumDispatchKeys
RealTensorTypeId -> RealDispatchKey
TensorTypeSet -> DispatchKeySet
TensorTypeIds -> DispatchKeys
c10/core/TensorTypeSet.h -> c10/core/DispatchKeySet.h
c10/core/TensorTypeSet.cpp -> c10/core/DispatchKeySet.cpp
type_set() -> key_set()
type_set_ -> key_set_
typeSet -> keySet
ExcludeTensorTypeIdGuard -> ExcludeDispatchKeyGuard
IncludeTensorTypeIdGuard -> IncludeDispatchKeyGuard
LocalTensorTypeSet -> LocalDispatchKeySet
c10/core/impl/LocalTensorTypeSet.h -> c10/core/impl/LocalDispatchKeySet.h
c10/core/impl/LocalTensorTypeSet.cpp -> c10/core/impl/LocalDispatchKeySet.cpp
tls_local_tensor_type_set -> tls_local_dispatch_key_set
tls_is_tensor_type_id_excluded -> tls_is_dispatch_key_excluded
tls_set_tensor_type_id_excluded -> tls_set_dispatch_key_excluded
tls_is_tensor_type_id_included -> tls_is_dispatch_key_included
tls_set_tensor_type_id_included -> tls_set_dispatch_key_included
MultiDispatchTensorTypeSet -> MultiDispatchKeySet
multi_dispatch_tensor_type_set -> multi_dispatch_key_set
tensorTypeIdToBackend -> dispatchKeyToBackend
backendToTensorTypeId -> backendToDispatchKey
initForTensorTypeSet -> initForDispatchKeySet
inferred_type_set -> inferred_key_set
computeTensorTypeId -> computeDispatchKey
PODLocalTensorTypeSet raw_local_tensor_type_set -> PODLocalDispatchKeySet raw_local_dispatch_key_set
get_default_tensor_type_id -> get_default_dispatch_key
inferred_type_id -> inferred_dispatch_key
actual_type_id -> actual_dispatch_key
typeSetToDispatchKey_ -> dispatchKeySetToDispatchKey_
get_type_id() -> get_dispatch_key()
legacyExtractTypeId -> legacyExtractDispatchKey
extractTypeId -> extractDispatchKey
Test Plan: Imported from OSS
Differential Revision: D19398900
Pulled By: pbelevich
fbshipit-source-id: 234ad19f93d33e00201b61e153b740a339035776
2020-01-15 11:16:08 -08:00
