17ab99463a
[Easy] Add notes for setting up dev venv with specific Python version ( #164214 )
...
Resolves https://github.com/pytorch/pytorch/issues/164010#issuecomment-3340751377
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164214
Approved by: https://github.com/ezyang
ghstack dependencies: #162324
2025-10-01 08:25:13 +00:00
eca6ac2293
[BE][Easy] update CUDA and ROCm sources in nightly tool ( #162324 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/162324
Approved by: https://github.com/ezyang
2025-10-01 08:25:13 +00:00
f1260c9b9a
[ROCm][CI/CD] upgrade nightly wheels to ROCm 7.0 ( #163937 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/163937
Approved by: https://github.com/jeffdaily
Co-authored-by: Jeff Daily <jeff.daily@amd.com >
2025-09-26 21:42:09 +00:00
2040f00112
[BE][Easy] respect os.environ in subprocess calls in tools/nightly.py ( #159572 )
...
Respect parent shell's envvars, such as `UV_INDEX_STRATEGY`, `http{,s}_proxy`, etc.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/159572
Approved by: https://github.com/Skylion007
2025-08-01 20:40:31 +00:00
f903bc475c
[BE] add noqa for flake8 rule B036: found except BaseException without re-raising ( #159043 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/159043
Approved by: https://github.com/Skylion007
2025-07-25 02:56:34 +00:00
637e75433c
[BE] always use uv pip if possible in pip_init.py for lintrunner init ( #157199 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157199
Approved by: https://github.com/ezyang , https://github.com/ZainRizvi
2025-07-21 17:56:05 +00:00
cb711c8fa0
Revert "[BE] always use uv pip if possible in pip_init.py for lintrunner init ( #157199 )"
...
This reverts commit 754699610b0abec2fe3f5a73269b1dd09a330445.
Reverted https://github.com/pytorch/pytorch/pull/157199 on behalf of https://github.com/malfet due to It breaks lintrunner init` for default environments, see https://github.com/pytorch/pytorch/issues/152999 ([comment](https://github.com/pytorch/pytorch/pull/157199#issuecomment-3053279711 ))
2025-07-09 16:26:47 +00:00
754699610b
[BE] always use uv pip if possible in pip_init.py for lintrunner init ( #157199 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157199
Approved by: https://github.com/ezyang
2025-07-01 06:07:29 +00:00
c0ee01c2fb
tools/nightly.py: only download torch via pip and install dependenices via uv ( #156409 )
...
Setup time (cpu-only): 70s -> 27.6s -> 17.4s
The tool can setup the pinned NVIDIA dependencies correctly:
```console
$ make setup-env-cuda PYTHON="${HOMEBREW_PREFIX}/bin/python3.13" && source venv/bin/activate
make setup-env PYTHON="/home/linuxbrew/.linuxbrew/bin/python3.13" NIGHTLY_TOOL_OPTS="pull --cuda"
make[1]: Entering directory '/home/PanXuehai/Projects/pytorch'
/home/linuxbrew/.linuxbrew/bin/python3.13 tools/nightly.py pull --cuda
log file: /home/PanXuehai/Projects/pytorch/nightly/log/2025-06-19_21h16m16s_94cd1471-4d0f-11f0-b120-b88584c06696/nightly.log
Creating virtual environment
Removing existing venv: /home/PanXuehai/Projects/pytorch/venv
Creating venv (Python 3.13.4): /home/PanXuehai/Projects/pytorch/venv
Installing packages
Upgrading package(s) (https://download.pytorch.org/whl/nightly/cu128 ):
- uv
- pip
- setuptools
- packaging
- wheel
- build[uv]
Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple , https://download.pytorch.org/whl/nightly/cu128
Collecting uv
Using cached f2e96cec5e/uv-0.7.13-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl17031897da/setuptools-80.9.0-py3-none-any.whl38679034af/packaging-25.0-py3-none-any.whl87f3254fd8/wheel-0.45.1-py3-none-any.whl80633736cd/build-1.2.2.post1-py3-none-any.whl12818598c3/pyproject_hooks-1.2.0-py3-none-any.whlhttps://download.pytorch.org/whl/nightly/cu128 ): torch
Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple , https://download.pytorch.org/whl/nightly/cu128
Collecting torch
Using cached https://download.pytorch.org/whl/nightly/cu128/torch-2.8.0.dev20250619%2Bcu128-cp313-cp313-manylinux_2_28_x86_64.whl.metadata (30 kB)
Using cached https://download.pytorch.org/whl/nightly/cu128/torch-2.8.0.dev20250619%2Bcu128-cp313-cp313-manylinux_2_28_x86_64.whl (1040.3 MB)
Saved /tmp/pip-download-xeqmhrww/torch-2.8.0.dev20250619+cu128-cp313-cp313-manylinux_2_28_x86_64.whl
Successfully downloaded torch
Downloaded 1 file(s) to /tmp/pip-download-xeqmhrww:
- torch-2.8.0.dev20250619+cu128-cp313-cp313-manylinux_2_28_x86_64.whl
Downloading packages took 6.284 [s]
Unpacking wheel file
Unpacking to: /tmp/wheel-kugk2os0/torch-2.8.0.dev20250619+cu128...OK
Unpacking wheel file took 15.107 [s]
Installing dependencies
Installing packages
Installing package(s) (https://download.pytorch.org/whl/nightly/cu128 ):
- filelock
- typing-extensions>=4.10.0
- setuptools; python_version >= "3.12"
- sympy>=1.13.3
- networkx
- jinja2
- fsspec
- nvidia-cuda-nvrtc-cu12==12.8.93; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-cuda-runtime-cu12==12.8.90; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-cuda-cupti-cu12==12.8.90; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-cudnn-cu12==9.10.2.21; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-cublas-cu12==12.8.4.1; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-cufft-cu12==11.3.3.83; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-curand-cu12==10.3.9.90; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-cusolver-cu12==11.7.3.90; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-cusparse-cu12==12.5.8.93; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-cusparselt-cu12==0.7.1; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-nccl-cu12==2.27.3; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-nvshmem-cu12==3.2.5; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-nvtx-cu12==12.8.90; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-nvjitlink-cu12==12.8.93; platform_system == "Linux" and platform_machine == "x86_64"
- nvidia-cufile-cu12==1.13.1.3; platform_system == "Linux" and platform_machine == "x86_64"
- pytorch-triton==3.3.1+gitc8757738; platform_system == "Linux"
- numpy
- cmake
- ninja
- packaging
- ruff
- mypy
- pytest
- hypothesis
- ipython
- rich
- clang-format
- clang-tidy
- sphinx
Using Python 3.13.4 environment at: venv
Resolved 78 packages in 2.95s
Installed 76 packages in 93ms
+ alabaster==1.0.0
+ asttokens==3.0.0
+ attrs==24.2.0
+ babel==2.17.0
+ certifi==2024.8.30
+ charset-normalizer==3.3.2
+ clang-format==20.1.6
+ clang-tidy==20.1.0
+ cmake==3.25.0
+ decorator==5.2.1
+ docutils==0.21.2
+ executing==2.2.0
+ filelock==3.18.0
+ fsspec==2025.5.1
+ hypothesis==6.135.11
+ idna==3.10
+ imagesize==1.4.1
+ iniconfig==2.1.0
+ ipython==9.3.0
+ ipython-pygments-lexers==1.1.1
+ jedi==0.19.2
+ jinja2==3.1.6
+ markdown-it-py==3.0.0
+ markupsafe==2.1.5
+ matplotlib-inline==0.1.7
+ mdurl==0.1.2
+ mpmath==1.3.0
+ mypy==1.16.1
+ mypy-extensions==1.0.0
+ networkx==3.5
+ ninja==1.11.1.4
+ numpy==2.3.0
+ nvidia-cublas-cu12==12.8.4.1
+ nvidia-cuda-cupti-cu12==12.8.90
+ nvidia-cuda-nvrtc-cu12==12.8.93
+ nvidia-cuda-runtime-cu12==12.8.90
+ nvidia-cudnn-cu12==9.10.2.21
+ nvidia-cufft-cu12==11.3.3.83
+ nvidia-cufile-cu12==1.13.1.3
+ nvidia-curand-cu12==10.3.9.90
+ nvidia-cusolver-cu12==11.7.3.90
+ nvidia-cusparse-cu12==12.5.8.93
+ nvidia-cusparselt-cu12==0.7.1
+ nvidia-nccl-cu12==2.27.3
+ nvidia-nvjitlink-cu12==12.8.93
+ nvidia-nvshmem-cu12==3.2.5
+ nvidia-nvtx-cu12==12.8.90
+ parso==0.8.4
+ pathspec==0.12.1
+ pexpect==4.9.0
+ pluggy==1.6.0
+ prompt-toolkit==3.0.51
+ ptyprocess==0.7.0
+ pure-eval==0.2.3
+ pygments==2.19.1
+ pytest==8.4.1
+ pytorch-triton==3.3.1+gitc8757738
+ requests==2.32.3
+ rich==14.0.0
+ roman-numerals-py==3.1.0
+ ruff==0.12.0
+ snowballstemmer==3.0.1
+ sortedcontainers==2.4.0
+ sphinx==8.2.3
+ sphinxcontrib-applehelp==2.0.0
+ sphinxcontrib-devhelp==2.0.0
+ sphinxcontrib-htmlhelp==2.1.0
+ sphinxcontrib-jsmath==1.0.1
+ sphinxcontrib-qthelp==2.0.0
+ sphinxcontrib-serializinghtml==2.0.0
+ stack-data==0.6.3
+ sympy==1.14.0
+ traitlets==5.14.3
+ typing-extensions==4.14.0
+ urllib3==2.2.3
+ wcwidth==0.2.13
Installing packages took 3.080 [s]
Installing dependencies took 3.080 [s]
Pulling nightly PyTorch
Found released git version 5622038e20ddb12b9a011c9a9128190d71a21cba
Found nightly release version 2625c70aecc6eced1dbe108279feab7509733bef
Already up to date.
Pulling nightly PyTorch took 0.017 [s]
Moving nightly files into repo
Moving nightly files into repo took 4.898 [s]
Writing pytorch-nightly.pth
Writing pytorch-nightly.pth took 0.021 [s]
-------
PyTorch Development Environment set up!
Please activate to enable this environment:
$ source /home/PanXuehai/Projects/pytorch/venv/bin/activate
make[1]: Leaving directory '/home/PanXuehai/Projects/pytorch'
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156409
Approved by: https://github.com/ezyang
ghstack dependencies: #156408
2025-06-19 19:42:15 +00:00
71faa7e5b9
tools/nightly.py: use uv pip install instead of pip install ( #156408 )
...
Setup time: 70s -> 27.6s
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156408
Approved by: https://github.com/ezyang
2025-06-19 19:42:15 +00:00
a69785b3ec
[BE] fix typos in tools/ ( #156082 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156082
Approved by: https://github.com/soulitzer
ghstack dependencies: #156079
2025-06-17 19:25:50 +00:00
2cdcd16e83
[Easy] update pip sources for CUDA in nightly pull tool ( #149143 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/149143
Approved by: https://github.com/ezyang , https://github.com/cyyever
ghstack dependencies: #145685
2025-06-10 08:07:30 +00:00
0319044e92
[Easy] update pip sources for ROCm in nightly pull tool ( #145685 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145685
Approved by: https://github.com/ezyang
2025-06-10 08:07:30 +00:00
348fd45065
Support detached checkout in tools/nightly.py ( #154314 )
...
Prompt for Sonnet 3.7 in Claude Code: Only inspect tools/nightly.py, all
other files are irrelevant to your task. Do not use any shell commands.
Task: Add a --detach argument to this script which instead of making a
new branch just directly checks out the correct commit in detached mode.
With two interventions:
- Branch and detach are mutually exclusive. So you should consolidate
them into a single argument. Why don't we take over the 'None' option?
- Do you know that nightly_version is guaranteed to be a commit hash? It
seems it would be safer to explicitly pass --detach
I tested by running `python tools/nightly.py checkout` and observing
that my worktree was detached at this point.
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/154314
Approved by: https://github.com/XuehaiPan , https://github.com/malfet
2025-06-06 13:28:29 +00:00
3555ebb63d
[BE]: Update ruff to 0.11.8 ( #153249 )
...
Fixes a ton of false negatives throughout the codebase. RUFF also properly validates NOQA comments now and most of the changes are fixing typos there or removing filewide flake8 suppressions that were also silencing ruff issues.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/153249
Approved by: https://github.com/cyyever , https://github.com/albanD , https://github.com/seemethere
2025-05-12 18:30:52 +00:00
b4550541ea
[ROCm] upgrade nightly wheels to rocm6.4 ( #151355 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/151355
Approved by: https://github.com/jeffdaily
Co-authored-by: Jeff Daily <jeff.daily@amd.com >
2025-04-17 17:29:07 +00:00
ae74ef9d53
Set proper LD_LIBRARY_PATH on Linux in nightly venv in nightly pull tool ( #143262 )
...
Before this change:
```console
$ make setup-env-cuda PYTHON="${HOMEBREW_PREFIX}/bin/python3.12"
$ source venv/bin/activate
$ python3 -c 'import torch'
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/home/PanXuehai/Projects/pytorch/torch/__init__.py", line 379, in <module>
from torch._C import * # noqa: F403
^^^^^^^^^^^^^^^^^^^^^^
ImportError: libcudnn.so.9: cannot open shared object file: No such file or directory
```
This PR adds `site-packages/nvidia/**/lib` to `LD_LIBRARY_PATH` in `venv/bin/activate` script to let NVIDIA PyPI packages can be loaded correctly.
See also:
- #141837
Pull Request resolved: https://github.com/pytorch/pytorch/pull/143262
Approved by: https://github.com/malfet
2025-04-01 16:51:02 +00:00
d2f769476f
[Easy] add quotes to shell activation commands ( #143902 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/143902
Approved by: https://github.com/Skylion007 , https://github.com/malfet
2024-12-27 19:17:46 +00:00
c4bff71854
[Easy] Add ROCm support to nightly pull tool ( #141282 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/141282
Approved by: https://github.com/malfet
ghstack dependencies: #143263
2024-12-27 00:07:38 +00:00
51a7ecde80
[Easy] Bump CUDA nightly version to 11.8 / 12.4 / 12.6 in nightly pull tool ( #143263 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/143263
Approved by: https://github.com/malfet
2024-12-26 19:01:38 +00:00
82aaf64422
[3/N] Apply py39 ruff fixes ( #142115 )
...
Fixes #ISSUE_NUMBER
Pull Request resolved: https://github.com/pytorch/pytorch/pull/142115
Approved by: https://github.com/ezyang
2024-12-11 17:50:10 +00:00
2a6eaa2e6f
Refactor nightly pull tool to use venv and pip ( #141281 )
...
Resolves #141238
- #141238
Example output:
```console
$ python3.12 tools/nightly.py checkout -b my-nightly-branch -p my-env --python python3.10
log file: /Users/PanXuehai/Projects/pytorch/nightly/log/2024-11-22_04h15m45s_63f8b29e-a845-11ef-bbf9-32c784498a7b/nightly.log
Creating virtual environment
Creating venv (Python 3.10.15): /Users/PanXuehai/Projects/pytorch/my-env
Installing packages
Upgrading package(s) (https://download.pytorch.org/whl/nightly/cpu ): pip, setuptools, wheel
Installing packages took 5.576 [s]
Creating virtual environment took 9.505 [s]
Downloading packages
Downloading package(s) (https://download.pytorch.org/whl/nightly/cpu ): torch
Downloaded 9 file(s) to /var/folders/sq/7sf73d5s2qnb3w6jjsmhsw3h0000gn/T/pip-download-lty5dvz4:
- mpmath-1.3.0-py3-none-any.whl
- torch-2.6.0.dev20241121-cp310-none-macosx_11_0_arm64.whl
- jinja2-3.1.4-py3-none-any.whl
- sympy-1.13.1-py3-none-any.whl
- MarkupSafe-3.0.2-cp310-cp310-macosx_11_0_arm64.whl
- networkx-3.4.2-py3-none-any.whl
- fsspec-2024.10.0-py3-none-any.whl
- filelock-3.16.1-py3-none-any.whl
- typing_extensions-4.12.2-py3-none-any.whl
Downloading packages took 7.628 [s]
Installing dependencies
Installing packages
Installing package(s) (https://download.pytorch.org/whl/nightly/cpu ): numpy, cmake, ninja, packaging, ruff, mypy, pytest, hypothesis, ipython, rich, clang-format, clang-tidy, sphinx, mpmath-1.3.0-py3-none-any.whl, jinja2-3.1.4-py3-none-any.whl, sympy-1.13.1-py3-none-any.whl, MarkupSafe-3.0.2-cp310-cp310-macosx_11_0_arm64.whl, networkx-3.4.2-py3-none-any.whl, fsspec-2024.10.0-py3-none-any.whl, filelock-3.16.1-py3-none-any.whl, typing_extensions-4.12.2-py3-none-any.whl
Installing packages took 42.514 [s]
Installing dependencies took 42.515 [s]
Unpacking wheel file
Unpacking wheel file took 3.223 [s]
Checking out nightly PyTorch
Found released git version ac47a2d9714278889923ddd40e4210d242d8d4ee
Found nightly release version e0482fdf95eb3ce679fa442b50871d113ceb673b
Switched to a new branch 'my-nightly-branch'
Checking out nightly PyTorch took 0.198 [s]
Moving nightly files into repo
Linking /var/folders/sq/7sf73d5s2qnb3w6jjsmhsw3h0000gn/T/wheel-dljxil5i/torch-2.6.0.dev20241121/torch/_C.cpython-310-darwin.so -> /Users/PanXuehai/Projects/pytorch/torch/_C.cpython-310-darwin.so
Linking /var/folders/sq/7sf73d5s2qnb3w6jjsmhsw3h0000gn/T/wheel-dljxil5i/torch-2.6.0.dev20241121/torch/lib/libtorch_python.dylib -> /Users/PanXuehai/Projects/pytorch/torch/lib/libtorch_python.dylib
...
Linking /var/folders/sq/7sf73d5s2qnb3w6jjsmhsw3h0000gn/T/wheel-dljxil5i/torch-2.6.0.dev20241121/torch/include/c10/macros/Macros.h -> /Users/PanXuehai/Projects/pytorch/torch/include/c10/macros/Macros.h
Moving nightly files into repo took 11.426 [s]
Writing pytorch-nightly.pth
Writing pytorch-nightly.pth took 0.036 [s]
-------
PyTorch Development Environment set up!
Please activate to enable this environment:
$ source /Users/PanXuehai/Projects/pytorch/my-env/bin/activate
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/141281
Approved by: https://github.com/seemethere
2024-11-22 20:03:55 +00:00
ff2f751bfb
[tools] fix nightly pull tool when the conda environment not exists ( #138448 )
...
Now, `conda env remove --name env` exits with errors if the given environment does not exist. This PR check the existance of the environment before trying to remove it.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/138448
Approved by: https://github.com/ezyang
2024-10-21 19:35:48 +00:00
434f60ce33
Refactor nightly checkout tool ( #131134 )
...
Changes:
- Add `-C REPO` in `git` commands to allow the tool can be run everywhere not only the repo dir
- Use `pathlib.Path` as many as possible
- Replace `subprocess.run(..., check=True)` with `subprocess.check_{call,output}(...)`
- Add `encoding='utf-8'` for files
Pull Request resolved: https://github.com/pytorch/pytorch/pull/131134
Approved by: https://github.com/ezyang
2024-07-25 11:20:43 +00:00
42a4df9447
Support CUDA nightly package in tools/nightly.py ( #131133 )
...
Add a new option `--cuda` to `tools/nightly.py` to pull the nightly packages with CUDA support.
```bash
# installs pytorch-nightly with cpuonly
tools/nightly.py pull
# The following only available on Linux and Windows
# installs pytorch-nightly with latest CUDA we support
tools/nightly.py pull --cuda
# installs pytorch-nightly with CUDA 12.1
tools/nightly.py pull --cuda 12.1
```
Also add targets in `Makefile` and instructions in constribution guidelines.
```bash
# setup conda environment with pytorch-nightly
make setup-env
# setup conda environment with pytorch-nightly with CUDA support
make setup-env-cuda
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/131133
Approved by: https://github.com/ezyang
2024-07-25 05:33:52 +00:00
8a67daf283
[BE][Easy] enable postponed annotations in tools ( #129375 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129375
Approved by: https://github.com/malfet
2024-06-29 09:23:35 +00:00
a32ce5ce34
Revert "[BE][Easy] enable postponed annotations in tools ( #129375 )"
...
This reverts commit 59eb2897f1745f513edb6c63065ffad481c4c8d0.
Reverted https://github.com/pytorch/pytorch/pull/129375 on behalf of https://github.com/huydhn due to Sorry for reverting your change but I need to revert to cleanly revert https://github.com/pytorch/pytorch/pull/129374 , please do a rebase and reland this ([comment](https://github.com/pytorch/pytorch/pull/129375#issuecomment-2197800541 ))
2024-06-29 00:44:25 +00:00
59eb2897f1
[BE][Easy] enable postponed annotations in tools ( #129375 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129375
Approved by: https://github.com/malfet
2024-06-28 15:37:54 +00:00
9178deedff
removing some redundant str splits ( #106089 )
...
drop some redundant string splits, no factual changes, just cleaning the codebase
Pull Request resolved: https://github.com/pytorch/pytorch/pull/106089
Approved by: https://github.com/albanD , https://github.com/malfet
2023-09-01 00:22:58 +00:00
14d87bb5ff
[BE] Enable ruff's UP rules and autoformat tools and scripts ( #105428 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105428
Approved by: https://github.com/albanD , https://github.com/soulitzer , https://github.com/malfet
2023-07-19 01:24:44 +00:00
5a7aad9681
Convert logging f-strings to use % format, part four ( #98705 )
...
This does multi-line concatenated string literals.
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/98705
Approved by: https://github.com/voznesenskym
2023-04-11 13:17:59 +00:00
9a8f71f23e
Convert logging f-strings to use % format ( #98697 )
...
Codemod done with
https://gist.github.com/ezyang/2e8b0463cdc6be278478495b23ff0530 with
assistance from ChatGPT.
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/98697
Approved by: https://github.com/voznesenskym
2023-04-10 12:19:31 +00:00
9171f7d4cd
[BE] Modernize PyTorch even more for 3.8 with pyupgrade ( #94520 )
...
Applies some more pyupgrade fixits to PyTorch
Pull Request resolved: https://github.com/pytorch/pytorch/pull/94520
Approved by: https://github.com/ezyang
2023-02-10 18:02:50 +00:00
347b036350
Apply ufmt linter to all py files under tools ( #81285 )
...
With ufmt in place https://github.com/pytorch/pytorch/pull/81157 , we can now use it to gradually format all files. I'm breaking this down into multiple smaller batches to avoid too many merge conflicts later on.
This batch (as copied from the current BLACK linter config):
* `tools/**/*.py`
Upcoming batchs:
* `torchgen/**/*.py`
* `torch/package/**/*.py`
* `torch/onnx/**/*.py`
* `torch/_refs/**/*.py`
* `torch/_prims/**/*.py`
* `torch/_meta_registrations.py`
* `torch/_decomp/**/*.py`
* `test/onnx/**/*.py`
Once they are all formatted, BLACK linter will be removed.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81285
Approved by: https://github.com/suo
2022-07-13 07:59:22 +00:00
a11c1bbdd0
Run Black on all of tools/
...
Signed-off-by: Edward Z. Yang <ezyangfb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76089
Approved by: https://github.com/albanD
2022-04-20 17:29:41 +00:00
b9933f08b9
Fix type annotation in tools/nightly.py ( #64202 )
...
Summary:
`tempfile.TemporaryDirectory` is a generic only in python-3.9 and above
Workaround by wrapping type annotation in quotes
Fixes https://github.com/pytorch/pytorch/issues/64017
Pull Request resolved: https://github.com/pytorch/pytorch/pull/64202
Reviewed By: janeyx99
Differential Revision: D30644215
Pulled By: malfet
fbshipit-source-id: 3c16240b9fa899bd4d572c1732a7d87d3dd0fbd5
2021-08-30 13:27:43 -07:00
737d920b21
Strictly type everything in .github and tools ( #59117 )
...
Summary:
This PR greatly simplifies `mypy-strict.ini` by strictly typing everything in `.github` and `tools`, rather than picking and choosing only specific files in those two dirs. It also removes `warn_unused_ignores` from `mypy-strict.ini`, for reasons described in https://github.com/pytorch/pytorch/pull/56402#issuecomment-822743795 : basically, that setting makes life more difficult depending on what libraries you have installed locally vs in CI (e.g. `ruamel`).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/59117
Test Plan:
```
flake8
mypy --config mypy-strict.ini
```
Reviewed By: malfet
Differential Revision: D28765386
Pulled By: samestep
fbshipit-source-id: 3e744e301c7a464f8a2a2428fcdbad534e231f2e
2021-06-07 14:49:36 -07:00
75024e228c
Add lint for unqualified type: ignore ( #56290 )
...
Summary:
The other half of https://github.com/pytorch/pytorch/issues/56272 .
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56290
Test Plan:
CI should pass on the tip of this PR, and we know that the lint works because the following CI runs (before this PR was finished) failed:
- https://github.com/pytorch/pytorch/runs/2384511062
- https://github.com/pytorch/pytorch/actions/runs/765036024
Reviewed By: seemethere
Differential Revision: D27867219
Pulled By: samestep
fbshipit-source-id: e648f07b6822867e70833e23ddafe7fb7eaca235
2021-04-21 08:07:23 -07:00
e05ca753bf
Fix nightly tool for python 3.6 ( #55776 )
...
Summary:
Given that the minimal required Python version for using PyTorch is 3.6, the development tools should also be able to handle it. `./tools/nightly.py` currently uses the parameters `capture_output` and `text` of `subprocess.run` that were only added for [Python 3.7](https://docs.python.org/3/library/subprocess.html#subprocess.run ).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/55776
Reviewed By: ngimel
Differential Revision: D27709124
Pulled By: ezyang
fbshipit-source-id: aeea15a891ba792f3cd5fa602f0d7b746007e30c
2021-04-12 09:34:29 -07:00
2f5db68797
Make nightly checkout work with generated testing py ( #54477 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/54477
Signed-off-by: Edward Z. Yang <ezyang@fb.com >
Test Plan: Imported from OSS
Reviewed By: mruberry
Differential Revision: D27263065
Pulled By: ezyang
fbshipit-source-id: 7fa653fb334ff91c9100cf5adcabab6b30533a89
2021-03-24 07:40:26 -07:00
e49372d460
Bugfix nightly checkout tool to work on Windows ( #49274 )
...
Summary:
I am submitting this PR on behalf of Janne Hellsten(nurpax) from NVIDIA, for the convenience of CLA. Thanks Janne a lot for the contribution!
This fixes the bug when running `
./tools/nightly.py checkout -b my-nightly-branch` on windows. Before this fix, this command gets the following error on Windows.
```
ERROR:root:Fatal exception
Traceback (most recent call last):
File "./tools/nightly.py", line 166, in logging_manager
yield root_logger
File "./tools/nightly.py", line 644, in main
install(
File "./tools/nightly.py", line 552, in install
spdir = _site_packages(pytdir.name, platform)
File "./tools/nightly.py", line 325, in _site_packages
os.path.join(pytdir.name, "Lib", "site-packages")
NameError: name 'pytdir' is not defined
log file: d:\pytorch\nightly\log\2020-12-11_16h10m14s_6867a21e-3c0e-11eb-878e-04ed3363a33e\nightly.log
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/49274
Reviewed By: H-Huang
Differential Revision: D25808156
Pulled By: malfet
fbshipit-source-id: 00778016366ab771fc3fb152710c7849210640fb
2021-01-06 16:14:51 -08:00
2dff0b3e91
Fix typos in comments ( #48316 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/48316
Reviewed By: walterddr, mrshenli
Differential Revision: D25125123
Pulled By: malfet
fbshipit-source-id: 6f31e5456cc078cc61b288191f1933711acebba0
2020-11-24 10:56:40 -08:00
7de512ced8
nightly robustness fixes for linking across devices ( #43771 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/43761
CC rgommers ezyang
Pull Request resolved: https://github.com/pytorch/pytorch/pull/43771
Reviewed By: glaringlee
Differential Revision: D23819835
Pulled By: malfet
fbshipit-source-id: a3be2780c4b8bdbf347d456c4d14df863c2ff8c2
2020-09-21 12:32:32 -07:00
a2ae2d3203
Nightly Pull ( #43294 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/40829
This addresses remaining issues/improvements in https://github.com/pytorch/pytorch/issues/40829 that were brought up prior to https://github.com/pytorch/pytorch/issues/42635 being merged. Namely, this changes the name of the script and adds separate `checkout` and `pull` subcommands. I have tested it locally and everything appears to work. Please let me know if you encounter any issues. I hope that this supports a more natural workflow.
CC ezyang rgommers
Pull Request resolved: https://github.com/pytorch/pytorch/pull/43294
Reviewed By: pbelevich
Differential Revision: D23241849
Pulled By: ezyang
fbshipit-source-id: c24556024d7e5d14b9a5006e927819d4ad370dd7
2020-08-20 08:34:18 -07:00
