4ab847bbc7
Pyrefly suppressions 4/n ( #164615 )
...
Adds suppressions to pyrefly will typecheck clean: https://github.com/pytorch/pytorch/issues/163283
Test plan:
dmypy restart && python3 scripts/lintrunner.py -a
pyrefly check
step 1: uncomment lines in the pyrefly.toml file
step 2: run pyrefly check
step 3: add suppressions, clean up unused suppressions
before: https://gist.github.com/maggiemoss/356645cf8cfe33123d9a27f23b30f7b1
after:
0 errors (2,753 ignored)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164615
Approved by: https://github.com/oulgen
2025-10-06 16:14:36 +00:00
97d4d3c40a
PEP585 update - torch/_export ( #145138 )
...
See #145101 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145138
Approved by: https://github.com/bobrenjc93
ghstack dependencies: #145154
2025-01-19 18:48:35 +00:00
d75ffccd0a
Migrate from Tuple -> tuple in torch/_export ( #144262 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/144262
Approved by: https://github.com/avikchaudhuri
2025-01-06 22:20:26 +00:00
042d764872
[export] Update example inputs format for DB. ( #129982 )
...
Summary: To give user a simpler example code, we are getting rid of ExportArgs in favor of example_args and example_kwargs.
Test Plan: CI
Differential Revision: D59288920
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129982
Approved by: https://github.com/angelayi
2024-07-03 17:53:15 +00:00
e58ef5b65f
[export] Rewrite exportdb formatting. ( #129260 )
...
Summary: It'll be easier to generate examples if the code doesn't depend on exportdb library.
Test Plan: CI
Differential Revision: D58886554
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129260
Approved by: https://github.com/tugsbayasgalan
2024-06-25 21:04:53 +00:00
dcfa7702c3
Flip default value for mypy disallow_untyped_defs [1/11] ( #127838 )
...
See #127836 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127838
Approved by: https://github.com/oulgen
2024-06-08 18:16:33 +00:00
46712b019d
Enable local_partial_types ( #118467 )
...
When using dmypy, this setting is enabled and cannot be turned off. Force it for regular mypy too.
Signed-off-by: Edward Z. Yang <ezyang@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/118467
Approved by: https://github.com/Skylion007
ghstack dependencies: #118414 , #118418 , #118432
2024-01-28 13:38:22 +00:00
5697986482
[export] change exportdb to require torch.nn.Module ( #117570 )
...
Part of the effort to make torch.export require nn.Module.
Differential Revision: [D52631366](https://our.internmc.facebook.com/intern/diff/D52631366/ )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/117570
Approved by: https://github.com/tugsbayasgalan
2024-01-18 03:40:10 +00:00
b7b2178204
[BE]: Remove useless lambdas ( #113602 )
...
Applies PLW0108 which removes useless lambda calls in Python, the rule is in preview so it is not ready to be enabled by default just yet. These are the autofixes from the rule.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/113602
Approved by: https://github.com/albanD
2023-11-14 20:06:48 +00:00
36164265ae
[export oncall] add some examples during oncall ( #112445 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/112445
Approved by: https://github.com/ydwu4
2023-10-31 18:33:03 +00:00
5da5e068f3
deprecate constraints in favor of dynamic_shapes ( #110143 )
...
Recently we updated the `export` API to take an experimental `dynamic_shapes` argument that was meant to subsume the existing `constraints` argument.
This PR deprecates `constraints` (with a warning on its use, but without actually removing it). Simultaneously it replaces all uses of `constraints` in docs, examples, and tests with corresponding uses of `dynamic_shapes` (preserving behavior). This exercise fortunately revealed some minor bugs in the implementation which have also been fixed in this PR.
Some uses of `constraints` still remain, e.g., when `torch._dynamo.export` is called directly. (Meta-internal uses will be updated in a separate diff.)
Differential Revision: D49676049
Pull Request resolved: https://github.com/pytorch/pytorch/pull/110143
Approved by: https://github.com/tugsbayasgalan
2023-09-28 10:26:21 +00:00
485de73004
Improve unbacked symint error msg ( #107806 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/107806
Approved by: https://github.com/avikchaudhuri
2023-08-25 01:07:09 +00:00
f8119f8bda
Move Constraint class to torch.export() to avoid circular dependency in _dynamo package ( #107750 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/107750
Approved by: https://github.com/tugsbayasgalan
2023-08-24 03:07:28 +00:00
52d4b1ae31
[BE]: Enable ruff rules PIE807 and PIE810 ( #106218 )
...
* Enables PIE807 + PIE810. PIE807 is do not reimplement list builtin function using lambda and PIE810 is to always fuse startswith / endswith calls (I applied the autofixes for this before we had ruff enabled).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/106218
Approved by: https://github.com/albanD
2023-07-28 22:35:56 +00:00
0285366464
Revert "[dynamo] Maintainable code - Move export impl to a different file ( #105071 )"
...
This reverts commit 068f163dd3beb5883cda37518017d18fc6a50561.
Reverted https://github.com/pytorch/pytorch/pull/105071 on behalf of https://github.com/clee2000 due to breaking internal builds ([comment](https://github.com/pytorch/pytorch/pull/105071#issuecomment-1636654945 ))
2023-07-15 04:18:07 +00:00
068f163dd3
[dynamo] Maintainable code - Move export impl to a different file ( #105071 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105071
Approved by: https://github.com/voznesenskym
2023-07-14 09:28:33 +00:00
936cd4f2f5
Migrate exportdb to torch.export ( #104260 )
...
Reapply of (https://github.com/pytorch/pytorch/pull/103861 ). Things that needed to be fixed:
- Fix a bug with returning dict output type
- Make pass_base work with map implementation
- Fix subtle bug with dynamo not propagating "val" in node.meta
- Add export_constraints field in ExportCase in ExportDB
Pull Request resolved: https://github.com/pytorch/pytorch/pull/104260
Approved by: https://github.com/angelayi
2023-06-27 17:49:18 +00:00
518abe8b7e
Revert "Migrate exportdb to torch.export from torchdynamo.export ( #103861 )"
...
This reverts commit fb6173a4ac60ed5a22cff2c68134633eb72e53b9.
Reverted https://github.com/pytorch/pytorch/pull/103861 on behalf of https://github.com/huydhn due to It looks like this change is failing in trunk due to a landrace fb6173a4achttps://github.com/pytorch/pytorch/pull/103861#issuecomment-1601960600 ))
2023-06-22 03:24:01 +00:00
fb6173a4ac
Migrate exportdb to torch.export from torchdynamo.export ( #103861 )
...
Things that needed to be fixed:
1. Fix a bug with returning dict output type
2. Make pass_base work with map implementation
3. Fix subtle bug with dynamo not propagating "val" in node.meta
4. Add export_constraints field in ExportCase in ExportDB
Pull Request resolved: https://github.com/pytorch/pytorch/pull/103861
Approved by: https://github.com/zhxchen17 , https://github.com/ydwu4
2023-06-22 02:53:41 +00:00
26bf8894b6
[export] Replicate exportdb examples and tests in oss. ( #102769 )
...
Summary: Initial work to copy source to OSS for exportdb and make sure tests can run properly.
Test Plan: test_export
Differential Revision: D46369152
Pull Request resolved: https://github.com/pytorch/pytorch/pull/102769
Approved by: https://github.com/angelayi
2023-06-04 20:01:57 +00:00
