3255e7872b
Enable all flake8-logging-format rules ( #164655 )
...
These rules are enabled by removing existing suppressions.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164655
Approved by: https://github.com/janeyx99 , https://github.com/mlazos
2025-10-19 00:59:28 +00:00
f02e3947f6
Expand type checking to mypy strict files ( #165697 )
...
Expands Pyrefly type checking to check the files outlined in the mypy-strict.ini configuration file:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165697
Approved by: https://github.com/ezyang
2025-10-18 04:34:45 +00:00
23417ae50f
[Submodule] Bump FBGEMM to latest ( #165544 )
...
Summary:
* FBGEMM submodule updated to main
* CMake updated to reflect necessary changes
* Notably pulls in NVFP4 grouped gemm kernels
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Signed-off-by: Simon Layton <simonlayton@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165544
Approved by: https://github.com/cyyever , https://github.com/jeffdaily
2025-10-18 03:58:08 +00:00
7dabfb07cb
[torchfuzz] add support for --stop-at-first-failure flag ( #165529 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165529
Approved by: https://github.com/pianpwk
ghstack dependencies: #164749
2025-10-17 02:18:07 +00:00
d0add0be43
[torchfuzz] check in some more ignore regexes ( #164749 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164749
Approved by: https://github.com/pianpwk
2025-10-17 02:18:07 +00:00
d82527b32a
[Windows] Add AOTI cross-compilation CI ( #165573 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165573
Approved by: https://github.com/malfet
ghstack dependencies: #165560
2025-10-17 01:05:35 +00:00
b2953f5643
[9/N] Apply ruff UP035 rule ( #165515 )
...
This is follow-up of #165214 to continue applying ruff UP035 rule to the code base.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165515
Approved by: https://github.com/Lucaskabela
2025-10-17 00:09:51 +00:00
d795fb225a
[RFC] Add pyrefly to lintrunner ( #165179 )
...
This will add pyrefly to lint runner as a warning only - and allow us to collect feedback about the tool before switching to pyrefly as the main type checker.
References the steps outlined here: : https://github.com/pytorch/pytorch/issues/163283 :
test plan:
`lintrunner init`
`lintrunner`
confirm when pyrefly errors are present results look like: https://gist.github.com/maggiemoss/e6cb2d015dd1ded560ae1329098cf33f
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165179
Approved by: https://github.com/ezyang
2025-10-16 20:07:09 +00:00
ffc7552e01
See if we can handle uploading all test data ( #165484 )
...
Fixes #ISSUE_NUMBER
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165484
Approved by: https://github.com/izaitsevfb
2025-10-15 19:57:41 +00:00
2c600bb665
[torchfuzz] fix some errors when walkthroughing README.md ( #165225 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165225
Approved by: https://github.com/soulitzer
2025-10-13 17:17:50 +00:00
8de85896e0
Enable ruff rule E721 ( #165162 )
...
`E721` checks for object type comparisons using == and other comparison operators. This is useful because it is recommended to use `is` for type comparisons.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165162
Approved by: https://github.com/Skylion007
2025-10-13 01:48:55 +00:00
816fb7f48d
Revert "Enable ruff rule E721 ( #165162 )"
...
This reverts commit 9e7c19f72b6d0690915c307409c0c0a76b5a3bf0.
Reverted https://github.com/pytorch/pytorch/pull/165162 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](https://github.com/pytorch/pytorch/pull/165162#issuecomment-3393328271 ))
2025-10-11 13:25:40 +00:00
9e7c19f72b
Enable ruff rule E721 ( #165162 )
...
`E721` checks for object type comparisons using == and other comparison operators. This is useful because it is recommended to use `is` for type comparisons.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165162
Approved by: https://github.com/Skylion007
2025-10-11 06:43:53 +00:00
af42256db4
Fix missing brackets ( #165138 )
...
As stated in the title.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165138
Approved by: https://github.com/Aidyn-A , https://github.com/Skylion007
2025-10-10 17:23:31 +00:00
a029675f6f
More ruff SIM fixes ( #164695 )
...
This PR applies ruff `SIM` rules to more files. Most changes are about simplifying `dict.get` because `None` is already the default value.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164695
Approved by: https://github.com/ezyang
2025-10-09 03:24:50 +00:00
f37a6523ef
Move version.h to torch/headeronly ( #164381 )
...
Differential Revision: [D83685392](https://our.internmc.facebook.com/intern/diff/D83685392 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164381
Approved by: https://github.com/janeyx99
2025-10-07 17:47:30 +00:00
4bcc05777e
[torchfuzz] synthesize inputs for data dependent ops ( #164716 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164716
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434 , #164514 , #164646 , #164647 , #164649 , #164687 , #164688 , #164693 , #164694 , #164715
2025-10-07 05:40:32 +00:00
2a6cdba6e5
[torchfuzz] various edge case fixes ( #164715 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164715
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434 , #164514 , #164646 , #164647 , #164649 , #164687 , #164688 , #164693 , #164694
2025-10-07 05:30:46 +00:00
53f6cc7529
[torchfuzz] make ops_fuzzer deterministic ( #164694 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164694
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434 , #164514 , #164646 , #164647 , #164649 , #164687 , #164688 , #164693
2025-10-07 05:30:46 +00:00
ac901bf79a
[torchfuzz] consolidate on a base implementation of args_codegen ( #164693 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164693
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434 , #164514 , #164646 , #164647 , #164649 , #164687 , #164688
2025-10-07 05:20:28 +00:00
c965d6dbb2
[torchfuzz] move into experimental dir ( #164688 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164688
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434 , #164514 , #164646 , #164647 , #164649 , #164687
2025-10-07 05:09:08 +00:00
ac08556f67
[torchfuzz] support more unbacked functions ( #164687 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164687
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434 , #164514 , #164646 , #164647 , #164649
2025-10-07 05:00:03 +00:00
5fe7f29b9e
[torchfuzz] add support for operator weights ( #164649 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164649
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434 , #164514 , #164646 , #164647
2025-10-07 05:00:03 +00:00
ded099ecbf
[torchfuzz] don't use the first gpu in multi process fuzzer ( #164647 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164647
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434 , #164514 , #164646
2025-10-07 04:59:56 +00:00
63fcc3e6c4
[torchfuzz] update README.md ( #164646 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164646
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434 , #164514
2025-10-07 04:59:50 +00:00
49f7d8d19d
[ROCm] Fix test_cuda_synchronize failure on ROCm ( #164735 )
...
This PR skips the hipify step of torch/csrc/jit/ir/ir.h to avoid a build-time error for the JIT cuda namespace. This fixes two skipped tests in test/jit/test_cuda.py.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164735
Approved by: https://github.com/jeffdaily
Co-authored-by: Jeff Daily <jeff.daily@amd.com >
2025-10-07 01:14:24 +00:00
86c789849e
[fr] Re-order mismatch check in fr analysis script ( #164606 )
...
In reality we found the current mismatch order does not match the actual error distribution, so we reorder it a bit as following:
1. We do collective type check first
2. Then size check (excluding all2all)
3. dtype check
4. state check
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164606
Approved by: https://github.com/VieEeEw
2025-10-04 01:16:15 +00:00
3db2164341
[torchfuzz] add norm operators ( #164514 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164514
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432 , #164434
2025-10-03 14:44:19 +00:00
5bb8f04d3e
[torchfuzz] add nn functional ops ( #164434 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164434
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432
2025-10-03 14:44:19 +00:00
7617b113ad
[torchfuzz] Support EagerVsFullGraphDynamicCompileWithNumericsCheck ( #164432 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164432
Approved by: https://github.com/pianpwk
2025-10-03 06:42:20 +00:00
c6329524d8
Revert "Add magic TORCH_MAKE_PYBIND_ENUM_FASTER macro ( #163527 )"
...
This reverts commit 50c0550f5a5b1e35885d892081a7d5115d8b4489.
Reverted https://github.com/pytorch/pytorch/pull/163527 on behalf of https://github.com/swolchok due to breaking import torch in debug builds, see #164297 ([comment](https://github.com/pytorch/pytorch/pull/163527#issuecomment-3361919142 ))
2025-10-02 15:42:42 +00:00
9697a7ce9e
Better path handling for nightly setup tool ( #164215 )
...
Resolves https://github.com/pytorch/pytorch/issues/164010#issuecomment-3349283789 , cc @filipviz
Previously, the `checkout` subcommand would reuse the `venv`, while the `pull` subcommand would remove and recreate a fresh new `venv` (without prompting before deleting).
This PR:
- Keep and reuse the existing `venv` by default (both `pull` and `checkout`).
- Add a new `--fresh` option to delete and recreate a fresh new `venv`.
- Prompt the user for confirmation (add a new `--yes` option) before deleting the existing prefix path.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164215
Approved by: https://github.com/ezyang , https://github.com/malfet
ghstack dependencies: #162324 , #164214
2025-10-02 07:59:17 +00:00
39b31a6bfd
[torchfuzz] keep track of operator stats ( #164334 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164334
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034 , #164209 , #164211 , #164210 , #164397 , #164284
2025-10-02 03:48:07 +00:00
0fbe3f19c7
[torchfuzz] add matmuls ( #164284 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164284
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034 , #164209 , #164211 , #164210 , #164397
2025-10-02 03:33:10 +00:00
144378615a
[torchfuzz] make fuzzer deterministic ( #164397 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164397
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034 , #164209 , #164211 , #164210
2025-10-02 03:10:30 +00:00
e5c0e6b5e3
[testing] Better short job name during upload additional stats ( #164287 )
...
I think we usually we leave the ` / test` in for clarity
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164287
Approved by: https://github.com/atalman , https://github.com/malfet
2025-10-01 19:56:20 +00:00
17ab99463a
[Easy] Add notes for setting up dev venv with specific Python version ( #164214 )
...
Resolves https://github.com/pytorch/pytorch/issues/164010#issuecomment-3340751377
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164214
Approved by: https://github.com/ezyang
ghstack dependencies: #162324
2025-10-01 08:25:13 +00:00
eca6ac2293
[BE][Easy] update CUDA and ROCm sources in nightly tool ( #162324 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/162324
Approved by: https://github.com/ezyang
2025-10-01 08:25:13 +00:00
10a005e87f
[torchfuzz] add layout operators ( #164210 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164210
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034 , #164209 , #164211
2025-10-01 02:33:19 +00:00
1f3995cdc8
[torchfuzz] raise if Operator abstract method is not implemented ( #164211 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164211
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034 , #164209
2025-10-01 02:33:19 +00:00
abfcce58a4
[torchfuzz] remove erroneous can_produce check ( #164209 )
...
can_produce is an abstract method that always return false
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164209
Approved by: https://github.com/pianpwk
ghstack dependencies: #164034
2025-10-01 02:33:19 +00:00
96330f490d
[testing] Add upload for test status during test stat uploads ( #164189 )
...
Add test status (flaky, success, skipped, failure) upload for easier comparison between test status on two commits
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164189
Approved by: https://github.com/huydhn , https://github.com/malfet
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com >
2025-09-30 15:53:53 +00:00
edd9e07aff
[BE] Remove not existing mnist mirror ( #164238 )
...
Looks like original source is empty now:
http://yann.lecun.com/exdb/mnist/
Pytorch hosted mirror exist. Hence leaving it as only option.
https://ossci-datasets.s3.amazonaws.com/mnist/
Fixes these errors in pytorch/ci:
```
C:\actions-runner\_work\pytorch\pytorch>python tools\download_mnist.py --quiet -d C:\actions-runner\_work\pytorch\pytorch\test\cpp\api\mnist
Downloading http://yann.lecun.com/exdb/mnist/train-images-idx3-ubyte.gz ...
Failed to download (trying next):
HTTP Error 404: Not Found
Downloading https://ossci-datasets.s3.amazonaws.com/mnist/train-images-idx3-ubyte.gz ...
Downloading http://yann.lecun.com/exdb/mnist/train-labels-idx1-ubyte.gz ...
Failed to download (trying next):
HTTP Error 404: Not Found
Downloading https://ossci-datasets.s3.amazonaws.com/mnist/train-labels-idx1-ubyte.gz ...
Downloading http://yann.lecun.com/exdb/mnist/t10k-images-idx3-ubyte.gz ...
Failed to download (trying next):
HTTP Error 404: Not Found
Downloading https://ossci-datasets.s3.amazonaws.com/mnist/t10k-images-idx3-ubyte.gz ...
Downloading http://yann.lecun.com/exdb/mnist/t10k-labels-idx1-ubyte.gz ...
Failed to download (trying next):
HTTP Error 404: Not Found
Downloading https://ossci-datasets.s3.amazonaws.com/mnist/t10k-labels-idx1-ubyte.gz ...
```
Link to workflow with example:
https://github.com/pytorch/pytorch/actions/runs/18109150240/job/51542177282#step:15:2335
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164238
Approved by: https://github.com/jeanschmidt
2025-09-30 15:15:13 +00:00
c39357bab6
[torchfuzz] Make scalar and tensor distribution configurable ( #164034 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164034
Approved by: https://github.com/pianpwk
2025-09-30 04:50:54 +00:00
50d418f69f
Replace setup.py bdist_wheel with python -m build --wheel ( #156712 )
...
Previously we already replaced most use of `python setup.py develop/install`.
This PR also replaces the use of `setup.py bdist_wheel` with the modern `python -m build --wheel` alternative.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156712
Approved by: https://github.com/atalman
ghstack dependencies: #156711
2025-09-29 21:51:32 +00:00
c332d58184
[testing] upload test stats: Add info to the invoking file summary and some other changes ( #164016 )
...
* Changes some internal logic for grouping so hopefully it's slightly less annoying write code for
* Changes the invoking file summary to just use file, which I think is correct most of the time
* Adds some fields to the file summary, like skips, errors, etc so I can reuse it for file report regression things
Output should be the same, maybe with slightly more fields since I got rid of some of the pops
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164016
Approved by: https://github.com/huydhn
2025-09-29 21:20:18 +00:00
ad32ed83b3
[Fix] Adding missing f prefixes to formatted strings [3/N] ( #164067 )
...
As stated in the title.
* #164068
* __->__ #164067
* #164066
* #164065
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164067
Approved by: https://github.com/Skylion007
2025-09-29 04:35:23 +00:00
dcb8af7501
[torchfuzz] fix bool propagation ( #164003 )
...
bools can't propogate through the current pointwise ops such as add/mul. once we add more that can, we'll probably want to add an additional subclass that supports pointwise bools, but for now just don't allow it.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164003
Approved by: https://github.com/pianpwk
ghstack dependencies: #163743 , #163812 , #163890 , #164002
2025-09-27 04:51:29 +00:00
8a0e8cad5f
lint: Only include files in pytorch ( #164008 )
...
We were seeing instances of stdlib files in clang-tidy output so this
just essentially removes them from the things that lintrunner will
report up. Longer term fix here would be to just modify the clang-tidy
configuration in order to do the correct thing here but that requires a
bit more investigation as to why this is only happening in CI and is not
reproduceable locally.
Signed-off-by: Eli Uriegas <eliuriegas@meta.com >
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164008
Approved by: https://github.com/ZainRizvi
2025-09-27 00:54:07 +00:00
3a115da3e6
[torchfuzz] ones over zero ( #164002 )
...
reduces likelihood of divide by zero errors. long term we'll probably want to just fuzz these values entirely
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164002
Approved by: https://github.com/pianpwk
ghstack dependencies: #163743 , #163812 , #163890
2025-09-27 00:53:02 +00:00
