8de85896e0
Enable ruff rule E721 ( #165162 )
...
`E721` checks for object type comparisons using == and other comparison operators. This is useful because it is recommended to use `is` for type comparisons.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165162
Approved by: https://github.com/Skylion007
2025-10-13 01:48:55 +00:00
816fb7f48d
Revert "Enable ruff rule E721 ( #165162 )"
...
This reverts commit 9e7c19f72b6d0690915c307409c0c0a76b5a3bf0.
Reverted https://github.com/pytorch/pytorch/pull/165162 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](https://github.com/pytorch/pytorch/pull/165162#issuecomment-3393328271 ))
2025-10-11 13:25:40 +00:00
9e7c19f72b
Enable ruff rule E721 ( #165162 )
...
`E721` checks for object type comparisons using == and other comparison operators. This is useful because it is recommended to use `is` for type comparisons.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165162
Approved by: https://github.com/Skylion007
2025-10-11 06:43:53 +00:00
4e35594674
[Lowering] Fix the edge case of empty subgraph split due to dataclass node ( #161716 )
...
Summary: Fix the edge case by allowing `call_function` nodes with no deps as graph entry (starter_nodes) in the splitter.
Test Plan:
The test shall pass in the current diff (after fix), and fail in the parent diff (before fix)
```
buck test mode/opt //glow/fb/fx/lowering:split_tests -- test_dataclass_as_graph_entry
```
Rollback Plan:
Differential Revision: D81232435
Pull Request resolved: https://github.com/pytorch/pytorch/pull/161716
Approved by: https://github.com/ezyang
2025-09-10 21:23:42 +00:00
c8d44a2296
Add __main__ guards to fx tests ( #154715 )
...
This PR is part of a series attempting to re-submit #134592 as smaller PRs.
In fx tests:
- Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run.
- Raise a RuntimeError on tests which have been disabled (not run)
- Remove any remaining uses of "unittest.main()""
Pull Request resolved: https://github.com/pytorch/pytorch/pull/154715
Approved by: https://github.com/Skylion007
2025-06-04 14:38:50 +00:00
99dbc5b0e2
PEP585 update - test ( #145176 )
...
See #145101 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145176
Approved by: https://github.com/bobrenjc93
2025-01-22 04:48:28 +00:00
ba5cacbc17
[Codemod][AddExplicitStrictExportArg] caffe2/test ( #143688 )
...
Reviewed By: avikchaudhuri
Differential Revision: D67530154
Pull Request resolved: https://github.com/pytorch/pytorch/pull/143688
Approved by: https://github.com/tugsbayasgalan
2024-12-27 07:58:44 +00:00
d8c8ba2440
Fix unused Python variables in test/[e-z]* ( #136964 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136964
Approved by: https://github.com/justinchuby , https://github.com/albanD
2024-12-18 23:02:30 +00:00
221350e3a4
Add None return type to init -- tests ( #132352 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132352
Approved by: https://github.com/ezyang
ghstack dependencies: #132335 , #132351
2024-08-01 15:44:51 +00:00
76169cf691
[BE][Easy][9/19] enforce style for empty lines in import segments in test/[e-h]*/
( #129760 )
...
See https://github.com/pytorch/pytorch/pull/129751#issue-2380881501 . Most changes are auto-generated by linter.
You can review these PRs via:
```bash
git diff --ignore-all-space --ignore-blank-lines HEAD~1
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129760
Approved by: https://github.com/ezyang
2024-07-17 14:25:29 +00:00
c96bd3de06
Enable UFMT on all of test/fx
( #123622 )
...
Partially addresses #123062
Ran lintrunner on:
- `test/fx`
with command:
```bash
lintrunner -a --take UFMT --all-files
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/123622
Approved by: https://github.com/ezyang
2024-04-09 15:59:17 +00:00
0a1b3be216
chore: add unit test to verify split_by_tags output_type ( #121262 )
...
Add a test case as per https://github.com/pytorch/pytorch/pull/120361#issuecomment-1979163324
Pull Request resolved: https://github.com/pytorch/pytorch/pull/121262
Approved by: https://github.com/atalman
2024-03-18 19:19:26 +00:00
e30d436b01
[fx][split][testing] Add testing for #107981 ( #108731 )
...
- Follow-up to #107981 , adding testing for metadata copying in placeholder nodes within the `split_by_tags` utility
- Validation included in the test from #107248 , since both tests are relevant to the same aspect of the utility
Pull Request resolved: https://github.com/pytorch/pytorch/pull/108731
Approved by: https://github.com/angelayi
2023-12-18 20:19:18 +00:00
393fe9339a
Back out "Revert D49107540: [pytorch][PR] split by tag" ( #109332 )
...
Summary:
Original commit changeset: 6391a068640b
Original Phabricator Diff: D49107540
Test Plan: same as D49107540
Differential Revision: D49297522
Pull Request resolved: https://github.com/pytorch/pytorch/pull/109332
Approved by: https://github.com/842974287
2023-09-16 05:29:16 +00:00
bf5622e965
Revert "split by tag ( #108892 )"
...
This reverts commit 89b6276be9f1b04491625cc0d05de01c15f75597.
Reverted https://github.com/pytorch/pytorch/pull/108892 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](https://github.com/pytorch/pytorch/pull/108892#issuecomment-1720249148 ))
2023-09-14 22:43:03 +00:00
89b6276be9
split by tag ( #108892 )
...
Differential Revision: D49107540
Pull Request resolved: https://github.com/pytorch/pytorch/pull/108892
Approved by: https://github.com/842974287
2023-09-14 21:49:11 +00:00
2e73c86d45
[fx][split] make sure we copy node.meta over during split ( #107248 )
...
Summary: Previously when we create placeholder nodes for sub graph modules, we didn't copy node.meta over.
Test Plan: CI
Differential Revision: D48330866
Pull Request resolved: https://github.com/pytorch/pytorch/pull/107248
Approved by: https://github.com/zyan0 , https://github.com/houseroad , https://github.com/Neilblaze
2023-08-22 00:06:45 +00:00