4481 Commits

Author SHA1 Message Date
84d6796658 move AWS ECR gc jobs to circleci (#30996)
Summary:
all jobs are currently running with "--dry-run", so you can verify if the jobs are doing the right thing.  i'll remove the flag and make it runs every hour same as on Jenkins once this PR is approved.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/30996

Differential Revision: D18971001

Pulled By: mingbowan

fbshipit-source-id: 2384bdb50ebdf47aad265395f26be3843f0ce05e
2019-12-12 14:28:20 -08:00
0db6c01301 Re-enable python 2 builds (#31164)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/31164

We have a small number of internal projects that still are on Python 2.
Until we can figure out how to get rid of them, we need to continue
supporting Python 2 for PyTorch.

Test Plan: Imported from OSS

Differential Revision: D18949698

Pulled By: suo

fbshipit-source-id: 4a9d7e4306ed81576e05f243de472937a2bb1176
2019-12-11 22:02:28 -08:00
28ee309c9a disable onnx py3 gcc5 build (#31100)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/31100

This appears to not work right now. Disabling pending an investigation.

Test Plan: Imported from OSS

Differential Revision: D18928777

Pulled By: suo

fbshipit-source-id: 63089131bad98902979e5cf4373732c85badef9d
2019-12-11 00:26:15 -08:00
b7652a2f81 remove py2 flake8 lint (#29357)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/29357

As title

Test Plan: Imported from OSS

Reviewed By: pritamdamania87

Differential Revision: D18920562

Pulled By: suo

fbshipit-source-id: b5dd559cfb0ba6c64b9ccf3655417afb56a7b472
2019-12-10 15:31:10 -08:00
62b10721fb Actually make flake8 do something (#30892)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/30892

Fixes all outstanding lints and actually installs a properly configured
flake8

Test Plan: Imported from OSS

Differential Revision: D18862825

Pulled By: suo

fbshipit-source-id: 08e9083338a7309272e17bb803feaa42e348aa85
2019-12-06 17:50:50 -08:00
7e472679ff pin actions/checkout version
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/30703

Test Plan: Imported from OSS

Differential Revision: D18805447

Pulled By: suo

fbshipit-source-id: d58ebe0e90b81c9282d3977f36c53c54cac750d9
2019-12-03 20:52:54 -08:00
4e6379379c fetch before checking out PR tip
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/30680

Test Plan: Imported from OSS

Differential Revision: D18796189

Pulled By: suo

fbshipit-source-id: 99da48e5fd510ffdf4e606c2393eb55d4f6ca8d5
2019-12-03 14:43:19 -08:00
23fcc409d5 Revert "switch back to azure pipelines" (#29910)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/29910

This reverts commit 6de1016f9dbf624f93f8c8d45feb56f8c222b7a6.

Test Plan: Imported from OSS

Differential Revision: D18532474

Pulled By: suo

fbshipit-source-id: 852fdcf21bd4aa7ca94322d64e43aab5a822cabc
2019-11-15 11:00:14 -08:00
6de1016f9d switch back to azure pipelines
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/29740

Test Plan: Imported from OSS

Differential Revision: D18482697

Pulled By: suo

fbshipit-source-id: 72a454457a005f82683079b79a77343e20c34021
2019-11-13 11:50:38 -08:00
9fb0079036 merge some of the lint checks (#28933)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/28933

Merge all the things that don't add annotations into a single
`quick-checks` job. This helps reduce concurrency and clutter
at the top of the status check page.

This doesn't touch the actually important items (flake8 + clang-tidy),
but those are a little trickier to handle because of how annotations are
added.

Test Plan: Imported from OSS

Differential Revision: D18235396

Pulled By: suo

fbshipit-source-id: 8fba44f3f5d398b1dce0f39f51d6652f3e0c1bf7
2019-10-30 23:02:34 -07:00
fd5c68b5e4 Revert D18231741: Enable PyTorch Probot as a GitHub Action.
Test Plan: revert-hammer

Differential Revision:
D18231741

Original commit changeset: d49711ad41d7

fbshipit-source-id: f390ec3ca8c55bfc308d8eacad5dd7dfae36500e
2019-10-30 18:24:40 -07:00
e3a24ba6d5 Enable PyTorch Probot as a GitHub Action. (#28879)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/28879

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: Imported from OSS

Differential Revision: D18231741

Pulled By: ezyang

fbshipit-source-id: d49711ad41d7ff7e527326c68fd8db86da10a818
2019-10-30 13:59:23 -07:00
83331bf123 don't overspecify required python version (#28842)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/28842

We don't care which python version, and github actions has changed the
versions available, breaking our CI. So just pin it to 3-something to
make it more future proof

Test Plan: Imported from OSS

Differential Revision: D18205349

Pulled By: suo

fbshipit-source-id: bf260dc29a138dd8bf8c85081a182aae298fe86d
2019-10-29 12:08:47 -07:00
9f890a9218 make sure clang-tidy is diffing against the right thing (#28788)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/28788

Okay, my last fix was wrong because it turns out that the base SHA is
computed at PR time using the actual repo's view of the base ref, not
the user's. So if the user doesn't rebase on top of the latest master
before putting up the PR, the diff thing is wrong anyway.

This PR fixes the issue by not relying on any of these API details and
just getting the merge-base of the base and head refs, which should
guarantee we are diffing against the right thing.

This solution taken from https://github.com/github/VisualStudio/pull/1008

Test Plan: Imported from OSS

Differential Revision: D18172391

Pulled By: suo

fbshipit-source-id: 491a50119194508b2eefa5bd39fe813ca85f27b1
2019-10-28 13:47:51 -07:00
0a364108d2 use base sha in clang-tidy instead of base ref (#28388)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/28388

The clang-tidy script diffs the PR head ref against the base ref so that
it works only on changed lines. If the base ref is a stale `master`,
then the script will fetch upstream `master` and potentially report
unrelated changes in the diff

Use the base sha instead of ref so that the revision that the script
diffs against is stable.

Test Plan: Imported from OSS

Differential Revision: D18051363

Pulled By: suo

fbshipit-source-id: 80ead2f837e2d6244245ed7b576e84a99f0ea035
2019-10-21 17:07:57 -07:00
2d2fe14a60 Install CUDA for clang-tidy (#27967)
Summary:
fixes: https://github.com/pytorch/pytorch/issues/28009

clang-tidy is reporting `'cuda_runtime_api.h' file not found` when a PR modifying some file including this header.

Installation script take from official site:
https://developer.nvidia.com/cuda-downloads?target_os=Linux&target_arch=x86_64&target_distro=Ubuntu&target_version=1804&target_type=debnetwork
Pull Request resolved: https://github.com/pytorch/pytorch/pull/27967

Differential Revision: D17952383

Pulled By: ezyang

fbshipit-source-id: 85807d93bd46eb902a84b2126784349ce3a01cfa
2019-10-16 10:02:19 -07:00
09464a7bf5 cleanup lint scripts a bit (#27805)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/27805

The expressions syntax for actions is pretty cool! Using it to clean up
some of my convoluted checks from before

Test Plan: Imported from OSS

Differential Revision: D17909353

Pulled By: suo

fbshipit-source-id: 8b9a85476ba19452f48c532a2daed830f074088a
2019-10-14 20:19:48 -07:00
5b88dd6a29 fix checkout for clang-tidy (#27796)
Summary:
whoops, this got left in by accident
Pull Request resolved: https://github.com/pytorch/pytorch/pull/27796

Differential Revision: D17892482

Pulled By: suo

fbshipit-source-id: f92255d78fe70d3c22c4422b6333ac288cb330d6
2019-10-11 18:43:25 -07:00
ba20ad999c port the rest of the linters over to github actions
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/27768

Test Plan: Imported from OSS

Differential Revision: D17888973

Pulled By: suo

fbshipit-source-id: 635bef7854084404d08673d99b1bae502e0dc833
2019-10-11 17:01:59 -07:00
640b486339 add clang-tidy to github actions (#27755)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/27755

This gives us nice annotations. See
https://github.com/suo/pytorch/pull/22/files for an approximation of
what it will look like (ignore the warnings on the lint.yml file).

I deleted the old azure pipelines one since making the code work for
both was annoying, and unlike flake8 this one does not affect master

Test Plan: Imported from OSS

Differential Revision: D17888974

Pulled By: suo

fbshipit-source-id: d8928a1451b6ef500dc1889284cab2845ecdeeea
2019-10-11 17:01:50 -07:00
c0c2921a06 fix annotation regex for flake8 (#26694)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/26694

Previously we would not properly populate `errorDesc` for:
```
./torch/jit/__init__.py:13:1: F401 'torch.nn.ModuleList' imported but unused
```

because we wanted only letters and spaces. Be more permissive

Test Plan: Imported from OSS

Differential Revision: D17551999

Pulled By: suo

fbshipit-source-id: b82567df1fa3c9729e7427dc3461bedfb40933dc
2019-09-24 16:29:47 -07:00
7f89464b2d fix github actions for forked PRs (#26562)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/26562

I was trying to be too clever with GITHUB_HEAD_REF...

Test Plan: Imported from OSS

Reviewed By: driazati

Differential Revision: D17538517

Pulled By: suo

fbshipit-source-id: 82c71ee3c6edb299ac8eb73675d96967e00a29f1
2019-09-23 17:59:37 -07:00
587128e3dc Use github actions for flake8 (#25824)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/25824

Use github actions for flake8. This is nice because it makes it easier
to create inline annotations for lint violations.

It ends up looking like this:
https://github.com/suo/pytorch/pull/21/files

Test Plan: Imported from OSS

Differential Revision: D17487007

Pulled By: suo

fbshipit-source-id: 663094ea2bbbdb1da5b7e5d294c70735a319d5e5
2019-09-19 14:37:37 -07:00
b0e794e6e9 Configure pytorch-probot (#24423)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/24423

This enables auto-CC'ing based on labels, see
https://github.com/pytorch/pytorch/issues/24422

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: Imported from OSS

Differential Revision: D16833974

Pulled By: ezyang

fbshipit-source-id: de07ea5f0ade9d5ed2160ce8308cf146321bb354
2019-08-15 12:09:01 -07:00
52be1448e8 Docs: Delete placeholder to use top-level file (#23869)
Summary:
Replaces and closes https://github.com/pytorch/pytorch/issues/23864.

When opening a pull request, GitHub shows you this:

![image](https://user-images.githubusercontent.com/1324225/62534181-30142880-b851-11e9-9b39-32d0ed6ff26c.png)

Or this:

![image](https://user-images.githubusercontent.com/1324225/62534569-24753180-b852-11e9-8242-8905ddda1f6f.png)

However, that links to https://github.com/pytorch/pytorch/blob/master/.github/CONTRIBUTING.md which looks like:

![image](https://user-images.githubusercontent.com/1324225/62534607-3656d480-b852-11e9-8c8c-37f54e8ca774.png)

As the commit message shows, that was a placeholder. There's already a real `CONTRIBUTING.md` document, so *delete the placeholder*.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/23869

Differential Revision: D16667966

Pulled By: ezyang

fbshipit-source-id: c4135ebbb75de803ef227e4608e16da1a2e83a0c
2019-08-06 08:14:10 -07:00
75b1ae1acd Update issue templates
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/12114

Reviewed By: soumith

Differential Revision: D10060349

Pulled By: JoelMarcey

fbshipit-source-id: ed88bf95f78742b089adb043e88613a5db006a10
2018-09-26 16:26:00 -07:00
c33d7f565b updated the environment collection script URL to the raw version on Github to download the script instead of the webpage (#6927) 2018-04-24 23:30:32 -04:00
7a3c38ab59 Add environment collection script (#6635)
* Add environment collection script

Fixes #6111. This should make it easier for users to report bugs by giving
them a script to collect system environment information.

Changes include:
- Refactor out the environment collecting code from utils.bottleneck
- Add script (collect_env.py)
- Cleaned up the issues template so that it suggests using the script
  and is more readable.

Testing: added expect tests to go with 4 CI configurations. Whenever one
of these configurations gets updated, the test will fail until the test
also gets updated.

* Expect tests

* Update issue template

* Fix random space

* Minor improvement to issue template; fix expect test

* Skip expect test if BUILD_ENVIRONMENT not found; test fix; split off smoke/expect test
2018-04-22 15:18:14 -04:00
90afedb6e2 Merge caffe2 with pytorch. 2018-03-30 10:29:50 -07:00
e60f7e2490 Create issue template with guidelines for issue submissions (#4810) 2018-01-23 15:00:40 -05:00
d84033dc6b Add placeholders for issues/pull requests
Summary: Closes https://github.com/caffe2/caffe2/pull/1604

Differential Revision: D6537325

Pulled By: pietern

fbshipit-source-id: 90dae8389e318ff36c8455a0e002c8e42167aa9a
2017-12-11 14:35:25 -08:00